From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A5FD45DB9 for ; Wed, 27 Nov 2024 18:23:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B166402DE; Wed, 27 Nov 2024 18:23:50 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1C494402DE for ; Wed, 27 Nov 2024 18:23:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ITpuK7aEV/47S85o1osqNEcTaCAL/uMz6q9aLdRhqcs=; b=FdOmaVL64+YKkYegAwOg7Ehw9tf4FB318I1+FuyiuKPXBX20cYGfuZ/1hQ82FO/YE8CxJm LgpYqwZYl3sZLQnDT4OzF46i/oSBUBfeAZQeNtUN6PHVfRgzv0JOzNyFOmZZltmYCXQTjJ /AeQJbnkX29A7Ro0RdEP05I13wzyG40= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-3HLtQxIpOzCqORNdoX7oZg-1; Wed, 27 Nov 2024 12:23:44 -0500 X-MC-Unique: 3HLtQxIpOzCqORNdoX7oZg-1 X-Mimecast-MFC-AGG-ID: 3HLtQxIpOzCqORNdoX7oZg Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9B3461955F42; Wed, 27 Nov 2024 17:23:43 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3DFED300019E; Wed, 27 Nov 2024 17:23:41 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Ferruh Yigit , dpdk stable Subject: patch 'doc: correct definition of stats per queue feature' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:19:09 +0000 Message-ID: <20241127171916.690404-122-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: M0LV-NgGirj6Wu3SEO7IDnuo9sTV7UdjCodKD85Ry1M_1732728223 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/db0eb7fb7bc68dd241029ae2cc46f487ef712d1a Thanks. Kevin --- >From db0eb7fb7bc68dd241029ae2cc46f487ef712d1a Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 10 Oct 2024 18:38:27 -0700 Subject: [PATCH] doc: correct definition of stats per queue feature [ upstream commit 71eae7fe3eac90b70200460c714d1c13ee43dc25 ] Change the documentation to match current usage of this feature in the NIC table. Moved this sub heading to be after basic stats because the queue stats reported now are in the same structure. Although the "Stats per Queue" feature was originally intended to be related to stats mapping, the overwhelming majority of drivers report this feature with a different meaning. Hopefully in later release the per-queue stats limitations can be fixed, but this requires and API, ABI, and lots of driver changes. Fixes: dad1ec72a377 ("doc: document NIC features") Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit --- doc/guides/nics/features.rst | 34 ++++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index 841f3704b1..adbf118f2d 100644 --- a/doc/guides/nics/features.rst +++ b/doc/guides/nics/features.rst @@ -689,6 +689,4 @@ Support basic statistics such as: ipackets, opackets, ibytes, obytes, imissed, ierrors, oerrors, rx_nombuf. -And per queue stats: q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors. - These apply to all drivers. @@ -697,4 +695,24 @@ These apply to all drivers. +.. _nic_features_stats_per_queue: + +Stats per queue +--------------- + +Supports per queue stats: q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors. +Statistics only supplied for first ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` (16) queues. +If driver does not support this feature the per queue stats will be zero. + +* **[implements] eth_dev_ops**: ``stats_get``, ``stats_reset``. +* **[related] API**: ``rte_eth_stats_get``, ``rte_eth_stats_reset()``. + +May also support configuring per-queue stat counter mapping. +Used by some drivers to workaround HW limitations. + +* **[implements] eth_dev_ops**: ``queue_stats_mapping_set``. +* **[related] API**: ``rte_eth_dev_set_rx_queue_stats_mapping()``, + ``rte_eth_dev_set_tx_queue_stats_mapping()``. + + .. _nic_features_extended_stats: @@ -711,16 +729,4 @@ Supports Extended Statistics, changes from driver to driver. -.. _nic_features_stats_per_queue: - -Stats per queue ---------------- - -Supports configuring per-queue stat counter mapping. - -* **[implements] eth_dev_ops**: ``queue_stats_mapping_set``. -* **[related] API**: ``rte_eth_dev_set_rx_queue_stats_mapping()``, - ``rte_eth_dev_set_tx_queue_stats_mapping()``. - - .. _nic_features_traffic_manager: -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:42.084473757 +0000 +++ 0122-doc-correct-definition-of-stats-per-queue-feature.patch 2024-11-27 17:17:38.361270078 +0000 @@ -1 +1 @@ -From 71eae7fe3eac90b70200460c714d1c13ee43dc25 Mon Sep 17 00:00:00 2001 +From db0eb7fb7bc68dd241029ae2cc46f487ef712d1a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 71eae7fe3eac90b70200460c714d1c13ee43dc25 ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index 0508f118fe..8bd448139e 100644 +index 841f3704b1..adbf118f2d 100644 @@ -31 +32 @@ -@@ -730,6 +730,4 @@ Support basic statistics such as: ipackets, opackets, ibytes, obytes, +@@ -689,6 +689,4 @@ Support basic statistics such as: ipackets, opackets, ibytes, obytes, @@ -38 +39 @@ -@@ -738,4 +736,24 @@ These apply to all drivers. +@@ -697,4 +695,24 @@ These apply to all drivers. @@ -63 +64 @@ -@@ -752,16 +770,4 @@ Supports Extended Statistics, changes from driver to driver. +@@ -711,16 +729,4 @@ Supports Extended Statistics, changes from driver to driver. @@ -78 +79 @@ - .. _nic_features_congestion_management: + .. _nic_features_traffic_manager: