From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 049F845DB9 for ; Wed, 27 Nov 2024 18:20:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2F9140663; Wed, 27 Nov 2024 18:20:13 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5449C4067C for ; Wed, 27 Nov 2024 18:20:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tfdtRLegZ+szBHr8Qr+NVN4LSMy9L0kzO+uwjc8yFBE=; b=i9B3+TidcAOGEBZ2hQaglSeNKJOeqbTenRz8QzwN4H31yRyZCqjongL8dSnQHOD7+6dl3d W3FgfkBojgrnpPq12YROzzknbFB6cpmf8ZlaU3ds7uye3BhDX1CTGebwQ/BfNsd9bAQBaz nyN6Ftb7FiLFwCMJk+rdFTfz9Q9LVpk= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-670-NBSRKkMCNYGgsl2gAszBIA-1; Wed, 27 Nov 2024 12:20:08 -0500 X-MC-Unique: NBSRKkMCNYGgsl2gAszBIA-1 X-Mimecast-MFC-AGG-ID: NBSRKkMCNYGgsl2gAszBIA Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CB5AE1956080; Wed, 27 Nov 2024 17:20:06 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6D5FD300019E; Wed, 27 Nov 2024 17:20:04 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Chengwen Feng , Chenbo Xia , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Konstantin Ananyev , Wathsala Vithanage , dpdk stable Subject: patch 'examples/vhost: fix free function mismatch' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:17:23 +0000 Message-ID: <20241127171916.690404-16-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AAmhYBNYNehGPZWEsRARsNlN3h3FcybCtRGW7C_o5pc_1732728006 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/1568469c2a6cc1f1693e832f539a1725f07d3e05 Thanks. Kevin --- >From 1568469c2a6cc1f1693e832f539a1725f07d3e05 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 8 Oct 2024 09:47:09 -0700 Subject: [PATCH] examples/vhost: fix free function mismatch MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit ae67f7d0256687fdfb24d27ee94b20d88c65108e ] The pointer bdev is allocated with rte_zmalloc() and then incorrectly freed with free() which will lead to pool corruption. Bugzilla ID: 1553 Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") Signed-off-by: Stephen Hemminger Acked-by: Chengwen Feng Reviewed-by: Chenbo Xia Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Wathsala Vithanage --- examples/vhost_blk/vhost_blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c index feadacc62e..3dd6053290 100644 --- a/examples/vhost_blk/vhost_blk.c +++ b/examples/vhost_blk/vhost_blk.c @@ -785,5 +785,5 @@ vhost_blk_bdev_construct(const char *bdev_name, if (!bdev->data) { fprintf(stderr, "No enough reserved huge memory for disk\n"); - free(bdev); + rte_free(bdev); return NULL; } -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:38.830147309 +0000 +++ 0016-examples-vhost-fix-free-function-mismatch.patch 2024-11-27 17:17:38.172269098 +0000 @@ -1 +1 @@ -From ae67f7d0256687fdfb24d27ee94b20d88c65108e Mon Sep 17 00:00:00 2001 +From 1568469c2a6cc1f1693e832f539a1725f07d3e05 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit ae67f7d0256687fdfb24d27ee94b20d88c65108e ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index 03f1ac9c3f..9c9e326949 100644 +index feadacc62e..3dd6053290 100644 @@ -30 +31 @@ -@@ -777,5 +777,5 @@ vhost_blk_bdev_construct(const char *bdev_name, +@@ -785,5 +785,5 @@ vhost_blk_bdev_construct(const char *bdev_name,