From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D4A345DB9 for ; Wed, 27 Nov 2024 18:20:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25CCD402DE; Wed, 27 Nov 2024 18:20:18 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id ECC67402E4 for ; Wed, 27 Nov 2024 18:20:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=18m93z15ELfnU1ZO6vQTF84loF9m+LE21mDdWC4l7Ec=; b=B5zcO4ccKGJaWd+kXN+yHCH/55VeE7k/GLmu+ZW3nAsGi5nLpNmnfTAgMHyICTOHf1M2fR 1SYMllH1wjk7wHDtCN4aKhgyq8k+jTfGjrBuAXV3Pf4WH1bUXe+Szkj4F7lng312xwriId RJpQrmE4GlkGDceEaqpCw5qCXwpZRiY= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-333-YQgCrV1OMNyit6NCPqGzoA-1; Wed, 27 Nov 2024 12:20:14 -0500 X-MC-Unique: YQgCrV1OMNyit6NCPqGzoA-1 X-Mimecast-MFC-AGG-ID: YQgCrV1OMNyit6NCPqGzoA Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5D6E71955F42; Wed, 27 Nov 2024 17:20:13 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D7C653003B76; Wed, 27 Nov 2024 17:20:11 +0000 (UTC) From: Kevin Traynor To: Vladimir Medvedkin Cc: David Marchand , dpdk stable Subject: patch 'fib6: add runtime checks in AVX512 lookup' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:17:26 +0000 Message-ID: <20241127171916.690404-19-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tfHTS8uh9D-9TrIHB1_oLfk3OEFZELHiWw9q-v-pOk8_1732728013 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/757dde39189e5f7b4aa7db06cdf6adc0794f9557 Thanks. Kevin --- >From 757dde39189e5f7b4aa7db06cdf6adc0794f9557 Mon Sep 17 00:00:00 2001 From: Vladimir Medvedkin Date: Tue, 8 Oct 2024 17:31:36 +0000 Subject: [PATCH] fib6: add runtime checks in AVX512 lookup [ upstream commit 45ddc5660f9830f3b7b39ddaf57af02e80d589a4 ] AVX512 lookup function requires CPU to support RTE_CPUFLAG_AVX512DQ and RTE_CPUFLAG_AVX512BW. Add runtime checks of these two flags when deciding if vector function can be used. Fixes: 1e5630e40d95 ("fib6: add AVX512 lookup") Signed-off-by: Vladimir Medvedkin Reviewed-by: David Marchand --- lib/fib/trie.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/fib/trie.c b/lib/fib/trie.c index b096743086..e7ea4f2be2 100644 --- a/lib/fib/trie.c +++ b/lib/fib/trie.c @@ -52,6 +52,8 @@ get_vector_fn(enum rte_fib_trie_nh_sz nh_sz) { #ifdef CC_TRIE_AVX512_SUPPORT - if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) <= 0) || - (rte_vect_get_max_simd_bitwidth() < RTE_VECT_SIMD_512)) + if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) <= 0 || + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512DQ) <= 0 || + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512BW) <= 0 || + rte_vect_get_max_simd_bitwidth() < RTE_VECT_SIMD_512) return NULL; switch (nh_sz) { -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:38.915344568 +0000 +++ 0019-fib6-add-runtime-checks-in-AVX512-lookup.patch 2024-11-27 17:17:38.174269109 +0000 @@ -1 +1 @@ -From 45ddc5660f9830f3b7b39ddaf57af02e80d589a4 Mon Sep 17 00:00:00 2001 +From 757dde39189e5f7b4aa7db06cdf6adc0794f9557 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 45ddc5660f9830f3b7b39ddaf57af02e80d589a4 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 09470e7287..7b33cdaa7b 100644 +index b096743086..e7ea4f2be2 100644 @@ -23 +24 @@ -@@ -47,6 +47,8 @@ get_vector_fn(enum rte_fib_trie_nh_sz nh_sz) +@@ -52,6 +52,8 @@ get_vector_fn(enum rte_fib_trie_nh_sz nh_sz)