From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B62745DB9 for ; Wed, 27 Nov 2024 18:19:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 16DB14064C; Wed, 27 Nov 2024 18:19:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 29EB6402E4 for ; Wed, 27 Nov 2024 18:19:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732727969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2DPOazIU4MRHdEfzv+Gd/NLGEDOFmFlEMBjhkTtevCY=; b=EohLUDq/x0Ub6f7yk6fchctlhm74eWxMcdq6QQrXGbvTsaZwXohbpsRwpsrFivelH3Kg36 f4CvcdMSTE1KpObRzZEdhsGWANWn7ojaaNu1lHK41QJfRa/haxbbN6UcLqYKuu/1x7MB6X bk6i1isdBQ23xxNZLywZ4wCYN/6QRUQ= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-pBGO8DFyN0-UXHqqc5_Gww-1; Wed, 27 Nov 2024 12:19:28 -0500 X-MC-Unique: pBGO8DFyN0-UXHqqc5_Gww-1 X-Mimecast-MFC-AGG-ID: pBGO8DFyN0-UXHqqc5_Gww Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4AA6E1955F3D; Wed, 27 Nov 2024 17:19:27 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 73BF2300019E; Wed, 27 Nov 2024 17:19:25 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: Radu Nicolau , Tyler Retzlaff , dpdk stable Subject: patch 'eal/x86: fix 32-bit write combining store' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:17:09 +0000 Message-ID: <20241127171916.690404-2-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: n6HIroc9z-VHVJKmEj_G3Va9oYpL7mppXrT88sN9vf8_1732727967 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/aa79c7b67c585df83bbe9bacce3882db3165894b Thanks. Kevin --- >From aa79c7b67c585df83bbe9bacce3882db3165894b Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 6 Sep 2024 14:27:57 +0100 Subject: [PATCH] eal/x86: fix 32-bit write combining store [ upstream commit 41b09d64e35b877e8f29c4e5a8cf944e303695dd ] The "movdiri" instruction is given as a series of bytes in rte_io.h so that it works on compilers/assemblers which are unaware of the instruction. The REX prefix (0x40) on this instruction is invalid for 32-bit code, causing issues. Thankfully, the prefix is unnecessary in 64-bit code, since the data size used is 32-bits. Fixes: 8a00dfc738fe ("eal: add write combining store") Signed-off-by: Bruce Richardson Acked-by: Radu Nicolau Acked-by: Tyler Retzlaff --- lib/eal/x86/include/rte_io.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/x86/include/rte_io.h b/lib/eal/x86/include/rte_io.h index 730f958758..9947e5d285 100644 --- a/lib/eal/x86/include/rte_io.h +++ b/lib/eal/x86/include/rte_io.h @@ -24,5 +24,5 @@ __rte_x86_movdiri(uint32_t value, volatile void *addr) asm volatile( /* MOVDIRI */ - ".byte 0x40, 0x0f, 0x38, 0xf9, 0x02" + ".byte 0x0f, 0x38, 0xf9, 0x02" : : "a" (value), "d" (addr)); -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:38.413073537 +0000 +++ 0002-eal-x86-fix-32-bit-write-combining-store.patch 2024-11-27 17:17:38.147268969 +0000 @@ -1 +1 @@ -From 41b09d64e35b877e8f29c4e5a8cf944e303695dd Mon Sep 17 00:00:00 2001 +From aa79c7b67c585df83bbe9bacce3882db3165894b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 41b09d64e35b877e8f29c4e5a8cf944e303695dd ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 0e1fefdee1..5366e09c47 100644 +index 730f958758..9947e5d285 100644 @@ -28 +29 @@ -@@ -25,5 +25,5 @@ __rte_x86_movdiri(uint32_t value, volatile void *addr) +@@ -24,5 +24,5 @@ __rte_x86_movdiri(uint32_t value, volatile void *addr)