From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F71145DB9 for ; Wed, 27 Nov 2024 18:20:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 992024067C; Wed, 27 Nov 2024 18:20:30 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0682D402E1 for ; Wed, 27 Nov 2024 18:20:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4hCN3WHLJDf3/i7iy46KjNw+XF6L6kT2dJ0s/L89UVs=; b=K3esUwHZ1BZb19hY/28U7ysEvs6L40mmdv9y4EZVUuHxYoRMQ1HvaDVGSYdEKrCUqMmlQc Q5LeK+qgpbDNfMaIOIeOVmLMQBFgi6CjxJDjQPyCz5qyWYFRXPnm9yrZCtnhpFFPcTjUMN 6sD065mruJIrsXKXIogPNboFBRj5el8= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-400-4khBRQkRMFqQZ6nXueiO9w-1; Wed, 27 Nov 2024 12:20:25 -0500 X-MC-Unique: 4khBRQkRMFqQZ6nXueiO9w-1 X-Mimecast-MFC-AGG-ID: 4khBRQkRMFqQZ6nXueiO9w Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 416751953940; Wed, 27 Nov 2024 17:20:24 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F0478300019E; Wed, 27 Nov 2024 17:20:22 +0000 (UTC) From: Kevin Traynor To: Kommula Shiva Shankar Cc: Maxime Coquelin , dpdk stable Subject: patch 'net/virtio-user: reset used index counter' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:17:32 +0000 Message-ID: <20241127171916.690404-25-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: nccs6d2ggFvaWcFvq577p0896v8WL-6Uj5J3iWRAV3U_1732728024 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4f7d560e1ec9a8bd66a944c53e70cad6a181fe44 Thanks. Kevin --- >From 4f7d560e1ec9a8bd66a944c53e70cad6a181fe44 Mon Sep 17 00:00:00 2001 From: Kommula Shiva Shankar Date: Mon, 5 Aug 2024 10:08:41 +0000 Subject: [PATCH] net/virtio-user: reset used index counter [ upstream commit ff11fc60c5d8d9ae5a0f0114db4c3bc834090548 ] When the virtio device is reinitialized during ethdev reconfiguration, all the virtio rings are recreated and repopulated on the device. Accordingly, reset the used index counter value back to zero. Fixes: 48a4464029a7 ("net/virtio-user: support control VQ for packed") Signed-off-by: Kommula Shiva Shankar Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_user_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index 9ba4ea3b33..07e4feca0c 100644 --- a/drivers/net/virtio/virtio_user_ethdev.c +++ b/drivers/net/virtio/virtio_user_ethdev.c @@ -199,4 +199,5 @@ virtio_user_setup_queue_packed(struct virtqueue *vq, dev->packed_queues[queue_idx].avail_wrap_counter = true; dev->packed_queues[queue_idx].used_wrap_counter = true; + dev->packed_queues[queue_idx].used_idx = 0; for (i = 0; i < vring->num; i++) -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:39.094319265 +0000 +++ 0025-net-virtio-user-reset-used-index-counter.patch 2024-11-27 17:17:38.180269140 +0000 @@ -1 +1 @@ -From ff11fc60c5d8d9ae5a0f0114db4c3bc834090548 Mon Sep 17 00:00:00 2001 +From 4f7d560e1ec9a8bd66a944c53e70cad6a181fe44 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ff11fc60c5d8d9ae5a0f0114db4c3bc834090548 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index bf29f0dacd..747dddeb2e 100644 +index 9ba4ea3b33..07e4feca0c 100644 @@ -23 +24 @@ -@@ -205,4 +205,5 @@ virtio_user_setup_queue_packed(struct virtqueue *vq, +@@ -199,4 +199,5 @@ virtio_user_setup_queue_packed(struct virtqueue *vq,