From: Kevin Traynor <ktraynor@redhat.com>
To: Kaiwen Deng <kaiwenx.deng@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: patch 'net/iavf: fix crash when link is unstable' has been queued to stable release 21.11.9
Date: Wed, 27 Nov 2024 17:17:35 +0000 [thread overview]
Message-ID: <20241127171916.690404-28-ktraynor@redhat.com> (raw)
In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com>
Hi,
FYI, your patch has been queued to stable release 21.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/02/24. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/8dff953d81fc875730c7450606a012a0e97b63da
Thanks.
Kevin
---
From 8dff953d81fc875730c7450606a012a0e97b63da Mon Sep 17 00:00:00 2001
From: Kaiwen Deng <kaiwenx.deng@intel.com>
Date: Tue, 6 Aug 2024 08:35:27 +0800
Subject: [PATCH] net/iavf: fix crash when link is unstable
[ upstream commit 57ed9ca61f44ffc3801f55c749347bd717834008 ]
Physical link instability may cause a core dump because unstable
physical links can result in a large number of link change events. Some
of these events may be captured by vf before vf resources are allocated,
and that will result in a core dump.
This commit will check if vf_res is invalid before dereferencing it.
Fixes: 5e03e316c753 ("net/iavf: handle virtchnl event message without interrupt")
Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/net/iavf/iavf_vchnl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 930a67f517..d685358ed3 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -105,6 +105,6 @@ iavf_read_msg_from_pf(struct iavf_adapter *adapter, uint16_t buf_len,
vf->link_up =
vpe->event_data.link_event.link_status;
- if (vf->vf_res->vf_cap_flags &
- VIRTCHNL_VF_CAP_ADV_LINK_SPEED) {
+ if (vf->vf_res != NULL &&
+ vf->vf_res->vf_cap_flags & VIRTCHNL_VF_CAP_ADV_LINK_SPEED) {
vf->link_speed =
vpe->event_data.link_event_adv.link_speed;
--
2.47.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2024-11-27 17:17:39.180575479 +0000
+++ 0028-net-iavf-fix-crash-when-link-is-unstable.patch 2024-11-27 17:17:38.183269155 +0000
@@ -1 +1 @@
-From 57ed9ca61f44ffc3801f55c749347bd717834008 Mon Sep 17 00:00:00 2001
+From 8dff953d81fc875730c7450606a012a0e97b63da Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 57ed9ca61f44ffc3801f55c749347bd717834008 ]
+
@@ -14 +15,0 @@
-Cc: stable@dpdk.org
@@ -23 +24 @@
-index 6d5969f084..69420bc9b6 100644
+index 930a67f517..d685358ed3 100644
@@ -26 +27 @@
-@@ -256,6 +256,6 @@ iavf_read_msg_from_pf(struct iavf_adapter *adapter, uint16_t buf_len,
+@@ -105,6 +105,6 @@ iavf_read_msg_from_pf(struct iavf_adapter *adapter, uint16_t buf_len,
next prev parent reply other threads:[~2024-11-27 17:20 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 17:17 patch 'net/ionic: fix build with Fedora Rawhide' " Kevin Traynor
2024-11-27 17:17 ` patch 'eal/x86: fix 32-bit write combining store' " Kevin Traynor
2024-11-27 17:17 ` patch 'examples/eventdev: fix queue crash with generic pipeline' " Kevin Traynor
2024-11-27 17:17 ` patch 'crypto/dpaa2_sec: fix memory leak' " Kevin Traynor
2024-11-27 17:17 ` patch 'common/dpaax/caamflib: fix PDCP SNOW-ZUC watchdog' " Kevin Traynor
2024-11-27 17:17 ` patch 'dev: fix callback lookup when unregistering device' " Kevin Traynor
2024-11-27 17:17 ` patch 'bpf: fix free function mismatch if convert fails' " Kevin Traynor
2024-11-27 17:17 ` patch 'baseband/la12xx: fix use after free in modem config' " Kevin Traynor
2024-11-27 17:17 ` patch 'crypto/bcmfs: fix free function mismatch' " Kevin Traynor
2024-11-27 17:17 ` patch 'dma/idxd: fix free function mismatch in device probe' " Kevin Traynor
2024-11-27 17:17 ` patch 'event/cnxk: fix free function mismatch in port config' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/e1000: fix use after free in filter flush' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/sfc: fix use after free in debug logs' " Kevin Traynor
2024-11-27 17:17 ` patch 'raw/ifpga/base: fix use after free' " Kevin Traynor
2024-11-27 17:17 ` patch 'raw/ifpga: fix free function mismatch in interrupt config' " Kevin Traynor
2024-11-27 17:17 ` patch 'examples/vhost: fix free function mismatch' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/nfb: fix use after free' " Kevin Traynor
2024-11-27 17:17 ` patch 'power: enable CPPC' " Kevin Traynor
2024-11-27 17:17 ` patch 'fib6: add runtime checks in AVX512 lookup' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/cnxk: fix Rx timestamp handling for VF' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/cnxk: fix Rx offloads to handle timestamp' " Kevin Traynor
2024-11-27 17:17 ` patch 'common/cnxk: fix base log level' " Kevin Traynor
2024-11-27 17:17 ` patch 'vhost: fix offset while mapping log base address' " Kevin Traynor
2024-11-27 17:17 ` patch 'vdpa: update used flags in used ring relay' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/virtio-user: reset used index counter' " Kevin Traynor
2024-11-27 17:17 ` patch 'fib: fix AVX512 lookup' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/e1000: fix link status crash in secondary process' " Kevin Traynor
2024-11-27 17:17 ` Kevin Traynor [this message]
2024-11-27 17:17 ` patch 'net/ice/base: fix link speed for 200G' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/ice/base: fix iteration of TLVs in Preserved Fields Area' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/ixgbe/base: fix unchecked return value' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/i40e/base: fix setting flags in init function' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/i40e/base: fix misleading debug logs and comments' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/i40e/base: fix blinking X722 with X557 PHY' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/i40e/base: fix DDP loading with reserved track ID' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/i40e/base: fix repeated register dumps' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/i40e/base: fix unchecked return value' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/i40e/base: fix loop bounds' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/i40e: fix AVX-512 pointer copy on 32-bit' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/ice: " Kevin Traynor
2024-11-27 17:17 ` patch 'net/iavf: " Kevin Traynor
2024-11-27 17:17 ` patch 'net/tap: avoid memcpy with null argument' " Kevin Traynor
2024-11-27 17:17 ` patch 'app/testpmd: remove unnecessary cast' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/pcap: set live interface as non-blocking' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/ena: revert redefining memcpy' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/hns3: remove some basic address dump' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/hns3: fix dump counter of registers' " Kevin Traynor
2024-11-27 17:17 ` patch 'ethdev: fix overflow in descriptor count' " Kevin Traynor
2024-11-27 17:17 ` patch 'bus/dpaa: fix PFDRs leaks due to FQRNIs' " Kevin Traynor
2024-11-27 17:17 ` patch 'net/dpaa: fix typecasting channel ID' " Kevin Traynor
2024-11-27 17:17 ` patch 'bus/dpaa: fix VSP for 1G fm1-mac9 and 10' " Kevin Traynor
2024-11-27 17:17 ` patch 'bus/dpaa: fix the fman details status' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/dpaa: fix reallocate mbuf handling' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/memif: fix buffer overflow in zero copy Rx' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/tap: restrict maximum number of MP FDs' " Kevin Traynor
2024-11-27 17:18 ` patch 'ethdev: verify queue ID in Tx done cleanup' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/hns3: verify reset type from firmware' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/pcap: fix blocking Rx' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/ice/base: add bounds check' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/ice/base: fix VLAN replay after reset' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/iavf: preserve MAC address with i40e PF Linux driver' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/mlx5: workaround list management of Rx queue control' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/mlx5: fix number of supported flex parsers' " Kevin Traynor
2024-11-27 17:18 ` patch 'app/testpmd: remove flex item init command leftover' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/mlx5: fix next protocol validation after flex item' " Kevin Traynor
2024-11-27 17:18 ` patch 'build: remove version check on compiler links function' " Kevin Traynor
2024-11-27 17:18 ` patch 'hash: fix thash LFSR initialization' " Kevin Traynor
2024-11-27 17:18 ` patch 'dmadev: fix potential null pointer access' " Kevin Traynor
2024-11-27 17:18 ` patch 'power: fix mapped lcore ID' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/netvsc: fix using Tx queue higher than Rx queues' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/hns3: restrict tunnel flow rule to one header' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/ice: detect stopping a flow director queue twice' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/ixgbe: fix link status delay on FreeBSD' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/mvneta: fix possible out-of-bounds write' " Kevin Traynor
2024-11-27 17:18 ` patch 'crypto/openssl: fix 3DES-CTR with big endian CPUs' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/mlx5: fix memory leak in metering' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/mlx5: fix reported Rx/Tx descriptor limits' " Kevin Traynor
2024-11-27 17:18 ` patch 'app/dumpcap: remove unused struct array' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/nfp: fix link change return value' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/mlx5: fix non full word sample fields in flex item' " Kevin Traynor
2024-11-27 17:18 ` patch 'bus/fslmc: fix Coverity warnings in QBMAN' " Kevin Traynor
2024-11-27 17:18 ` patch 'test/bonding: remove redundant info query' " Kevin Traynor
2024-11-27 17:18 ` patch 'examples/ntb: check info query return' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/netvsc: force Tx VLAN offload on 801.2Q packet' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/vmxnet3: fix crash after configuration failure' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/txgbe: fix SWFW mbox' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/txgbe: fix VF-PF mbox interrupt' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/txgbe: remove outer UDP checksum capability' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/txgbe: fix driver load bit to inform firmware' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/ngbe: " Kevin Traynor
2024-11-27 17:18 ` patch 'net/ngbe: reconfigure more MAC Rx registers' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/ngbe: fix interrupt lost in legacy or MSI mode' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/ngbe: restrict configuration of VLAN strip offload' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/hns3: fix error code for repeatedly create counter' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/hns3: fix fully use hardware flow director table' " Kevin Traynor
2024-11-27 17:18 ` patch 'event/octeontx: fix possible integer overflow' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/bnxt/tf_core: fix Thor TF EM key size check' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/bnxt: fix reading SFF-8436 SFP EEPROMs' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/bnxt: fix TCP and UDP checksum flags' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/bnxt: fix bad action offset in Tx BD' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/bnx2x: remove dead conditional' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/bnx2x: fix always true expression' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/bnx2x: fix possible infinite loop at startup' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/bnx2x: fix duplicate branch' " Kevin Traynor
2024-11-27 17:18 ` patch 'common/cnxk: fix build on Ubuntu 24.04' " Kevin Traynor
2024-11-27 17:18 ` patch 'examples/l2fwd-event: fix spinlock handling' " Kevin Traynor
2024-11-27 17:18 ` patch 'eventdev: fix possible array underflow/overflow' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/mlx5: fix shared queue port number in vector Rx' " Kevin Traynor
2024-11-27 17:18 ` patch 'common/mlx5: fix misalignment' " Kevin Traynor
2024-11-27 17:18 ` patch 'bus/dpaa: fix lock condition during error handling' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/iavf: add segment-length check to Tx prep' " Kevin Traynor
2024-11-27 17:18 ` patch 'net/i40e: check register read for outer VLAN' " Kevin Traynor
2024-11-27 17:19 ` patch 'app/procinfo: fix leak on exit' " Kevin Traynor
2024-11-27 17:19 ` patch 'member: fix choice of bucket for displacement' " Kevin Traynor
2024-11-27 17:19 ` patch 'app/testpmd: fix aged flow destroy' " Kevin Traynor
2024-11-27 17:19 ` patch 'test/bonding: fix loop on members' " Kevin Traynor
2024-11-27 17:19 ` patch 'test/bonding: fix MAC address comparison' " Kevin Traynor
2024-11-27 17:19 ` patch 'test/event: avoid duplicate initialization' " Kevin Traynor
2024-11-27 17:19 ` patch 'test/eal: fix loop coverage for alignment macros' " Kevin Traynor
2024-11-27 17:19 ` patch 'test/eal: fix lcore check' " Kevin Traynor
2024-11-27 17:19 ` patch 'app/testpmd: remove redundant policy action condition' " Kevin Traynor
2024-11-27 17:19 ` patch 'doc: correct definition of stats per queue feature' " Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241127171916.690404-28-ktraynor@redhat.com \
--to=ktraynor@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=kaiwenx.deng@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).