From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F419345DB9 for ; Wed, 27 Nov 2024 18:20:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEE3A402E1; Wed, 27 Nov 2024 18:20:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A6F92402E1 for ; Wed, 27 Nov 2024 18:20:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k/gxON/jmKDlxZPQW56qWFtipZMN1yD8/rzQX2R/0Kk=; b=NWv4GqzQHVLVcGvSaKbK4B1jMnpzpa3UtiubQzHJP26P++PbbXeAtVbUGiO/A9FJY8C8vG nbGsw0dJxMxCxTc5We4jdYi570Of+paUKwuM7YBAHmtVgvYMTlf67TtnZUzHxGl2yfgKPE RLQ8/FVidIbA2fPgdVajKLRf1cI1oRI= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-218-gBfSz3jzOhSZmYrWaldfPA-1; Wed, 27 Nov 2024 12:20:30 -0500 X-MC-Unique: gBfSz3jzOhSZmYrWaldfPA-1 X-Mimecast-MFC-AGG-ID: gBfSz3jzOhSZmYrWaldfPA Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DAF3A1955F42; Wed, 27 Nov 2024 17:20:29 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9703930001A2; Wed, 27 Nov 2024 17:20:28 +0000 (UTC) From: Kevin Traynor To: Kaiwen Deng Cc: Bruce Richardson , dpdk stable Subject: patch 'net/iavf: fix crash when link is unstable' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:17:35 +0000 Message-ID: <20241127171916.690404-28-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JWP2KTMaHjuFHqbujCs8Yp0FbUkLpwPII3zHbJ8_eiM_1732728030 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/8dff953d81fc875730c7450606a012a0e97b63da Thanks. Kevin --- >From 8dff953d81fc875730c7450606a012a0e97b63da Mon Sep 17 00:00:00 2001 From: Kaiwen Deng Date: Tue, 6 Aug 2024 08:35:27 +0800 Subject: [PATCH] net/iavf: fix crash when link is unstable [ upstream commit 57ed9ca61f44ffc3801f55c749347bd717834008 ] Physical link instability may cause a core dump because unstable physical links can result in a large number of link change events. Some of these events may be captured by vf before vf resources are allocated, and that will result in a core dump. This commit will check if vf_res is invalid before dereferencing it. Fixes: 5e03e316c753 ("net/iavf: handle virtchnl event message without interrupt") Signed-off-by: Kaiwen Deng Acked-by: Bruce Richardson --- drivers/net/iavf/iavf_vchnl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index 930a67f517..d685358ed3 100644 --- a/drivers/net/iavf/iavf_vchnl.c +++ b/drivers/net/iavf/iavf_vchnl.c @@ -105,6 +105,6 @@ iavf_read_msg_from_pf(struct iavf_adapter *adapter, uint16_t buf_len, vf->link_up = vpe->event_data.link_event.link_status; - if (vf->vf_res->vf_cap_flags & - VIRTCHNL_VF_CAP_ADV_LINK_SPEED) { + if (vf->vf_res != NULL && + vf->vf_res->vf_cap_flags & VIRTCHNL_VF_CAP_ADV_LINK_SPEED) { vf->link_speed = vpe->event_data.link_event_adv.link_speed; -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:39.180575479 +0000 +++ 0028-net-iavf-fix-crash-when-link-is-unstable.patch 2024-11-27 17:17:38.183269155 +0000 @@ -1 +1 @@ -From 57ed9ca61f44ffc3801f55c749347bd717834008 Mon Sep 17 00:00:00 2001 +From 8dff953d81fc875730c7450606a012a0e97b63da Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 57ed9ca61f44ffc3801f55c749347bd717834008 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 6d5969f084..69420bc9b6 100644 +index 930a67f517..d685358ed3 100644 @@ -26 +27 @@ -@@ -256,6 +256,6 @@ iavf_read_msg_from_pf(struct iavf_adapter *adapter, uint16_t buf_len, +@@ -105,6 +105,6 @@ iavf_read_msg_from_pf(struct iavf_adapter *adapter, uint16_t buf_len,