From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82FA445DB9 for ; Wed, 27 Nov 2024 18:20:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F8F9402DE; Wed, 27 Nov 2024 18:20:54 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C6D3C402DE for ; Wed, 27 Nov 2024 18:20:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QkLoPysymr2q+TLQDQo58QDh5pLPOCHfLSHfYunDLt8=; b=g9XFmlxdXex3iQth4CR/hYhWevAHpw9OsEUHFVc4VgL9Ic4BFuhF+w3P3n4fAdynNT1q4k cOfzpUgs+01kz1fFc5KQaU+EeeA1Bq7xaGnhEK5Y8K+XDmu+foSsB5cG5BtucO/oqdDne4 ymFeVSQF2ybzDXgXr7iiNRtQamx6qks= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-eoJrKVzoNHSSpPSCFtJ18Q-1; Wed, 27 Nov 2024 12:20:51 -0500 X-MC-Unique: eoJrKVzoNHSSpPSCFtJ18Q-1 X-Mimecast-MFC-AGG-ID: eoJrKVzoNHSSpPSCFtJ18Q Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 289F019560AE; Wed, 27 Nov 2024 17:20:50 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A7322300019E; Wed, 27 Nov 2024 17:20:48 +0000 (UTC) From: Kevin Traynor To: Barbara Skobiej Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/i40e/base: fix unchecked return value' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:17:44 +0000 Message-ID: <20241127171916.690404-37-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FqUDTlQY_L-EdCvWMMl8gb7Tjv-ILlE5lIgMSJhEN68_1732728050 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/d290ddac724d9e275eedc555b93317468f23d65e Thanks. Kevin --- >From d290ddac724d9e275eedc555b93317468f23d65e Mon Sep 17 00:00:00 2001 From: Barbara Skobiej Date: Mon, 2 Sep 2024 10:54:34 +0100 Subject: [PATCH] net/i40e/base: fix unchecked return value [ upstream commit 7fb34b9141aab299c2b84656ec5b12bf41f1c21d ] Static analysis tools have reported an unchecked return value warning. Address the warning by checking return value. Fixes: 2450cc2dc871 ("i40e/base: find partition id in NPAR mode and disable FCoE") Signed-off-by: Barbara Skobiej Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/i40e/base/i40e_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c index 3acb48e20b..e5651ad80b 100644 --- a/drivers/net/i40e/base/i40e_common.c +++ b/drivers/net/i40e/base/i40e_common.c @@ -4227,6 +4227,6 @@ STATIC void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff, * of the port relative offset */ - i40e_aq_debug_read_register(hw, port_cfg_reg, &port_cfg, NULL); - if (!(port_cfg & I40E_PRTGEN_CNF_PORT_DIS_MASK)) + status = i40e_aq_debug_read_register(hw, port_cfg_reg, &port_cfg, NULL); + if ((status == I40E_SUCCESS) && (!(port_cfg & I40E_PRTGEN_CNF_PORT_DIS_MASK))) hw->num_ports++; } -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:39.457989869 +0000 +++ 0037-net-i40e-base-fix-unchecked-return-value.patch 2024-11-27 17:17:38.204269264 +0000 @@ -1 +1 @@ -From 7fb34b9141aab299c2b84656ec5b12bf41f1c21d Mon Sep 17 00:00:00 2001 +From d290ddac724d9e275eedc555b93317468f23d65e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7fb34b9141aab299c2b84656ec5b12bf41f1c21d ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 416f31dcc3..07e18deaea 100644 +index 3acb48e20b..e5651ad80b 100644 @@ -23 +24 @@ -@@ -4216,6 +4216,6 @@ STATIC void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff, +@@ -4227,6 +4227,6 @@ STATIC void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff,