From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30DC945DB9 for ; Wed, 27 Nov 2024 18:21:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CE4B4060C; Wed, 27 Nov 2024 18:21:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 30338402E1 for ; Wed, 27 Nov 2024 18:20:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9xn2fkVFpyOiJiDomOeo+0znt6vTXo3ueltPcsraj1I=; b=FBN+RIvgeO/9M/8T9DWpE4P4BY7lWjCCNPKFR3I7kbpznzwFkV9rIDKXs02mRl57L5iYg1 /aiVMCk2mLbN26v/qxKIt33pSu3NyT/bEtltWV/lSpyN1Q9KQ/zNBlbeoepPvNdf0KdEJL iCKCPvX7hnRxbj28IrZ0bJ5DDGBMrsQ= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-34-VvEoF8CNP-eqPqJJZy1rzQ-1; Wed, 27 Nov 2024 12:20:55 -0500 X-MC-Unique: VvEoF8CNP-eqPqJJZy1rzQ-1 X-Mimecast-MFC-AGG-ID: VvEoF8CNP-eqPqJJZy1rzQ Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9FC40195608B; Wed, 27 Nov 2024 17:20:54 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 17675300019E; Wed, 27 Nov 2024 17:20:52 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: Ian Stokes , dpdk stable Subject: patch 'net/i40e: fix AVX-512 pointer copy on 32-bit' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:17:46 +0000 Message-ID: <20241127171916.690404-39-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mGnR3ONP_3qjVovjOnbiNIqQPmJAzgYrFv-w5FAxV5M_1732728054 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/d46c34fda73d6134acbbe66c38ead2cd5ff2f4b6 Thanks. Kevin --- >From d46c34fda73d6134acbbe66c38ead2cd5ff2f4b6 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 6 Sep 2024 15:11:24 +0100 Subject: [PATCH] net/i40e: fix AVX-512 pointer copy on 32-bit [ upstream commit 2d040df2437a025ef6d2ecf72de96d5c9fe97439 ] The size of a pointer on 32-bit is only 4 rather than 8 bytes, so copying 32 pointers only requires half the number of AVX-512 load store operations. Fixes: 5171b4ee6b6b ("net/i40e: optimize Tx by using AVX512") Signed-off-by: Bruce Richardson Acked-by: Ian Stokes --- drivers/net/i40e/i40e_rxtx_vec_avx512.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/i40e/i40e_rxtx_vec_avx512.c b/drivers/net/i40e/i40e_rxtx_vec_avx512.c index 2ad9a920a1..93ad8965cb 100644 --- a/drivers/net/i40e/i40e_rxtx_vec_avx512.c +++ b/drivers/net/i40e/i40e_rxtx_vec_avx512.c @@ -923,4 +923,5 @@ i40e_tx_free_bufs_avx512(struct i40e_tx_queue *txq) /* n is multiple of 32 */ while (copied < n) { +#ifdef RTE_ARCH_64 const __m512i a = _mm512_load_si512(&txep[copied]); const __m512i b = _mm512_load_si512(&txep[copied + 8]); @@ -932,4 +933,10 @@ i40e_tx_free_bufs_avx512(struct i40e_tx_queue *txq) _mm512_storeu_si512(&cache_objs[copied + 16], c); _mm512_storeu_si512(&cache_objs[copied + 24], d); +#else + const __m512i a = _mm512_load_si512(&txep[copied]); + const __m512i b = _mm512_load_si512(&txep[copied + 16]); + _mm512_storeu_si512(&cache_objs[copied], a); + _mm512_storeu_si512(&cache_objs[copied + 16], b); +#endif copied += 32; } -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:39.519392215 +0000 +++ 0039-net-i40e-fix-AVX-512-pointer-copy-on-32-bit.patch 2024-11-27 17:17:38.205269269 +0000 @@ -1 +1 @@ -From 2d040df2437a025ef6d2ecf72de96d5c9fe97439 Mon Sep 17 00:00:00 2001 +From d46c34fda73d6134acbbe66c38ead2cd5ff2f4b6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2d040df2437a025ef6d2ecf72de96d5c9fe97439 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 0238b03f8a..3b2750221b 100644 +index 2ad9a920a1..93ad8965cb 100644 @@ -23 +24 @@ -@@ -800,4 +800,5 @@ i40e_tx_free_bufs_avx512(struct i40e_tx_queue *txq) +@@ -923,4 +923,5 @@ i40e_tx_free_bufs_avx512(struct i40e_tx_queue *txq) @@ -29 +30 @@ -@@ -809,4 +810,10 @@ i40e_tx_free_bufs_avx512(struct i40e_tx_queue *txq) +@@ -932,4 +933,10 @@ i40e_tx_free_bufs_avx512(struct i40e_tx_queue *txq)