From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BFC045DB9 for ; Wed, 27 Nov 2024 18:21:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A3784066E; Wed, 27 Nov 2024 18:21:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 700FF402E4 for ; Wed, 27 Nov 2024 18:20:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jQW7W+aOGaTLZ62eN90/HTQdqY59I/rhObIwU4Jb0oc=; b=L6dH7pI5yY7FEnva8DUrJ1OaesCKT4FEbnSRBWs5K5hP374Rqalwqhh5MvHCKLoUJY7zeX sAsoEnVBDfNHnHvmBJlcFvF3iRygRKFsR++3u29Jq3W82cw4jrreieQ5iKOmFRimODMUDg xzZa0VP0rntDEKiffCnaOFdkbHqeQw0= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-QOTkFiaEPoyppO1OepVwjg-1; Wed, 27 Nov 2024 12:20:57 -0500 X-MC-Unique: QOTkFiaEPoyppO1OepVwjg-1 X-Mimecast-MFC-AGG-ID: QOTkFiaEPoyppO1OepVwjg Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AA6F2195608C; Wed, 27 Nov 2024 17:20:56 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 28E9C300019E; Wed, 27 Nov 2024 17:20:54 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: Ian Stokes , dpdk stable Subject: patch 'net/ice: fix AVX-512 pointer copy on 32-bit' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:17:47 +0000 Message-ID: <20241127171916.690404-40-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: u9isnk-10dTZBguxbo3mQuyPZSMzSITSOw8uSB9LghI_1732728056 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/8ff01ed38a37c7e2f981065e8ab021f6f8503f85 Thanks. Kevin --- >From 8ff01ed38a37c7e2f981065e8ab021f6f8503f85 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 6 Sep 2024 15:11:25 +0100 Subject: [PATCH] net/ice: fix AVX-512 pointer copy on 32-bit [ upstream commit da97aeafca4cdd40892ffb7e628bb15dcf9c0f25 ] The size of a pointer on 32-bit is only 4 rather than 8 bytes, so copying 32 pointers only requires half the number of AVX-512 load store operations. Fixes: a4e480de268e ("net/ice: optimize Tx by using AVX512") Signed-off-by: Bruce Richardson Acked-by: Ian Stokes --- drivers/net/ice/ice_rxtx_vec_avx512.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ice/ice_rxtx_vec_avx512.c b/drivers/net/ice/ice_rxtx_vec_avx512.c index 5bfd5152df..5f91ee4839 100644 --- a/drivers/net/ice/ice_rxtx_vec_avx512.c +++ b/drivers/net/ice/ice_rxtx_vec_avx512.c @@ -1021,4 +1021,5 @@ ice_tx_free_bufs_avx512(struct ice_tx_queue *txq) /* n is multiple of 32 */ while (copied < n) { +#ifdef RTE_ARCH_64 const __m512i a = _mm512_loadu_si512(&txep[copied]); const __m512i b = _mm512_loadu_si512(&txep[copied + 8]); @@ -1030,4 +1031,10 @@ ice_tx_free_bufs_avx512(struct ice_tx_queue *txq) _mm512_storeu_si512(&cache_objs[copied + 16], c); _mm512_storeu_si512(&cache_objs[copied + 24], d); +#else + const __m512i a = _mm512_loadu_si512(&txep[copied]); + const __m512i b = _mm512_loadu_si512(&txep[copied + 16]); + _mm512_storeu_si512(&cache_objs[copied], a); + _mm512_storeu_si512(&cache_objs[copied + 16], b); +#endif copied += 32; } -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:39.548372597 +0000 +++ 0040-net-ice-fix-AVX-512-pointer-copy-on-32-bit.patch 2024-11-27 17:17:38.206269274 +0000 @@ -1 +1 @@ -From da97aeafca4cdd40892ffb7e628bb15dcf9c0f25 Mon Sep 17 00:00:00 2001 +From 8ff01ed38a37c7e2f981065e8ab021f6f8503f85 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit da97aeafca4cdd40892ffb7e628bb15dcf9c0f25 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 04148e8ea2..add095ef06 100644 +index 5bfd5152df..5f91ee4839 100644 @@ -23 +24 @@ -@@ -908,4 +908,5 @@ ice_tx_free_bufs_avx512(struct ice_tx_queue *txq) +@@ -1021,4 +1021,5 @@ ice_tx_free_bufs_avx512(struct ice_tx_queue *txq) @@ -29 +30 @@ -@@ -917,4 +918,10 @@ ice_tx_free_bufs_avx512(struct ice_tx_queue *txq) +@@ -1030,4 +1031,10 @@ ice_tx_free_bufs_avx512(struct ice_tx_queue *txq)