From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8167C45DB9 for ; Wed, 27 Nov 2024 18:21:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B870402DE; Wed, 27 Nov 2024 18:21:03 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DB29340695 for ; Wed, 27 Nov 2024 18:21:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kto5I2LEX3OhZL7obcWXcq467PLsIoWJs7/omxMcJU8=; b=E16nq2AxHfUYGccYPv7QifviT9AQ59cRrZ5oOAezjUUk4bTnAvBkHAepmWqOccCd9ijPSy HCj63ak9Vw2tAfwV8z0L76CVm4n9rj+YRZxAi2QNoINqTkEx4M0zo1+V9IVyCyVwYyaJCt E6zBW2hHZNARvoJ5qzsP4EqE3pAgUtE= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-62-VVwKEpklP3OCtQnDECHe4A-1; Wed, 27 Nov 2024 12:21:00 -0500 X-MC-Unique: VVwKEpklP3OCtQnDECHe4A-1 X-Mimecast-MFC-AGG-ID: VVwKEpklP3OCtQnDECHe4A Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C305E19560AF; Wed, 27 Nov 2024 17:20:58 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4611030001A2; Wed, 27 Nov 2024 17:20:56 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: Ian Stokes , dpdk stable Subject: patch 'net/iavf: fix AVX-512 pointer copy on 32-bit' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:17:48 +0000 Message-ID: <20241127171916.690404-41-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Pkcu7RZDVHTgMSj7lyhkf10fPmkAgsOl6eVE8W9kaZc_1732728058 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4d613e1278426faa2bac791b0ef756daf37f231d Thanks. Kevin --- >From 4d613e1278426faa2bac791b0ef756daf37f231d Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 6 Sep 2024 15:11:26 +0100 Subject: [PATCH] net/iavf: fix AVX-512 pointer copy on 32-bit [ upstream commit 77608b24bdd840d323ebd9cb6ffffaf5c760983e ] The size of a pointer on 32-bit is only 4 rather than 8 bytes, so copying 32 pointers only requires half the number of AVX-512 load store operations. Fixes: 9ab9514c150e ("net/iavf: enable AVX512 for Tx") Signed-off-by: Bruce Richardson Acked-by: Ian Stokes --- drivers/net/iavf/iavf_rxtx_vec_avx512.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx512.c b/drivers/net/iavf/iavf_rxtx_vec_avx512.c index 9876c715e5..874ae55676 100644 --- a/drivers/net/iavf/iavf_rxtx_vec_avx512.c +++ b/drivers/net/iavf/iavf_rxtx_vec_avx512.c @@ -1819,4 +1819,5 @@ iavf_tx_free_bufs_avx512(struct iavf_tx_queue *txq) /* n is multiple of 32 */ while (copied < n) { +#ifdef RTE_ARCH_64 const __m512i a = _mm512_loadu_si512(&txep[copied]); const __m512i b = _mm512_loadu_si512(&txep[copied + 8]); @@ -1828,4 +1829,10 @@ iavf_tx_free_bufs_avx512(struct iavf_tx_queue *txq) _mm512_storeu_si512(&cache_objs[copied + 16], c); _mm512_storeu_si512(&cache_objs[copied + 24], d); +#else + const __m512i a = _mm512_loadu_si512(&txep[copied]); + const __m512i b = _mm512_loadu_si512(&txep[copied + 16]); + _mm512_storeu_si512(&cache_objs[copied], a); + _mm512_storeu_si512(&cache_objs[copied + 16], b); +#endif copied += 32; } -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:39.578254385 +0000 +++ 0041-net-iavf-fix-AVX-512-pointer-copy-on-32-bit.patch 2024-11-27 17:17:38.207269280 +0000 @@ -1 +1 @@ -From 77608b24bdd840d323ebd9cb6ffffaf5c760983e Mon Sep 17 00:00:00 2001 +From 4d613e1278426faa2bac791b0ef756daf37f231d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 77608b24bdd840d323ebd9cb6ffffaf5c760983e ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 3bb6f305df..d6a861bf80 100644 +index 9876c715e5..874ae55676 100644 @@ -23 +24 @@ -@@ -1893,4 +1893,5 @@ iavf_tx_free_bufs_avx512(struct iavf_tx_queue *txq) +@@ -1819,4 +1819,5 @@ iavf_tx_free_bufs_avx512(struct iavf_tx_queue *txq) @@ -29 +30 @@ -@@ -1902,4 +1903,10 @@ iavf_tx_free_bufs_avx512(struct iavf_tx_queue *txq) +@@ -1828,4 +1829,10 @@ iavf_tx_free_bufs_avx512(struct iavf_tx_queue *txq)