From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBA1345DB9 for ; Wed, 27 Nov 2024 18:21:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2E2F402DE; Wed, 27 Nov 2024 18:21:09 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 84A50402E1 for ; Wed, 27 Nov 2024 18:21:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GgNeEmneHkfh2XsY3NKk2tR3Fkaj2w4Pu48bJQpIQsY=; b=FIycjhmS8n7H5MlM0/Np0zMNR1IsXo7xb309afRpJ81DURj1YE7kGBjNx1wpglFdPWgacE J4bklSFU/l2yQUHYxFASVVdXn0AIP28Cze6cBCofmMOB8BLuqer12ynLbiCMKANHVlemyg dQ0nrLYNA8wj8cUFDWnAY3yCU61yiOQ= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-cLd2mdeJNGKxHIRCA3C1zQ-1; Wed, 27 Nov 2024 12:21:06 -0500 X-MC-Unique: cLd2mdeJNGKxHIRCA3C1zQ-1 X-Mimecast-MFC-AGG-ID: cLd2mdeJNGKxHIRCA3C1zQ Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 948281955BCF; Wed, 27 Nov 2024 17:21:05 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F03DB300019E; Wed, 27 Nov 2024 17:21:03 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Ofer Dagan , Ferruh Yigit , dpdk stable Subject: patch 'net/pcap: set live interface as non-blocking' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:17:51 +0000 Message-ID: <20241127171916.690404-44-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LCF3nSlFtUFoR_MQrMmGNL9X3CWuCvV3qxHx36Sj52U_1732728065 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/e0e6edfb2e139ca981527837a218d2c7a3968751 Thanks. Kevin --- >From e0e6edfb2e139ca981527837a218d2c7a3968751 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Sat, 24 Aug 2024 11:07:10 -0700 Subject: [PATCH] net/pcap: set live interface as non-blocking [ upstream commit 60dd5a70035f447104d457aa338557fb58d5cb06 ] The DPDK PMD's are supposed to be non-blocking and poll for packets. Configure PCAP to do this on live interface. Bugzilla ID: 1526 Fixes: 4c173302c307 ("pcap: add new driver") Reported-by: Ofer Dagan Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit --- drivers/net/pcap/pcap_ethdev.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c index ec29fd6bc5..4d79565460 100644 --- a/drivers/net/pcap/pcap_ethdev.c +++ b/drivers/net/pcap/pcap_ethdev.c @@ -522,4 +522,10 @@ open_iface_live(const char *iface, pcap_t **pcap) { } + if (pcap_setnonblock(*pcap, 1, errbuf)) { + PMD_LOG(ERR, "Couldn't set non-blocking on %s: %s", iface, errbuf); + pcap_close(*pcap); + return -1; + } + return 0; } -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:39.674011234 +0000 +++ 0044-net-pcap-set-live-interface-as-non-blocking.patch 2024-11-27 17:17:38.218269337 +0000 @@ -1 +1 @@ -From 60dd5a70035f447104d457aa338557fb58d5cb06 Mon Sep 17 00:00:00 2001 +From e0e6edfb2e139ca981527837a218d2c7a3968751 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 60dd5a70035f447104d457aa338557fb58d5cb06 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 9626c343dc..1fb98e3d2b 100644 +index ec29fd6bc5..4d79565460 100644 @@ -24 +25 @@ -@@ -523,4 +523,10 @@ open_iface_live(const char *iface, pcap_t **pcap) { +@@ -522,4 +522,10 @@ open_iface_live(const char *iface, pcap_t **pcap) {