From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B22FC45DB9 for ; Wed, 27 Nov 2024 18:22:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AECF1402E4; Wed, 27 Nov 2024 18:22:08 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 201F7402E4 for ; Wed, 27 Nov 2024 18:22:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CMKDqxmxJu3xrW0T0lMtVC9Gbwqb29G98pvXYgHVkF8=; b=RDnempFhRuJD6LzibLA9ZlU0xF5qoe+b63GHakn/Gia2pc1H1hYtZI2MT7xU8/7rMasum2 YsYTokPJVtC5TvCwPSZQwgVveBNXFu2Y5Ykbi7pKKHEshvVJ6O7A3YzRmIbdmOYNLWeg6P jA6s2uv4o2NZt612VhoefMxKEXw+B5c= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-VaGYeMqwOvyXWlgXG8eBnQ-1; Wed, 27 Nov 2024 12:22:06 -0500 X-MC-Unique: VaGYeMqwOvyXWlgXG8eBnQ-1 X-Mimecast-MFC-AGG-ID: VaGYeMqwOvyXWlgXG8eBnQ Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4D41E19540F2; Wed, 27 Nov 2024 17:22:05 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CA100300019E; Wed, 27 Nov 2024 17:22:03 +0000 (UTC) From: Kevin Traynor To: Lewis Donzis Cc: Stephen Hemminger , dpdk stable Subject: patch 'net/ixgbe: fix link status delay on FreeBSD' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:18:20 +0000 Message-ID: <20241127171916.690404-73-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GU56j1fidVZm_KMCkI-_MCH1Tb1Lfj9pWTj_9vtY4Hs_1732728125 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/67314fb203bae34cbfd018d0782845c618c39067 Thanks. Kevin --- >From 67314fb203bae34cbfd018d0782845c618c39067 Mon Sep 17 00:00:00 2001 From: Lewis Donzis Date: Tue, 22 Oct 2024 09:42:05 -0500 Subject: [PATCH] net/ixgbe: fix link status delay on FreeBSD [ upstream commit f775386d92d68e534600fcff3fc4bcaa30d3e68c ] Forcing wait true prevents checking link status without delay, because the function will wait more than 10 seconds for link status to be true, even if the API caller requested no waiting. Fixes: 0012111a3d87 ("net/ixgbe: fix link status synchronization on BSD") Signed-off-by: Lewis Donzis Acked-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 4ba25435fd..df3baa6483 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4305,9 +4305,4 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, wait = 0; -/* BSD has no interrupt mechanism, so force NIC status synchronization. */ -#ifdef RTE_EXEC_ENV_FREEBSD - wait = 1; -#endif - if (vf) diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait); -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:40.556323004 +0000 +++ 0073-net-ixgbe-fix-link-status-delay-on-FreeBSD.patch 2024-11-27 17:17:38.272269617 +0000 @@ -1 +1 @@ -From f775386d92d68e534600fcff3fc4bcaa30d3e68c Mon Sep 17 00:00:00 2001 +From 67314fb203bae34cbfd018d0782845c618c39067 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f775386d92d68e534600fcff3fc4bcaa30d3e68c ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index ab37c37469..008760e315 100644 +index 4ba25435fd..df3baa6483 100644 @@ -23 +24 @@ -@@ -4315,9 +4315,4 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, +@@ -4305,9 +4305,4 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,