From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0730945DB9 for ; Wed, 27 Nov 2024 18:22:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01D15402DE; Wed, 27 Nov 2024 18:22:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 590C8402DE for ; Wed, 27 Nov 2024 18:22:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LFawMzyOg9Tk5Xa0/w93E/7UpsrKL96K/aIVqzFdoa4=; b=Zzywsw91sKAxr0tDt3WF/saz+vFj9wfk7yFgYTUrJIKrqTwz1s4AQ5bltiepv0TWqGek3z sYyIHZZ0gTK8lKIYEgvFozg1S6JZssDBCI0XVQ3MyIMqu3HQ6gpwUXSfz4BtTIBPpNghpO dSsIJNTcRE0ecSz/4o4sVa+nKB5/K9Y= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-f6fldPY7NSKqCjxDRJYxFg-1; Wed, 27 Nov 2024 12:22:08 -0500 X-MC-Unique: f6fldPY7NSKqCjxDRJYxFg-1 X-Mimecast-MFC-AGG-ID: f6fldPY7NSKqCjxDRJYxFg Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 854EA195608C; Wed, 27 Nov 2024 17:22:07 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CAE0C300019E; Wed, 27 Nov 2024 17:22:05 +0000 (UTC) From: Kevin Traynor To: Chengwen Feng Cc: Ferruh Yigit , Stephen Hemminger , dpdk stable Subject: patch 'net/mvneta: fix possible out-of-bounds write' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:18:21 +0000 Message-ID: <20241127171916.690404-74-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ifBXPkdyHq8T7o76MEjRcKFMz4jA0LInYOhrsThcGTM_1732728127 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/45d6cd5440c63da87a2e8a2573b43a778194e50f Thanks. Kevin --- >From 45d6cd5440c63da87a2e8a2573b43a778194e50f Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 10 Oct 2024 00:53:26 +0000 Subject: [PATCH] net/mvneta: fix possible out-of-bounds write [ upstream commit c705c67d304b9450824a169b652520c2358c6aee ] The mvneta_ifnames_get() function will save 'iface' value to ifnames, it will out-of-bounds write if passed many iface pairs (e.g. 'iface=xxx,iface=xxx,...'). Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton") Signed-off-by: Chengwen Feng Acked-by: Ferruh Yigit Acked-by: Stephen Hemminger --- drivers/net/mvneta/mvneta_ethdev.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c index 309336eec3..3163f7a0c3 100644 --- a/drivers/net/mvneta/mvneta_ethdev.c +++ b/drivers/net/mvneta/mvneta_ethdev.c @@ -92,4 +92,10 @@ mvneta_ifnames_get(const char *key __rte_unused, const char *value, struct mvneta_ifnames *ifnames = extra_args; + if (ifnames->idx >= NETA_NUM_ETH_PPIO) { + MVNETA_LOG(ERR, "Too many ifnames specified (max %u)", + NETA_NUM_ETH_PPIO); + return -EINVAL; + } + ifnames->names[ifnames->idx++] = value; -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:40.588598324 +0000 +++ 0074-net-mvneta-fix-possible-out-of-bounds-write.patch 2024-11-27 17:17:38.272269617 +0000 @@ -1 +1 @@ -From c705c67d304b9450824a169b652520c2358c6aee Mon Sep 17 00:00:00 2001 +From 45d6cd5440c63da87a2e8a2573b43a778194e50f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c705c67d304b9450824a169b652520c2358c6aee ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 3841c1ebe9..f99f9e6289 100644 +index 309336eec3..3163f7a0c3 100644