From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A44645DB9 for ; Wed, 27 Nov 2024 18:22:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 939DC4066C; Wed, 27 Nov 2024 18:22:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 08D08402DE for ; Wed, 27 Nov 2024 18:22:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728139; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MiHiT+GsfnpiUm+OPGTXn2p1iCQIpddPtp/CHrIOOBo=; b=Ce8tTQ20UBuDmSm9ediwiCrLugnzwgHEhJy4Rb+pFMS/07sWtWXajp9ETNYuj9JGq5n+Ok RAvAMp0pztRnOHr/WC/ZQB2xD6vXD/Ls2892V6OSL6wqcR8eBGpEYY2kz/HydHNHwDkxHu BxvtsqVd6OyVII/IusR+bVpLML3dasc= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-104-w2ZzltTkOVKSR66JGFcfuw-1; Wed, 27 Nov 2024 12:22:16 -0500 X-MC-Unique: w2ZzltTkOVKSR66JGFcfuw-1 X-Mimecast-MFC-AGG-ID: w2ZzltTkOVKSR66JGFcfuw Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2F5A419560BE; Wed, 27 Nov 2024 17:22:15 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D8483300019E; Wed, 27 Nov 2024 17:22:13 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: Stephen Hemminger , dpdk stable Subject: patch 'app/dumpcap: remove unused struct array' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:18:25 +0000 Message-ID: <20241127171916.690404-78-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: VGo9XNKHidPKdRisL8ITtVIUKrYLO9Yj1gfUoCv_AvA_1732728135 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/5c3cc79f4baca247938b7f9a3627cefdb7d62396 Thanks. Kevin --- >From 5c3cc79f4baca247938b7f9a3627cefdb7d62396 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Tue, 5 Nov 2024 11:27:21 +0000 Subject: [PATCH] app/dumpcap: remove unused struct array [ upstream commit 9bbd44d63846cf0771ec0f1c7e1b5a63ec5e9603 ] The callbacks(rx_cb) member of struct interface was unused inside dumpcap, but was taking up a lot of memory space, since it was scaled according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save memory by removing the whole array. Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Suggested-by: Stephen Hemminger Signed-off-by: Bruce Richardson Acked-by: Stephen Hemminger --- app/dumpcap/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index 1025598b6d..76db2337cb 100644 --- a/app/dumpcap/main.c +++ b/app/dumpcap/main.c @@ -79,6 +79,4 @@ struct interface { uint16_t port; char name[RTE_ETH_NAME_MAX_LEN]; - - struct rte_rxtx_callback *rx_cb[RTE_MAX_QUEUES_PER_PORT]; }; -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:40.719076573 +0000 +++ 0078-app-dumpcap-remove-unused-struct-array.patch 2024-11-27 17:17:38.281269663 +0000 @@ -1 +1 @@ -From 9bbd44d63846cf0771ec0f1c7e1b5a63ec5e9603 Mon Sep 17 00:00:00 2001 +From 5c3cc79f4baca247938b7f9a3627cefdb7d62396 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9bbd44d63846cf0771ec0f1c7e1b5a63ec5e9603 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -18,2 +19,2 @@ - app/dumpcap/main.c | 1 - - 1 file changed, 1 deletion(-) + app/dumpcap/main.c | 2 -- + 1 file changed, 2 deletions(-) @@ -22 +23 @@ -index 4031f48441..3d3c0dbc66 100644 +index 1025598b6d..76db2337cb 100644 @@ -25 +26,2 @@ -@@ -97,5 +97,4 @@ struct interface { +@@ -79,6 +79,4 @@ struct interface { + uint16_t port; @@ -27 +29 @@ - +- @@ -29,2 +31,2 @@ - const char *ifname; - const char *ifdescr; + }; +