From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FA8045DB9 for ; Wed, 27 Nov 2024 18:19:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B759402DE; Wed, 27 Nov 2024 18:19:51 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C56A440663 for ; Wed, 27 Nov 2024 18:19:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732727989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kapn5uVLxfi1HGrMzZGAmoCqGhUIo9bKZIz4e6F7Cpo=; b=LvyLZDuz8z0H7MuFaks1AD8Txp02BXls6+9abLQ0vJiC9pBMDiXmeU8tzfDP5ovxmW8tuU gqRIXsofC2DXDOPj5faBaW4H3gwWjOWH5UQGuPKikITRFFPeEnEYNn3cGXRPwFKAYEMnr0 a0jW/tA+qGUdkB0gX4kXZ7hfqL3hBKI= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-421-njAQaCx2OyuEtAaamRvuIw-1; Wed, 27 Nov 2024 12:19:44 -0500 X-MC-Unique: njAQaCx2OyuEtAaamRvuIw-1 X-Mimecast-MFC-AGG-ID: njAQaCx2OyuEtAaamRvuIw Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C0EC61955F35; Wed, 27 Nov 2024 17:19:42 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1EA4E3003B71; Wed, 27 Nov 2024 17:19:39 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Hemant Agrawal , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Konstantin Ananyev , Wathsala Vithanage , dpdk stable Subject: patch 'baseband/la12xx: fix use after free in modem config' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:17:15 +0000 Message-ID: <20241127171916.690404-8-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pb9Go9DalLgBS299Ka3dvfT7UaFyuVl5RFLMT_hF22M_1732727983 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/ef8926d21470416ee47ee2b0a96ca9da82bc362d Thanks. Kevin --- >From ef8926d21470416ee47ee2b0a96ca9da82bc362d Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 8 Oct 2024 09:47:19 -0700 Subject: [PATCH] baseband/la12xx: fix use after free in modem config MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 6ffb34498913f84713e98d6a2a21d2a86028a604 ] The info pointer (hp) could get freed twice. Fix by nulling after free. In function 'setup_la12xx_dev', inlined from 'la12xx_bbdev_create' at ../drivers/baseband/la12xx/bbdev_la12xx.c:1029:8, inlined from 'la12xx_bbdev_probe' at ../drivers/baseband/la12xx/bbdev_la12xx.c:1075:9: ../drivers/baseband/la12xx/bbdev_la12xx.c:901:9: error: pointer 'hp_info' may be used after 'rte_free' [-Werror=use-after-free] 901 | rte_free(hp); | ^~~~~~~~~~~~ ../drivers/baseband/la12xx/bbdev_la12xx.c:791:17: note: call to 'rte_free' here 791 | rte_free(hp); | ^~~~~~~~~~~~ Fixes: 24d0ba22546e ("baseband/la12xx: add queue and modem config") Signed-off-by: Stephen Hemminger Reviewed-by: Hemant Agrawal Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Wathsala Vithanage --- drivers/baseband/la12xx/bbdev_la12xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/drivers/baseband/la12xx/bbdev_la12xx.c index dfebcd5c81..0ac088810d 100644 --- a/drivers/baseband/la12xx/bbdev_la12xx.c +++ b/drivers/baseband/la12xx/bbdev_la12xx.c @@ -781,4 +781,5 @@ setup_la12xx_dev(struct rte_bbdev *dev) rte_free(hp); + hp = NULL; } -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:38.594404010 +0000 +++ 0008-baseband-la12xx-fix-use-after-free-in-modem-config.patch 2024-11-27 17:17:38.160269036 +0000 @@ -1 +1 @@ -From 6ffb34498913f84713e98d6a2a21d2a86028a604 Mon Sep 17 00:00:00 2001 +From ef8926d21470416ee47ee2b0a96ca9da82bc362d Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 6ffb34498913f84713e98d6a2a21d2a86028a604 ] + @@ -28 +29,0 @@ -Cc: stable@dpdk.org @@ -40 +41 @@ -index af4b4f1e9a..2432cdf884 100644 +index dfebcd5c81..0ac088810d 100644 @@ -43 +44 @@ -@@ -790,4 +790,5 @@ setup_la12xx_dev(struct rte_bbdev *dev) +@@ -781,4 +781,5 @@ setup_la12xx_dev(struct rte_bbdev *dev)