From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B0CA45DB9 for ; Wed, 27 Nov 2024 18:22:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66DF8402DE; Wed, 27 Nov 2024 18:22:29 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 26F7E40A6E for ; Wed, 27 Nov 2024 18:22:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qo0mhebg03KkocNAHcdI9BXiiBBEYNAlOHP0WPhGCm0=; b=hq2k6w3wci98FkBM42XanLkda6tIMBfeGyHH44EQc92o2eHLJ3tcN2f45zZRBjCBjq+u0x VnukPZviXlehRvrD7Atr90Bye2sKlGo9g/LMX4r4TjQVq69F06Wz9WnljuRcfhK37ANc+0 /f2gCUBKTy37C8HkEeVRq5T720Kq6MM= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-503-nwK9tG3mO4SEriURPhUELQ-1; Wed, 27 Nov 2024 12:22:26 -0500 X-MC-Unique: nwK9tG3mO4SEriURPhUELQ-1 X-Mimecast-MFC-AGG-ID: nwK9tG3mO4SEriURPhUELQ Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7546019560A3; Wed, 27 Nov 2024 17:22:25 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 15039300019E; Wed, 27 Nov 2024 17:22:23 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: =?UTF-8?q?Morten=20Br=C3=B8rup?= , dpdk stable Subject: patch 'examples/ntb: check info query return' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:18:30 +0000 Message-ID: <20241127171916.690404-83-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AJVu89tK9yB6Ml12V1N8x9NlcHJjKLCJQeP8s-miCZI_1732728145 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/aa15e16eee6f1d8ce9fce5112deeefd3018f8526 Thanks. Kevin --- >From aa15e16eee6f1d8ce9fce5112deeefd3018f8526 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 4 Oct 2024 09:21:53 -0700 Subject: [PATCH] examples/ntb: check info query return MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 07e4dc04d99a99699d71a0a39dd2a7034049e663 ] The ethdev_info is only valid if rte_eth_dev_info_get returns success. Fixes: 5194299d6ef5 ("examples/ntb: support more functions") Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- examples/ntb/ntb_fwd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index 41bb536141..05826dc493 100644 --- a/examples/ntb/ntb_fwd.c +++ b/examples/ntb/ntb_fwd.c @@ -1444,5 +1444,8 @@ main(int argc, char **argv) if (eth_port_id < RTE_MAX_ETHPORTS) { - rte_eth_dev_info_get(eth_port_id, ðdev_info); + ret = rte_eth_dev_info_get(eth_port_id, ðdev_info); + if (ret) + rte_exit(EXIT_FAILURE, "Can't get info for port %u\n", eth_port_id); + eth_pconf.rx_adv_conf.rss_conf.rss_hf &= ethdev_info.flow_type_rss_offloads; -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:40.883147668 +0000 +++ 0083-examples-ntb-check-info-query-return.patch 2024-11-27 17:17:38.285269684 +0000 @@ -1 +1 @@ -From 07e4dc04d99a99699d71a0a39dd2a7034049e663 Mon Sep 17 00:00:00 2001 +From aa15e16eee6f1d8ce9fce5112deeefd3018f8526 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 07e4dc04d99a99699d71a0a39dd2a7034049e663 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 56c7672392..37d60208e3 100644 +index 41bb536141..05826dc493 100644 @@ -24 +25 @@ -@@ -1286,5 +1286,8 @@ main(int argc, char **argv) +@@ -1444,5 +1444,8 @@ main(int argc, char **argv)