From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1317A45DB9 for ; Wed, 27 Nov 2024 18:22:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DC41402DE; Wed, 27 Nov 2024 18:22:39 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 758E7402DE for ; Wed, 27 Nov 2024 18:22:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9n+oyfaT9Aex5C9JMysoKFrFuvReLyWksGdXF6v5K6E=; b=AF/rCgdRb5nnmgQrkjGc5DVRcOVsvpkMxnT8nMIqv5DvHNE69M75/DoToVGCTpRWKjYodS IYabpbX94UN5jufc1LyvPJw10JJar5UYKYhc1rtliCr8jU8E+ehKd7lbUWOp9aFSot8Eql 6Dpzx4ZsfbUSJazrhDr5T06lpQYvph4= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-526-guoVa9DgMSKJFkRM7p6ufg-1; Wed, 27 Nov 2024 12:22:35 -0500 X-MC-Unique: guoVa9DgMSKJFkRM7p6ufg-1 X-Mimecast-MFC-AGG-ID: guoVa9DgMSKJFkRM7p6ufg Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 901881955D4C; Wed, 27 Nov 2024 17:22:34 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 859DC300019E; Wed, 27 Nov 2024 17:22:33 +0000 (UTC) From: Kevin Traynor To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/txgbe: remove outer UDP checksum capability' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:18:35 +0000 Message-ID: <20241127171916.690404-88-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Lb2N56q4ACw24gQEjcCz9kn5sv5Ag6CjIHh6qPr_oLE_1732728154 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/69778317c93897358162c2ed797c840053420d98 Thanks. Kevin --- >From 69778317c93897358162c2ed797c840053420d98 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Mon, 4 Nov 2024 10:29:57 +0800 Subject: [PATCH] net/txgbe: remove outer UDP checksum capability [ upstream commit 25fe1c780d39ea3637ba8407f6e9a9800135becd ] The hardware does not support outer UDP checksum for tunnel packets. It's wrong to claim this Tx offload capability, so fix it. Bugzilla ID: 1529 Fixes: b950203be7f1 ("net/txgbe: support VXLAN-GPE") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_rxtx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c index 6971c775ef..9d82609b3d 100644 --- a/drivers/net/txgbe/txgbe_rxtx.c +++ b/drivers/net/txgbe/txgbe_rxtx.c @@ -2260,6 +2260,5 @@ txgbe_get_tx_port_offloads(struct rte_eth_dev *dev) tx_offload_capa |= RTE_ETH_TX_OFFLOAD_MACSEC_INSERT; - tx_offload_capa |= RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | - RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM; + tx_offload_capa |= RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM; #ifdef RTE_LIB_SECURITY -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:41.029168728 +0000 +++ 0088-net-txgbe-remove-outer-UDP-checksum-capability.patch 2024-11-27 17:17:38.290269710 +0000 @@ -1 +1 @@ -From 25fe1c780d39ea3637ba8407f6e9a9800135becd Mon Sep 17 00:00:00 2001 +From 69778317c93897358162c2ed797c840053420d98 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 25fe1c780d39ea3637ba8407f6e9a9800135becd ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 5bc0f8772f..c12726553c 100644 +index 6971c775ef..9d82609b3d 100644 @@ -22 +23 @@ -@@ -2285,6 +2285,5 @@ txgbe_get_tx_port_offloads(struct rte_eth_dev *dev) +@@ -2260,6 +2260,5 @@ txgbe_get_tx_port_offloads(struct rte_eth_dev *dev)