From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B9E945DB9 for ; Wed, 27 Nov 2024 18:22:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5550340695; Wed, 27 Nov 2024 18:22:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 34EF4402DE for ; Wed, 27 Nov 2024 18:22:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LJ2qYYxHIWmub5fnyQ5SdFDvmOIP237pMlgYCtfoFJ4=; b=SZh8HGaO5gPEZb7u1G4oy09sak+Sdl12ZeLaWLg+uZfvTvCf7Tw7/MIEuNapbVClSq6Mr/ bHQ9AzNjcKIb+8cQEBsBnxkHMnvcoVP+yOijYTZ2X/pYWIl2ikemZR0Rm+PQOlQXF6YoLd ACGbjo5IdaKkGtRaIHuPYItrEKfTjzE= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-pspK8IMPMFeNezdOuEtLVQ-1; Wed, 27 Nov 2024 12:22:37 -0500 X-MC-Unique: pspK8IMPMFeNezdOuEtLVQ-1 X-Mimecast-MFC-AGG-ID: pspK8IMPMFeNezdOuEtLVQ Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9D0F819541BE; Wed, 27 Nov 2024 17:22:36 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5BF14300019E; Wed, 27 Nov 2024 17:22:34 +0000 (UTC) From: Kevin Traynor To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/txgbe: fix driver load bit to inform firmware' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:18:36 +0000 Message-ID: <20241127171916.690404-89-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: aASztLy4nkaY_Ra8ywqFNDjA5OKmsYrO8xFOFZlAc_8_1732728156 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/aae3e72718580b90f4fc377d5e5c0ce4d71f1e2f Thanks. Kevin --- >From aae3e72718580b90f4fc377d5e5c0ce4d71f1e2f Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Mon, 4 Nov 2024 10:29:58 +0800 Subject: [PATCH] net/txgbe: fix driver load bit to inform firmware [ upstream commit 0a8f064bbc2cf4978857eae84e86c6b2c9e65feb ] Drv_load bit will be reset to default 0 after hardware LAN reset, reconfigure it to inform firmware that driver is loaded. And set it to 0 when device is closed. Fixes: b1f596677d8e ("net/txgbe: support device start") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 1dbf7c554e..9fc3d1df4d 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -331,4 +331,6 @@ txgbe_pf_reset_hw(struct txgbe_hw *hw) ctrl_ext = rd32(hw, TXGBE_PORTCTL); + /* let hardware know driver is loaded */ + ctrl_ext |= TXGBE_PORTCTL_DRVLOAD; /* Set PF Reset Done bit so PF/VF Mail Ops can work */ ctrl_ext |= TXGBE_PORTCTL_RSTDONE; @@ -2008,4 +2010,7 @@ txgbe_dev_close(struct rte_eth_dev *dev) ret = txgbe_dev_stop(dev); + /* Let firmware take over control of hardware */ + wr32m(hw, TXGBE_PORTCTL, TXGBE_PORTCTL_DRVLOAD, 0); + txgbe_dev_free_queues(dev); -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:41.061123632 +0000 +++ 0089-net-txgbe-fix-driver-load-bit-to-inform-firmware.patch 2024-11-27 17:17:38.292269720 +0000 @@ -1 +1 @@ -From 0a8f064bbc2cf4978857eae84e86c6b2c9e65feb Mon Sep 17 00:00:00 2001 +From aae3e72718580b90f4fc377d5e5c0ce4d71f1e2f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0a8f064bbc2cf4978857eae84e86c6b2c9e65feb ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 2834468764..4aa3bfd0bc 100644 +index 1dbf7c554e..9fc3d1df4d 100644 @@ -22 +23 @@ -@@ -332,4 +332,6 @@ txgbe_pf_reset_hw(struct txgbe_hw *hw) +@@ -331,4 +331,6 @@ txgbe_pf_reset_hw(struct txgbe_hw *hw) @@ -29 +30 @@ -@@ -2062,4 +2064,7 @@ txgbe_dev_close(struct rte_eth_dev *dev) +@@ -2008,4 +2010,7 @@ txgbe_dev_close(struct rte_eth_dev *dev)