From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C4B145DB9 for ; Wed, 27 Nov 2024 18:19:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 722F04066F; Wed, 27 Nov 2024 18:19:54 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9A8C84066F for ; Wed, 27 Nov 2024 18:19:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732727993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9PQ8RgT8lHLoVRzyeiKUf84ZBGzNSEqsUY8D6WpYqS0=; b=U5eMaE7vh5i5dk2STQU3yBkeJ2FK7JvYzYdeBVyIk4iDTzh8TXhwLms67Il8X268s0a9B+ fd/4pZfhA2xDDuCBpyuZqB8yCED64aUd8JeUhMveuFyxu+We1mdtAkPgAZXx0Vzq6ogOoM 211cTO6c7rbnkE5kOShrTZvyAaMrE7w= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-686-wOFwcxXQO8KdXpugCjrS7w-1; Wed, 27 Nov 2024 12:19:47 -0500 X-MC-Unique: wOFwcxXQO8KdXpugCjrS7w-1 X-Mimecast-MFC-AGG-ID: wOFwcxXQO8KdXpugCjrS7w Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CCF071955E92; Wed, 27 Nov 2024 17:19:45 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 56932300019E; Wed, 27 Nov 2024 17:19:43 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Ajit Khaparde , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Konstantin Ananyev , Wathsala Vithanage , dpdk stable Subject: patch 'crypto/bcmfs: fix free function mismatch' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:17:16 +0000 Message-ID: <20241127171916.690404-9-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Os-sXFbiYL8tcv6X3Z1pUMSJZXYTlzxXewuL2RH2Nqg_1732727986 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/17d0a3e5438d1bff2d17266ff4f1111008c138cb Thanks. Kevin --- >From 17d0a3e5438d1bff2d17266ff4f1111008c138cb Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 8 Oct 2024 09:47:06 -0700 Subject: [PATCH] crypto/bcmfs: fix free function mismatch MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit b1703af8e77d9e872e2ead92ab2dbcf290686f78 ] The device structure is allocated with rte_malloc() and then incorrectly freed with free(). This will lead to corrupt malloc pool. Bugzilla ID: 1552 Fixes: c8e79da7c676 ("crypto/bcmfs: introduce BCMFS driver") Signed-off-by: Stephen Hemminger Acked-by: Ajit Khaparde Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Wathsala Vithanage --- drivers/crypto/bcmfs/bcmfs_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/bcmfs/bcmfs_device.c b/drivers/crypto/bcmfs/bcmfs_device.c index 27720e4eb8..0d43a9bad0 100644 --- a/drivers/crypto/bcmfs/bcmfs_device.c +++ b/drivers/crypto/bcmfs/bcmfs_device.c @@ -139,5 +139,5 @@ fsdev_allocate_one_dev(struct rte_vdev_device *vdev, cleanup: - free(fsdev); + rte_free(fsdev); return NULL; @@ -163,5 +163,5 @@ fsdev_release(struct bcmfs_device *fsdev) TAILQ_REMOVE(&fsdev_list, fsdev, next); - free(fsdev); + rte_free(fsdev); } -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:38.623181519 +0000 +++ 0009-crypto-bcmfs-fix-free-function-mismatch.patch 2024-11-27 17:17:38.160269036 +0000 @@ -1 +1 @@ -From b1703af8e77d9e872e2ead92ab2dbcf290686f78 Mon Sep 17 00:00:00 2001 +From 17d0a3e5438d1bff2d17266ff4f1111008c138cb Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit b1703af8e77d9e872e2ead92ab2dbcf290686f78 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index ada7ba342c..46522970d5 100644 +index 27720e4eb8..0d43a9bad0 100644 @@ -30 +31 @@ -@@ -140,5 +140,5 @@ fsdev_allocate_one_dev(struct rte_vdev_device *vdev, +@@ -139,5 +139,5 @@ fsdev_allocate_one_dev(struct rte_vdev_device *vdev, @@ -37 +38 @@ -@@ -164,5 +164,5 @@ fsdev_release(struct bcmfs_device *fsdev) +@@ -163,5 +163,5 @@ fsdev_release(struct bcmfs_device *fsdev)