From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3748145DB9 for ; Wed, 27 Nov 2024 18:22:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3347B402DE; Wed, 27 Nov 2024 18:22:43 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 85005402DE for ; Wed, 27 Nov 2024 18:22:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oBaNk8cX7l9fiChOXzbppxmUrv1QBKK2pmO332uzGZ4=; b=NXVO5Gpe5O72fC/9s7j/nkP16o6rgPpCmpzb/OBUg3vfweI0KZMT1Np26eRxRhvUuy0URf hD15/XwTFgPordbX275ulrRB62nmYtdutfOfHvB1qx+zeSOM1Qq4vGmNJMdyb3w6WkUCa9 bK25H7HRZExta8qTteT9stwwgurjwOU= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-656-zKykJImjO8qAH5xtgArAAg-1; Wed, 27 Nov 2024 12:22:39 -0500 X-MC-Unique: zKykJImjO8qAH5xtgArAAg-1 X-Mimecast-MFC-AGG-ID: zKykJImjO8qAH5xtgArAAg Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5E23C1936125; Wed, 27 Nov 2024 17:22:38 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 38C6A30001A2; Wed, 27 Nov 2024 17:22:36 +0000 (UTC) From: Kevin Traynor To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/ngbe: fix driver load bit to inform firmware' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:18:37 +0000 Message-ID: <20241127171916.690404-90-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YCCIZTJ6Wvo39INnlvVwD0mOadvj3eDQc74rivml158_1732728158 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/777fff1f9f38b148f74984a2744442b3baf08d41 Thanks. Kevin --- >From 777fff1f9f38b148f74984a2744442b3baf08d41 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Mon, 4 Nov 2024 10:30:04 +0800 Subject: [PATCH] net/ngbe: fix driver load bit to inform firmware [ upstream commit cb7be5b510ef0995fa171832f0e0994f667e2161 ] Drv_load bit will be reset to default 0 after hardware LAN reset, reconfigure it to inform firmware that driver is loaded. And set it to 0 when device is closed. Fixes: 3518df5774c7 ("net/ngbe: support device start/stop") Fixes: cc63194e89cb ("net/ngbe: support close and reset device") Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index 7866f05571..2ad0f9d92f 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -264,4 +264,6 @@ ngbe_pf_reset_hw(struct ngbe_hw *hw) ctrl_ext = rd32(hw, NGBE_PORTCTL); + /* let hardware know driver is loaded */ + ctrl_ext |= NGBE_PORTCTL_DRVLOAD; /* Set PF Reset Done bit so PF/VF Mail Ops can work */ ctrl_ext |= NGBE_PORTCTL_RSTDONE; @@ -1225,4 +1227,7 @@ ngbe_dev_close(struct rte_eth_dev *dev) ngbe_dev_stop(dev); + /* Let firmware take over control of hardware */ + wr32m(hw, NGBE_PORTCTL, NGBE_PORTCTL_DRVLOAD, 0); + ngbe_dev_free_queues(dev); -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:41.094089255 +0000 +++ 0090-net-ngbe-fix-driver-load-bit-to-inform-firmware.patch 2024-11-27 17:17:38.294269731 +0000 @@ -1 +1 @@ -From cb7be5b510ef0995fa171832f0e0994f667e2161 Mon Sep 17 00:00:00 2001 +From 777fff1f9f38b148f74984a2744442b3baf08d41 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit cb7be5b510ef0995fa171832f0e0994f667e2161 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 353d17acc8..238533f2b8 100644 +index 7866f05571..2ad0f9d92f 100644 @@ -30 +31 @@ -@@ -1278,4 +1280,7 @@ ngbe_dev_close(struct rte_eth_dev *dev) +@@ -1225,4 +1227,7 @@ ngbe_dev_close(struct rte_eth_dev *dev)