From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14D1B45DB9 for ; Wed, 27 Nov 2024 18:22:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EFC240A82; Wed, 27 Nov 2024 18:22:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 96173406BB for ; Wed, 27 Nov 2024 18:22:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bjThUXlK0OlQ1LL5+Hs4Jk8ohhmHWT9yK6kZUc76hYk=; b=IIZKmaRxMSuk43Vn7oOk69NT0a4kBN5+D+Kxnv7U1qwzTb2xoC2183uRTvPNwkehS6R51g 8uhaB4Ut2T4ibvyn8o+WqD3FoQDfrPkzBuJmvVy1RDZn67KhROPaIBbKLKSlxgvmzhDsF6 1zxgc9I76u6kLbU3TjX+KUNFxJq6H6k= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-8_RdRooiP3GedrAxM0Mcxw-1; Wed, 27 Nov 2024 12:22:43 -0500 X-MC-Unique: 8_RdRooiP3GedrAxM0Mcxw-1 X-Mimecast-MFC-AGG-ID: 8_RdRooiP3GedrAxM0Mcxw Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2D9D519541BE; Wed, 27 Nov 2024 17:22:42 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E733A300019E; Wed, 27 Nov 2024 17:22:40 +0000 (UTC) From: Kevin Traynor To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/ngbe: fix interrupt lost in legacy or MSI mode' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:18:39 +0000 Message-ID: <20241127171916.690404-92-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JejinNNCgKJzYpTnX3NGOmU0Oc3BVxcXVuBQmYVYJMo_1732728162 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/aa65a44cbd5eb95e09f50e4abb7aadabe7d0411e Thanks. Kevin --- >From aa65a44cbd5eb95e09f50e4abb7aadabe7d0411e Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Mon, 4 Nov 2024 10:30:06 +0800 Subject: [PATCH] net/ngbe: fix interrupt lost in legacy or MSI mode [ upstream commit 68f04c0aa79316de333441e7efdadd2876412ffa ] When interrupt is legacy or MSI mode, shared interrupt may cause the interrupt cannot be re-enabled. So fix to read the shared interrupt. Fixes: b9246b8fa280 ("net/ngbe: support link update") Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index e95a315c7c..a5854235dd 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -2133,4 +2133,17 @@ ngbe_dev_interrupt_get_status(struct rte_eth_dev *dev) struct ngbe_interrupt *intr = ngbe_dev_intr(dev); + eicr = ((u32 *)hw->isb_mem)[NGBE_ISB_VEC0]; + if (!eicr) { + /* + * shared interrupt alert! + * make sure interrupts are enabled because the read will + * have disabled interrupts. + */ + if (!hw->adapter_stopped) + ngbe_enable_intr(dev); + return 0; + } + ((u32 *)hw->isb_mem)[NGBE_ISB_VEC0] = 0; + /* read-on-clear nic registers here */ eicr = ((u32 *)hw->isb_mem)[NGBE_ISB_MISC]; -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:41.156963193 +0000 +++ 0092-net-ngbe-fix-interrupt-lost-in-legacy-or-MSI-mode.patch 2024-11-27 17:17:38.300269762 +0000 @@ -1 +1 @@ -From 68f04c0aa79316de333441e7efdadd2876412ffa Mon Sep 17 00:00:00 2001 +From aa65a44cbd5eb95e09f50e4abb7aadabe7d0411e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 68f04c0aa79316de333441e7efdadd2876412ffa ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index c372fd928c..325a9d1eaf 100644 +index e95a315c7c..a5854235dd 100644 @@ -21 +22 @@ -@@ -2194,4 +2194,17 @@ ngbe_dev_interrupt_get_status(struct rte_eth_dev *dev) +@@ -2133,4 +2133,17 @@ ngbe_dev_interrupt_get_status(struct rte_eth_dev *dev)