From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BBCA45DB9 for ; Wed, 27 Nov 2024 18:22:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 872C3402DE; Wed, 27 Nov 2024 18:22:58 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B2076402DE for ; Wed, 27 Nov 2024 18:22:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XR4cvgf3zSbwca6FzWzqmcXf8jqOA+/h0kU84/4WutY=; b=HtBOiCD3wQnxETZJV0w77y+VX1gxvVArgRVoADmmcuL87cX0eZnm+BkXCt4kWngvlW8H0E PymPnuTLEBRBoH1vHHCL05nOO3zu5zCbkd0/7nCOidfKFMKPWHYjdgZcjowmvXLP0/L5yq /BCyWNSY/PKJm85LTSUatC56WDO8KmA= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-390-fhoGNw_9Nnqy0emzC3a0JQ-1; Wed, 27 Nov 2024 12:22:52 -0500 X-MC-Unique: fhoGNw_9Nnqy0emzC3a0JQ-1 X-Mimecast-MFC-AGG-ID: fhoGNw_9Nnqy0emzC3a0JQ Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D49701955DC3; Wed, 27 Nov 2024 17:22:50 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 65E52300019E; Wed, 27 Nov 2024 17:22:49 +0000 (UTC) From: Kevin Traynor To: Hanumanth Pothula Cc: Ali Alnubani , dpdk stable Subject: patch 'event/octeontx: fix possible integer overflow' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:18:43 +0000 Message-ID: <20241127171916.690404-96-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SxkybQX__aTO9emt_qR7h3rnI7nMSBYz6QPaHc29e_c_1732728171 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/1fd16196ce64076972ee5e2261de9fff49df1f55 Thanks. Kevin --- >From 1fd16196ce64076972ee5e2261de9fff49df1f55 Mon Sep 17 00:00:00 2001 From: Hanumanth Pothula Date: Fri, 25 Oct 2024 16:28:02 +0530 Subject: [PATCH] event/octeontx: fix possible integer overflow [ upstream commit 3e86eee028c69b98144e2c62ec48091467e790be ] The last argument passed to ssovf_parsekv() is an unsigned char*, but it is accessed as an integer. This can lead to an integer overflow. Hence, make ensure the argument is accessed as a char and for better error handling use strtol instead of atoi. Bugzilla ID: 1512 Fixes: 3516327e00fd ("event/octeontx: add selftest to device arguments") Signed-off-by: Hanumanth Pothula Tested-by: Ali Alnubani --- drivers/event/octeontx/ssovf_evdev.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeontx/ssovf_evdev.c index 634fa8a27f..42240d9099 100644 --- a/drivers/event/octeontx/ssovf_evdev.c +++ b/drivers/event/octeontx/ssovf_evdev.c @@ -714,8 +714,18 @@ ssovf_close(struct rte_eventdev *dev) static int -ssovf_parsekv(const char *key __rte_unused, const char *value, void *opaque) +ssovf_parsekv(const char *key, const char *value, void *opaque) { - int *flag = opaque; - *flag = !!atoi(value); + uint8_t *flag = opaque; + uint64_t v; + char *end; + + errno = 0; + v = strtoul(value, &end, 0); + if ((errno != 0) || (value == end) || *end != '\0' || v > 1) { + ssovf_log_err("invalid %s value %s", key, value); + return -EINVAL; + } + + *flag = !!v; return 0; } -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:41.280535072 +0000 +++ 0096-event-octeontx-fix-possible-integer-overflow.patch 2024-11-27 17:17:38.305269788 +0000 @@ -1 +1 @@ -From 3e86eee028c69b98144e2c62ec48091467e790be Mon Sep 17 00:00:00 2001 +From 1fd16196ce64076972ee5e2261de9fff49df1f55 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3e86eee028c69b98144e2c62ec48091467e790be ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 3a933b1db7..957fcab04e 100644 +index 634fa8a27f..42240d9099 100644 @@ -27 +28 @@ -@@ -718,8 +718,18 @@ ssovf_close(struct rte_eventdev *dev) +@@ -714,8 +714,18 @@ ssovf_close(struct rte_eventdev *dev)