From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A792C468C4 for ; Tue, 10 Jun 2025 11:21:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D68542E5D; Tue, 10 Jun 2025 11:21:50 +0200 (CEST) Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) by mails.dpdk.org (Postfix) with ESMTP id 6D23C42E5D for ; Tue, 10 Jun 2025 11:21:49 +0200 (CEST) X-QQ-mid: esmtpgz11t1749547307tdd1b6404 X-QQ-Originating-IP: tzofhksFWX1+TWUGj+e5JqDh8pof64+unHNIkTx/zSg= Received: from lap-jiawenwu.trustnetic.com ( [36.20.60.58]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 10 Jun 2025 17:21:46 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 5142522305318828134 EX-QQ-RecipientCnt: 3 From: Jiawen Wu To: mengyuanlou@net-swift.com Cc: Jiawen Wu , stable@dpdk.org Subject: [PATCH 09/12] net/ngbe: fix incorrect device statistics Date: Tue, 10 Jun 2025 17:21:23 +0800 Message-Id: <20250610092126.51960-10-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20250610092126.51960-1-jiawenwu@trustnetic.com> References: <20250610092126.51960-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: esmtpgz:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz8a-1 X-QQ-XMAILINFO: NhvpCzAv3WKA69mwjhsTCOOSy3S5UQOj/rngQ6sUsX3LXSZey9/uyMP/ CgtRAuD+9hvLVLnhBSTBHgmk4VRXoY8jjeMl15ZJ/3DX3r80fVyg3287r4tp3w9HzmdO7Kx uEaYqJ0iOQtnR2YvIylQ8/nvjtUUYtnZp3JHlHXbLR9Y4bab0DviAqjnNeEHgEjhC5R9M6w X9w5xQNkcspbCtvkIZ0DevDTeKNB2XW1KcnW8rtVMIRDJMACnHLpkUmnzGuMG0zQ2BThq1k iz++2FVMrCC4mcseBgEmrVVv5/0n1aL7PXGOX2PV05q0Kj373OYF20TvOkhEAmVDq3uadjt kkxjuIT7AaErfX7RL672WTFbZb0NyruTxKEhDZIgJ4qNf+W3Amc8nJH+E9QWhpARNpgv9JL MdQHHWvhAmxvWtFsNwM9NPbG7pQnztqqth+eZ74kzciUrA4TSRTiNgG0r0o+6aaacT9rjIg 8lKxKVB04+yuGixNz9A+xjLkBlA0arDVcp4jjEoTMqQxTfi9Hb7dLJcgDo9SsfiNIbEEsUK xktDojydXQNdzFYm/XSd/WEbcG5WCL4WllCk2Gk4L9fsmR9H2F8K6jJZ6cAB3xlWEGN6VF0 h3RcyBVtIzTKMUgM/257reB78COMd+ZFavimEmJ0yJmthzBuVbtqwJqCHa5lMXJdtP1G+OS dOqU5qmXuKX4igdz9IG4SWTxhxIBMddqivKr6bc7HHBt/9DyTpuBEMLDvcpeL1w13uxmNyo tDw4NZkw/ejTgAg7s6R4Q2wBSpvoXIxxnkkBwH6YpvP1G1p8gJQ1GVYOIns3tgH7em0ieWm LUyh7Y/KMQLOiuz3Ox61lxuPOFpcQrLqyzZKwYGW62RRk7u/Kkv/ypLsiGQ+G2k+52St/VQ 7LV6erEuZsmLXRY/fTt+dD19LrfmqlkqY4WxOcjc1HNB30ByxRZDlbzI4aMmPGUjiZoIeta L5U7p1BgyltvTTlmxQnvknSbbWHEISP4xeEQ0xsBltRwViIl7Otb9h4H1WhWHavS12RTUQH UFP4+9LLuj1BQOACs8fdcxH6nPWtBNBn8bV71uJ+SeWPUPDFY/BaG6yRLHxCeLfoe65d6ps 3Hry5OYNme0 X-QQ-XMRINFO: M/715EihBoGSf6IYSX1iLFg= X-QQ-RECHKSPAM: 0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The extend statistic "rx_undersize_errors" is incorrectly read as the counter of frames received with a length error, which names "rx_length_error". And "rx_undersize_errors" is the counter of shorter-than-64B frames received without any errors. In addition, "tx_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: fdb1e851975a ("net/ngbe: support basic statistics") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index a8f847de8d..d3ac40299f 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -1429,7 +1429,7 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, hw_stats->rx_total_bytes += rd64(hw, NGBE_MACRXGBOCTL); hw_stats->rx_broadcast_packets += rd64(hw, NGBE_MACRXOCTL); - hw_stats->tx_broadcast_packets += rd32(hw, NGBE_MACTXOCTL); + hw_stats->tx_broadcast_packets += rd64(hw, NGBE_MACTXOCTL); hw_stats->rx_size_64_packets += rd64(hw, NGBE_MACRX1TO64L); hw_stats->rx_size_65_to_127_packets += rd64(hw, NGBE_MACRX65TO127L); @@ -1448,7 +1448,8 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, hw_stats->tx_size_1024_to_max_packets += rd64(hw, NGBE_MACTX1024TOMAXL); - hw_stats->rx_undersize_errors += rd64(hw, NGBE_MACRXERRLENL); + hw_stats->rx_length_errors += rd64(hw, NGBE_MACRXERRLENL); + hw_stats->rx_undersize_errors += rd32(hw, NGBE_MACRXUNDERSIZE); hw_stats->rx_oversize_cnt += rd32(hw, NGBE_MACRXOVERSIZE); hw_stats->rx_jabber_errors += rd32(hw, NGBE_MACRXJABBER); -- 2.48.1