From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82AAE468C4 for ; Tue, 10 Jun 2025 11:21:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C8A342E6F; Tue, 10 Jun 2025 11:21:49 +0200 (CEST) Received: from smtpbg151.qq.com (smtpbg151.qq.com [18.169.211.239]) by mails.dpdk.org (Postfix) with ESMTP id 88F7E42E6F for ; Tue, 10 Jun 2025 11:21:47 +0200 (CEST) X-QQ-mid: esmtpgz11t1749547305t80572969 X-QQ-Originating-IP: dklWu2bopFvnzKBHXSzuoSS+d8ZyzbKiuGTCrug96Vk= Received: from lap-jiawenwu.trustnetic.com ( [36.20.60.58]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 10 Jun 2025 17:21:45 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 16198815604836900126 EX-QQ-RecipientCnt: 3 From: Jiawen Wu To: mengyuanlou@net-swift.com Cc: Jiawen Wu , stable@dpdk.org Subject: [PATCH 08/12] net/txgbe: fix incorrect device statistics Date: Tue, 10 Jun 2025 17:21:22 +0800 Message-Id: <20250610092126.51960-9-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20250610092126.51960-1-jiawenwu@trustnetic.com> References: <20250610092126.51960-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: esmtpgz:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz8a-1 X-QQ-XMAILINFO: M1v+UkG2MoDhFCuLSQSfr0wwFrTgqRWqNGzj2qhPMFRgwg/Z9X4AwlSX PinLlDGtcvojbZhGNFOeLI1NXu7m2Fh1l7/13typAdTglg+o5aIHnGb0d+8+iEZGs0aLfZd jm0lCl+IFN+CmwlareKiMlNZr20s7tBMKLk+OcXYZIT7I2vZLm4+zI0yWRINRJQvTELZCTG lbVHVqpYFKClp48bUksT9T5HZA0mco0MnoBdGvRU7YIeTD/iG0ujw5rThOvOYkBNxXLj8+E sY2z7JuedCT58gldTUCJl6cTItlxXzXMkLDCHA1sq0CTS3SNTV6pJ2u9NLzUYDAHj8/kjZK 8HylrD90cxMNjM59blNW07LaL6ct3TdM5lXmmQXmGElXDGT70wLLc4SmwAfoQ2jDi+kX9/S SXAdPTG6MORBHfMV5Z/p6pGjj8j3G4f+iqAdFy9PeoEI//7/J6IZURbm9uVL0lII8G6HYMA LDkqQFookYBoSItIVCQtrgus9U1ToZ9lpt/uOPj2mpp0t3H0J0YWEwK1hs//u3uec10M+A6 lfrtBfkKuUTK8GZzYAHJidOqrrjepge8T79/8ftZrtmRqvIv/4xsDGPWxyP17JIRZFzGrwL a+RnIgDNDZj3XPlBprxoruTDhd29pAamnX1nFfjxcyhb42PmzZZaD5TkN+ZjtSnAA8XIPbg 1CBOptmpP9umnLpsORNhsyGughJoE4SVAHbLKEiMX5uhrm/TsateB5+gFInDcGa9Et5mown XeQ2FD6auP2NEM8flFjn/lwO/L7dOkT0hF4w87MTP+o8YWbhQSuHzw30XE2uCOJ3NimRcZn HXI5e5dAA8VScK+BQFZpGN66GKl0rQCOC8xSxNm8K4zkNUXPq2DC5c3uRhQACurUG0PO1sl KK+aZSR6hYaYJhGhJwJPm1+kVdSTLyDcJy6GXNRUlGNXdCdN7JGSgpPMNti/4qwAv77bNt/ FqRSUxEhCK8TpqUJAjlXw6ijMCpPQz0NTzK30pFpaHYyDdI4UlDwj7ISBOqKbNd3i6B391e BVXbshFcNpDuGqCNCZLFnIgEZp7knYa8Vw3BTzloJaMyezalbvouTT4awsNlg= X-QQ-XMRINFO: OWPUhxQsoeAVDbp3OJHYyFg= X-QQ-RECHKSPAM: 0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The extend statistic "rx_undersize_errors" is incorrectly read as the counter of frames received with a length error, which names "rx_length_error". And "rx_undersize_errors" is the counter of shorter-than-64B frames received without any errors. In addition, "tx_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: c9bb590d4295 ("net/txgbe: support device statistics") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index b68a0557be..580579094b 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -2250,7 +2250,7 @@ txgbe_read_stats_registers(struct txgbe_hw *hw, hw_stats->rx_total_bytes += rd64(hw, TXGBE_MACRXGBOCTL); hw_stats->rx_broadcast_packets += rd64(hw, TXGBE_MACRXOCTL); - hw_stats->tx_broadcast_packets += rd32(hw, TXGBE_MACTXOCTL); + hw_stats->tx_broadcast_packets += rd64(hw, TXGBE_MACTXOCTL); hw_stats->rx_size_64_packets += rd64(hw, TXGBE_MACRX1TO64L); hw_stats->rx_size_65_to_127_packets += rd64(hw, TXGBE_MACRX65TO127L); @@ -2269,7 +2269,8 @@ txgbe_read_stats_registers(struct txgbe_hw *hw, hw_stats->tx_size_1024_to_max_packets += rd64(hw, TXGBE_MACTX1024TOMAXL); - hw_stats->rx_undersize_errors += rd64(hw, TXGBE_MACRXERRLENL); + hw_stats->rx_length_errors += rd64(hw, TXGBE_MACRXERRLENL); + hw_stats->rx_undersize_errors += rd32(hw, TXGBE_MACRXUNDERSIZE); hw_stats->rx_oversize_cnt += rd32(hw, TXGBE_MACRXOVERSIZE); hw_stats->rx_jabber_errors += rd32(hw, TXGBE_MACRXJABBER); -- 2.48.1