From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77EA1468C4 for ; Tue, 10 Jun 2025 11:27:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 725A342E74; Tue, 10 Jun 2025 11:27:09 +0200 (CEST) Received: from smtpbgbr1.qq.com (smtpbgbr1.qq.com [54.207.19.206]) by mails.dpdk.org (Postfix) with ESMTP id 8527742E6D for ; Tue, 10 Jun 2025 11:27:06 +0200 (CEST) X-QQ-mid: zesmtpsz7t1749547622t98b9f1a2 X-QQ-Originating-IP: KEw0VdNWFJKKIKVrVT4Dla9Z44SoYGoqBSKTpLJ6Nto= Received: from lap-jiawenwu.trustnetic.com ( [36.20.60.58]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 10 Jun 2025 17:27:01 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 9427681808238126758 EX-QQ-RecipientCnt: 3 From: Jiawen Wu To: mengyuanlou@net-swift.com Cc: Jiawen Wu , stable@dpdk.org Subject: [PATCH 09/12] net/ngbe: fix incorrect device statistics Date: Tue, 10 Jun 2025 17:26:36 +0800 Message-Id: <20250610092639.41216-10-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20250610092639.41216-1-jiawenwu@trustnetic.com> References: <20250610092639.41216-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpsz:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz8a-1 X-QQ-XMAILINFO: NhQ9hXNievYaIvSE8ylcaEuSNVRx7E6X5QAFbtT9qTPDqtm+IZA0XAJy RGw16yampvCWKhuisg6+ejWVt+3AkmHYweMUt0CMVXVw3JlK8S4LxWfUkRKmWMX7gesTZW6 xdcerJ+DtoWWOcLgrLXCAfAoHnZmfdVqPCMNkzdZL80tlI8YaTvBuAvXgvUP1Zr5YmqfQw8 riombotHQUd9O7inmEMenZvh5SmilHSzUcXAvjqoWzC4H7h3mf5IfUKutl6C3F5ERggDtSI XnAksX1frQCM74X4tflAFThXRQcCeTlVcP8O6CcScE1B7e01uhUIcOjyXeJt8eNLCM6pTjM 3j3U5rHy6zCKhUfFNjLtWj5fNsWbButeUbJEZSdTXFofWOpL972zjYLhpzeCpLxHspeGhOw KgHdJngMkr76bKEN5oKGZ0B0lyJ+fJ7Y3BTaa1+CLvXpfvYKqMMAnEQeG37loX5pcVgqMwF PV78+JOktZZaLLSWG5d0bsZzBf86ywkyJVefeobnAUSp87/EojIsZwxDVoMAPjYUTQeHHrf 3pUmGS5i09m0/B9jAKC/Z1b9FyKBcyfGViNHniYm79USTKxsQOlym9O5LYVLKGLtOqrJ6NE D7pS+nLD+V7t0HA655/LSimnn39G0cDnswJ8VxPFH/iDqJLSuxPzQJsl953vdzkx5TW6v1l gq0GE41ExQbIYWJZAPRdiXuDBxBgAkXp8itizjO0A1ywm1cHBlv2VYbwZz24sQGprT9lXCM GFe5k/TaC+X5cvUyGvAZtIfcaAflQYPudpMVduOMVU/wLPHyujP3jUyxXz2a38BqUzwiFt5 QRhr+/O2O30x+PhW0JN7VRt4UjS3OL1oUIsD2XG5lK42ZA6GAYcva9cOm96Yv1YrVHwjUiQ ebk9+G/wc+5BReTqqcigj4L4t+MmTLMD0muC1ylgG9sI+o1552bDh142shoEOIJ8nWhCJ7e szHAna3GIPqt/pWFY8v46kdO/sI46uHlhzsdzEOWr030GoUtQ5y0gHz9H9H55Gauh9zXsNZ O+xgkkkIxWCgg6hCML7HZaNnAa1U/X00g1sXjsKCJhgpy6j6YfQNhwjygmzpcrHi19KFwJD eqrHMItl3GjF05rWuIM0QVnLdAEsE2q+dNSk8Pv/Ri0exDJZmpP5PNorOT7YAkWlOiPNciY dHh2 X-QQ-XMRINFO: OWPUhxQsoeAVDbp3OJHYyFg= X-QQ-RECHKSPAM: 0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The extend statistic "rx_undersize_errors" is incorrectly read as the counter of frames received with a length error, which names "rx_length_error". And "rx_undersize_errors" is the counter of shorter-than-64B frames received without any errors. In addition, "tx_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: fdb1e851975a ("net/ngbe: support basic statistics") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index a8f847de8d..d3ac40299f 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -1429,7 +1429,7 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, hw_stats->rx_total_bytes += rd64(hw, NGBE_MACRXGBOCTL); hw_stats->rx_broadcast_packets += rd64(hw, NGBE_MACRXOCTL); - hw_stats->tx_broadcast_packets += rd32(hw, NGBE_MACTXOCTL); + hw_stats->tx_broadcast_packets += rd64(hw, NGBE_MACTXOCTL); hw_stats->rx_size_64_packets += rd64(hw, NGBE_MACRX1TO64L); hw_stats->rx_size_65_to_127_packets += rd64(hw, NGBE_MACRX65TO127L); @@ -1448,7 +1448,8 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, hw_stats->tx_size_1024_to_max_packets += rd64(hw, NGBE_MACTX1024TOMAXL); - hw_stats->rx_undersize_errors += rd64(hw, NGBE_MACRXERRLENL); + hw_stats->rx_length_errors += rd64(hw, NGBE_MACRXERRLENL); + hw_stats->rx_undersize_errors += rd32(hw, NGBE_MACRXUNDERSIZE); hw_stats->rx_oversize_cnt += rd32(hw, NGBE_MACRXOVERSIZE); hw_stats->rx_jabber_errors += rd32(hw, NGBE_MACRXJABBER); -- 2.48.1