From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42EFC468C4 for ; Tue, 10 Jun 2025 11:27:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D68042E5D; Tue, 10 Jun 2025 11:27:04 +0200 (CEST) Received: from smtpbgsg1.qq.com (smtpbgsg1.qq.com [54.254.200.92]) by mails.dpdk.org (Postfix) with ESMTP id 3D3E342E76 for ; Tue, 10 Jun 2025 11:27:02 +0200 (CEST) X-QQ-mid: zesmtpsz7t1749547620t32e8160a X-QQ-Originating-IP: Nwr5MMSTG3wD78q7EzLFgkem1hQH5fZ/wAVm3+vTj/o= Received: from lap-jiawenwu.trustnetic.com ( [36.20.60.58]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 10 Jun 2025 17:26:59 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 7054305922930442050 EX-QQ-RecipientCnt: 3 From: Jiawen Wu To: mengyuanlou@net-swift.com Cc: Jiawen Wu , stable@dpdk.org Subject: [PATCH 08/12] net/txgbe: fix incorrect device statistics Date: Tue, 10 Jun 2025 17:26:35 +0800 Message-Id: <20250610092639.41216-9-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20250610092639.41216-1-jiawenwu@trustnetic.com> References: <20250610092639.41216-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpsz:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz8a-1 X-QQ-XMAILINFO: Nzc98Th+6mOz1vTCIqiVUjMBEKj1d+602IOh4N1sLywxoVEeZGBpocer Nqz1ZWPSbmCMLlitvvUBkdnGWkfDnDh7a5bMWeu6fX/lX1nLpjjTYNW9/sV7aEnRgyAjTUQ IsKLRgkaslC5dCop0P8kMSnGP1WZnQadSUik2Lr6LJpNATItYt0+8EfmRoIvmJP4+qkdWIL QVj7W8m9CtYD7kCObXa8NiBnnda1NqKQ9V1SnZqF//HjEiolTpH8Xm3lbDntVq8kKdHRbPr oTwXcq5Wdix/K89/RMKhDcB8xREG6wIT4t2HIQz+4o2FJfVRLnnkucXHHTxntkbzOhiWo4s Uxzq8e6kX7MUf+vN5Yz5FbdSLnHHW4r6RUsgqvdMY1nkVU8y8PCAjn1H1OkaGy1ejYHlFJU m+uEZOfHeO7qiw4YeSmkdJhsA7eewHNJawdrOCCcjR0MfgKhebaGbdPp47j50fugVSZr1N+ JJFv+AEOxozlzETpwGlDiRNqfMUtoq926bkRROBqwmAL+yLlTDSIdTh9e4YP9c/vcpTw8Ed h1csRr6tcvpopaSpzEpksQQUruu5f2RyjcyJo/hK10fInsvpXjxef0MzdODxFjCdv71ETJP IG+yZgtc9Z9D9zwFJUstrh9UYfqDlgOh+dAsBFjsNG4EEliNYTtuBJhzxI3uoutm6nGeGwa 9176PgVVBO/QypZRMJhTY1/lGXp4ay0vxX1YvWcIdshiD9/wbO4rTKQQ9sit0GR4vFl2+c5 rvp+X6aGCR2iYc1XdBHq20elssvTz5YDqI7gIAQuTjsBVwH0YV6gTLt/q8AUXAILb/2igrT w8TpXAg/sb5IcB1XWsOrSC1RyYznWb4UyZ1U0ClaJ7jbMGOekbOVu68k1ro3SDaZFtY5Bvm hd3dm7OwyWhelVK1yPlvsFxr8P9tHJ6iGj3W6h+fTnKHqHks9dNgsTlJ3aIHvVdETq/0i/4 gZaB3EA0DDnLIpUH4RhmaWeYkEbP1ZFyKB8uWlBGM9tIyjxefbgVJhlLNsQkDlP1lXZhrsw 1RLcKkOOVXYTyCNMV8ancjkCmX9p81ux66oXe2ATcBPGCfMx+cNzl22zFzcE+uzlUJv9wxn yBmI3T7Jh4q6hrh+9R2FVkH6PBfRLihLyLAL9mkTlB+m/V9abeXOJ0= X-QQ-XMRINFO: NI4Ajvh11aEj8Xl/2s1/T8w= X-QQ-RECHKSPAM: 0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The extend statistic "rx_undersize_errors" is incorrectly read as the counter of frames received with a length error, which names "rx_length_error". And "rx_undersize_errors" is the counter of shorter-than-64B frames received without any errors. In addition, "tx_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: c9bb590d4295 ("net/txgbe: support device statistics") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index b68a0557be..580579094b 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -2250,7 +2250,7 @@ txgbe_read_stats_registers(struct txgbe_hw *hw, hw_stats->rx_total_bytes += rd64(hw, TXGBE_MACRXGBOCTL); hw_stats->rx_broadcast_packets += rd64(hw, TXGBE_MACRXOCTL); - hw_stats->tx_broadcast_packets += rd32(hw, TXGBE_MACTXOCTL); + hw_stats->tx_broadcast_packets += rd64(hw, TXGBE_MACTXOCTL); hw_stats->rx_size_64_packets += rd64(hw, TXGBE_MACRX1TO64L); hw_stats->rx_size_65_to_127_packets += rd64(hw, TXGBE_MACRX65TO127L); @@ -2269,7 +2269,8 @@ txgbe_read_stats_registers(struct txgbe_hw *hw, hw_stats->tx_size_1024_to_max_packets += rd64(hw, TXGBE_MACTX1024TOMAXL); - hw_stats->rx_undersize_errors += rd64(hw, TXGBE_MACRXERRLENL); + hw_stats->rx_length_errors += rd64(hw, TXGBE_MACRXERRLENL); + hw_stats->rx_undersize_errors += rd32(hw, TXGBE_MACRXUNDERSIZE); hw_stats->rx_oversize_cnt += rd32(hw, TXGBE_MACRXOVERSIZE); hw_stats->rx_jabber_errors += rd32(hw, TXGBE_MACRXJABBER); -- 2.48.1