From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81DE3468D6 for ; Wed, 11 Jun 2025 12:26:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C9BD40663; Wed, 11 Jun 2025 12:26:30 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by mails.dpdk.org (Postfix) with ESMTP id 4047740144; Wed, 11 Jun 2025 12:26:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749637588; x=1781173588; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mNYznBZRwmEUG3rj9la57uWMKJ3FLUVOTbLRAsL2HwA=; b=K0jhLCacexCvLIR77GsYSnpdhziflvbupyFs+5s0mxfjDmeWwzjo7iJf 5OvfcoZLmWVjSCoT4iUIqfZwIEHdoBwMiKRi80dtAp/3gJSR6FaYCI92y nafNviPxixzSOnSbaSGqaf8tYa+xlSkuCMx+RTFyqzlntHxn5lgv5xch3 jBxZf862a//lR8GtFrAvrJq+iGGA53UDJuiHNBCy0ygN37w9tdWy02yPy 32S8HIHaH+yTVbd7bDsi3cYQOblkcwYY23xwG9JzpFh7yK28u/6YbTShd L5vIq+qApEj+T1q7+YQxToovA8c0zRmom6uTBfa7T0iIfNPD7WGcFwaMt g==; X-CSE-ConnectionGUID: sAabmTDSRdaYIZ4exYWsCA== X-CSE-MsgGUID: y+DeCRiDSE+8h6f1IxtT7A== X-IronPort-AV: E=McAfee;i="6800,10657,11460"; a="50883845" X-IronPort-AV: E=Sophos;i="6.16,227,1744095600"; d="scan'208";a="50883845" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2025 03:26:26 -0700 X-CSE-ConnectionGUID: Gmr9i/eyQSqBQLDst/u+xw== X-CSE-MsgGUID: Va/alGRDTDeOtXvEAGzCug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,227,1744095600"; d="scan'208";a="152317371" Received: from unknown (HELO localhost.localdomain) ([10.239.252.253]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2025 03:26:24 -0700 From: Mingjin Ye To: dev@dpdk.org Cc: Mingjin Ye , stable@dpdk.org, Bruce Richardson , Anatoly Burakov Subject: [PATCH] net/ice: fix DCF RSS hash update Date: Wed, 11 Jun 2025 09:50:57 +0000 Message-Id: <20250611095058.114465-1-mingjinx.ye@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Get rss hash configuration, rss_hf is always the default value. The driver does nothing if the rss key is invalid during the rss hash update. This patch is get the current configuration of rss_hf. Extract the update rss key code from ice_dcf_dev_rss_hash_update to ice_dcf_set_rss_key and make it consistent with the pf behaviour. Fixes: c223cadc9e5f ("net/ice: support RSS hash configuration in DCF mode") Cc: stable@dpdk.org Signed-off-by: Mingjin Ye --- drivers/net/intel/ice/ice_dcf_ethdev.c | 38 +++++++++++++++----------- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/drivers/net/intel/ice/ice_dcf_ethdev.c b/drivers/net/intel/ice/ice_dcf_ethdev.c index efff76afa8..accabd0ab9 100644 --- a/drivers/net/intel/ice/ice_dcf_ethdev.c +++ b/drivers/net/intel/ice/ice_dcf_ethdev.c @@ -1394,31 +1394,38 @@ ice_dcf_dev_rss_reta_query(struct rte_eth_dev *dev, } static int -ice_dcf_dev_rss_hash_update(struct rte_eth_dev *dev, - struct rte_eth_rss_conf *rss_conf) +ice_dcf_set_rss_key(struct ice_dcf_hw *hw, uint8_t *key, uint8_t key_len) { - struct ice_dcf_adapter *adapter = dev->data->dev_private; - struct ice_dcf_hw *hw = &adapter->real_hw; - int ret; - - if (!(hw->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF)) - return -ENOTSUP; - /* HENA setting, it is enabled by default, no change */ - if (!rss_conf->rss_key || rss_conf->rss_key_len == 0) { + if (!key || key_len == 0) { PMD_DRV_LOG(DEBUG, "No key to be configured"); return 0; - } else if (rss_conf->rss_key_len != hw->vf_res->rss_key_size) { + } else if (key_len != hw->vf_res->rss_key_size) { PMD_DRV_LOG(ERR, "The size of hash key configured " "(%d) doesn't match the size of hardware can " - "support (%d)", rss_conf->rss_key_len, + "support (%d)", key_len, hw->vf_res->rss_key_size); return -EINVAL; } - rte_memcpy(hw->rss_key, rss_conf->rss_key, rss_conf->rss_key_len); + rte_memcpy(hw->rss_key, key, key_len); + + return ice_dcf_configure_rss_key(hw); +} + +static int +ice_dcf_dev_rss_hash_update(struct rte_eth_dev *dev, + struct rte_eth_rss_conf *rss_conf) +{ + struct ice_dcf_adapter *adapter = dev->data->dev_private; + struct ice_dcf_hw *hw = &adapter->real_hw; + int ret; + + if (!(hw->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF)) + return -ENOTSUP; - ret = ice_dcf_configure_rss_key(hw); + /* set hash key */ + ret = ice_dcf_set_rss_key(hw, rss_conf->rss_key, rss_conf->rss_key_len); if (ret) return ret; @@ -1452,8 +1459,7 @@ ice_dcf_dev_rss_hash_conf_get(struct rte_eth_dev *dev, if (!(hw->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF)) return -ENOTSUP; - /* Just set it to default value now. */ - rss_conf->rss_hf = ICE_RSS_OFFLOAD_ALL; + rss_conf->rss_hf = dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf; if (!rss_conf->rss_key) return 0; -- 2.25.1