From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 651CD468E4 for ; Thu, 12 Jun 2025 23:08:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F6D942DD9; Thu, 12 Jun 2025 23:08:58 +0200 (CEST) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mails.dpdk.org (Postfix) with ESMTP id D158342E0C for ; Thu, 12 Jun 2025 23:08:56 +0200 (CEST) Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3a503d9ef59so1234632f8f.3 for ; Thu, 12 Jun 2025 14:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749762536; x=1750367336; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E/zvrXnktSEE3MDypanwixn4VwrEuOJAidgeZNJW/pQ=; b=RUKWA73h1af4URMhrU5+Os0lOEQ1ugE7MNY7qqJt3yA7EfaDqjNY+Ydo9dJ3f5mZTY /mW5PPBaHMXyYtB/4T9Sv9WLE/8DDrk2JsV/jiD8gb5Pdm7HgW9raK7/L65ngyDrsNJ+ X4k+y4FCd6HcN52fEfAIH9Al/U3p6APtclfK+dWiT+Nc42OiM7jPADgCF5IL0dXrRK/7 ViK4BffYJLXdiUv6K2bKWle3wGDLLJYtjRyQazqmHDUoK2l1n95IQ6IacvIaxATCSnfs d8YuzqrKJCgpBUYStiV2DsOZYHgy+/nilCAf44iCrX19J/BeE4sBny2pCx9x4O7o6aay M/dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749762536; x=1750367336; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E/zvrXnktSEE3MDypanwixn4VwrEuOJAidgeZNJW/pQ=; b=lgJqjZCtgGGznWqmkWwUlMb7ODKKCHIPnqR+hSTy42EDVS+nY8Owk6a2/ggng/BqbC JYa0nSGhnOzTRHq+JnUtrD3sjFcL5dU2EqYZOUfIyAX1Wfr7l63ndqGjDoAEgwP398II FV0wGf8zCa68/xhO4hJPgj85mxWd+OvtDdoQPha5p0KpxLmO7MrD4epMj9g9w0JurXqH JZzebOMODabNW8bULr6/qnzglU+942H9Hk85eYVyfpuZ+EvXRUhb2UKiEYLSJjLcJ8Ri ijXUF8TukGyu8CQfBBRwO89/b75nzT00tcW9Yscdq3uAjpEzysJdWwUFSyloss6KdVoh 3UlA== X-Forwarded-Encrypted: i=1; AJvYcCViVlqWO8qAXHlQC2chiKpTqalFm3jCeKgJ537sncNDqn0isINBhktgdlkF6PSb8aY9Hr59UKs=@dpdk.org X-Gm-Message-State: AOJu0Yw64acElkMidzhMsmlle7HBFT0X5foObiYXmKh2pA61b9QD1B9q tllSUYw+caMcYvYE5gcxopUtRASATBQqrji+oGP9gGAvO9AaptuBqY/ZJjKezydT X-Gm-Gg: ASbGncvKt2iwwQEL6cEiVFphMR9Uzd5d02eM643htsQ45pgixGdjLr6SWTvd16bjfmo QkCS9/bxkQ4oZ27GZT/7Xxs1vLuOBNOD/YekO/h6IPEMRHlOTiXzfUYpc2RdbgGFZZHc/H2SPxc t04xAfXc9D/xKUsdNWZM1qJx17yDHtc3qqrbuxQCtd6Xdx7BQqFMF+SP5PWRZ5Ow7SAPcoa97mK 8y5OGpUVPbmOnxpq9vyHKl/QfJzrFqVTgcNgSvJfx9NJCuXdn2kueoz+s8TjzZ91Zn/pvH2PV5+ sCWlDlJXdhv/SHA74n6VSMNIJlS4efvIOBQ795NHBTHlrPMyLRU7hiciupEi8x+cUGfNs/m7FcQ 6gX0= X-Google-Smtp-Source: AGHT+IEjLHsCnmVDxD47FvBfBwttYsiUenNjRuo/iVwWuiYCUsSvSf3z/ajcBNOI2Kx1V2shu/MsTw== X-Received: by 2002:a05:6000:290d:b0:3a4:ec23:dba5 with SMTP id ffacd0b85a97d-3a56869d06amr664903f8f.5.1749762536348; Thu, 12 Jun 2025 14:08:56 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:f2df:571a:ae4c:bef2]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4532e184724sm31596735e9.39.2025.06.12.14.08.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 14:08:55 -0700 (PDT) From: luca.boccassi@gmail.com To: Chaoyong He Cc: Long Wu , Peng Zhang , dpdk stable Subject: patch 'app/testpmd: fix RSS hash key update' has been queued to stable release 22.11.9 Date: Thu, 12 Jun 2025 22:06:42 +0100 Message-ID: <20250612210733.2506558-25-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250612210733.2506558-1-luca.boccassi@gmail.com> References: <20250612210733.2506558-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/90f0e78cdc9c1a6c838ff7a4c7f95856dfa20ec5 Thanks. Luca Boccassi --- >From 90f0e78cdc9c1a6c838ff7a4c7f95856dfa20ec5 Mon Sep 17 00:00:00 2001 From: Chaoyong He Date: Tue, 1 Apr 2025 15:48:36 +0800 Subject: [PATCH] app/testpmd: fix RSS hash key update [ upstream commit 24e94a4c86c52f45a7a7c139e4e8484f3afe6d8f ] There has logic problem in 'port_rss_hash_key_update()', the user input will be overwritten by the call to 'rte_eth_dev_rss_hash_conf_get()', so the RSS functions will not get update as expected. ------ testpmd> show port 0 rss-hash key RSS functions: ipv4 ipv6 RSS key: 6D5A56DA255B0EC24167253D43A38FB0D0CA2BCBAE7B30B477CB2DA38030F20C6A42B7 3BBEAC01FA testpmd> port config 0 rss-hash-key ipv6-tcp 6D5A56DA255B0EC24167253D 43A38FB0D0CA2BCBAE7B30B477CB2DA38030F20C6A42B73BBEAC01FA testpmd> show port 0 rss-hash key RSS functions: ipv4 ipv6 RSS key: 6D5A56DA255B0EC24167253D43A38FB0D0CA2BCBAE7B30B477CB2DA38030F20C6A42B7 3BBEAC01FA testpmd> ------ Fixes: 8205e241b2b0 ("app/testpmd: add missing type to RSS hash commands") Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- app/test-pmd/config.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 7c58fed413..17c335e625 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -4184,11 +4184,12 @@ port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *hash_key, rss_conf.rss_key = NULL; rss_conf.rss_key_len = 0; - rss_conf.rss_hf = str_to_rsstypes(rss_type); + rss_conf.rss_hf = 0; diag = rte_eth_dev_rss_hash_conf_get(port_id, &rss_conf); if (diag == 0) { rss_conf.rss_key = hash_key; rss_conf.rss_key_len = hash_key_len; + rss_conf.rss_hf = str_to_rsstypes(rss_type); diag = rte_eth_dev_rss_hash_update(port_id, &rss_conf); } if (diag == 0) -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-12 22:06:24.830451928 +0100 +++ 0025-app-testpmd-fix-RSS-hash-key-update.patch 2025-06-12 22:06:23.842044047 +0100 @@ -1 +1 @@ -From 24e94a4c86c52f45a7a7c139e4e8484f3afe6d8f Mon Sep 17 00:00:00 2001 +From 90f0e78cdc9c1a6c838ff7a4c7f95856dfa20ec5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 24e94a4c86c52f45a7a7c139e4e8484f3afe6d8f ] + @@ -29 +30,0 @@ -Cc: stable@dpdk.org @@ -39 +40 @@ -index e89af21cec..c32e011fa6 100644 +index 7c58fed413..17c335e625 100644 @@ -42 +43 @@ -@@ -4806,11 +4806,12 @@ port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *hash_key, +@@ -4184,11 +4184,12 @@ port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *hash_key,