From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDB7A468E4 for ; Thu, 12 Jun 2025 23:09:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D924442E0C; Thu, 12 Jun 2025 23:09:14 +0200 (CEST) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mails.dpdk.org (Postfix) with ESMTP id 9A3FC42DD9 for ; Thu, 12 Jun 2025 23:09:13 +0200 (CEST) Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3a510432236so1325030f8f.0 for ; Thu, 12 Jun 2025 14:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749762553; x=1750367353; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JFdmYz+4srb2C9aonug6pbCZ4RP0veINYSPxIWcP0vU=; b=Y3sstnH2XshzJ5aOu52Sb9zApEb6qhDE/fn+0IxwSCyCAe5xwd/5EBClqmw6Utn1ys 8A8FrbuS0aYAY0AmAtFv/bQROAs86U8YBkDvAq2tp++LnK54PcRuyRoJiHLnduCzGlSO le9dbLaqa0oyVy9AIuJjkll3ynLM1MzKPu03S2SK1vSG6A+tjPCXCMGDOhJK80rSHFy7 132Dp2HQ7gVrdDeMvpaeKX3pnDWJZuCmRcnyP48Ejzu0TwHl7j0kbziJjaV2gwwOxd3c ilQwZhStE/CgJSRah55jjLCmWvWi4Pz5D8w9GpjsSZIeuc3HvCix8eYlFRURc31IXcfk fzxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749762553; x=1750367353; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JFdmYz+4srb2C9aonug6pbCZ4RP0veINYSPxIWcP0vU=; b=Q9HiRBkl6GR5eC0qys/xm1zyAI/Yin+W1W5kIzK4eYD052VJfzgypF3gkfuCWWCrQn Tg8WET6uf/sks2LdAA21KgP5A3T1eF5xbaWPPLHdnMIhnj5gFAbftUyLTP9xkSUyRGI+ 7WWk3rX/NkgNKK3NfShGhxgCBkH5mNyGZey+kRM8bICo84LDG53LSGWqRsYONgUL7tnd sb3D8e1lkeg+NmJ4jVUPlliXq/k0RhXBRZ5rEEg+BybsFMWBrO0F2ygmAY1vy2/t/J/B vKGkTVnwsEooppk9U3OL6FA2wX4KyE7VPkWxxLZf2vRbGiQpYjQkYOZtgMwujAAcVZ5n 5uMw== X-Gm-Message-State: AOJu0YxQo8GKisfoB5LvvSQXvqyWrcnlM1Qq4rwIBYGPKsCtSEEjYAeA KIRlLfZTCzL3xlrx+vQE+Bc1UmrbQVA6jzrFL+Sy9QuUtPLXq1w7vQAnBBrny0mf X-Gm-Gg: ASbGncteZDaYpqNrjSMMTTSFtWSKfLgdNk3yrJyJjwMGZQWQeRhzNxiExwrqP1mfwD7 EgsAS7KfDn3afcO+UR70R2TW23MC8u+bgE/BdlcWFR1JyfEWPdg26VXsFwsjNOswPlvT6yK9D0s ptPWHfMDYP3G6ekOQqhOjiX/ntXNfYWbzTd7DLGEQrGUL+MZ6PQRK3rLEGh6rmO0Q9127i73Hrq i7GdGoXHiYl69yALTppF/u6mNdaTpR0ch+LskVeA76ke2VrX1uYW6fd36Tai01NwgiWi9MGLNlv dgN97bG4ka9imkWw0duTy1GdNyMmbivUlpVVrK+azHukSuH3yxgKV3H3j2Q5f4LqzH8Z X-Google-Smtp-Source: AGHT+IEYiYt4Nf1xxKV3rhtMejM5saL6UGAcRBDhldEK8uJU952qcjIfi5/RGrzeZ2FIRDiJE8ht4A== X-Received: by 2002:a5d:64e4:0:b0:3a5:4b67:5a70 with SMTP id ffacd0b85a97d-3a5686bcbd3mr553245f8f.18.1749762553077; Thu, 12 Jun 2025 14:09:13 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:f2df:571a:ae4c:bef2]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a568a60f5asm398269f8f.25.2025.06.12.14.09.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 14:09:12 -0700 (PDT) From: luca.boccassi@gmail.com To: Dengdui Huang Cc: dpdk stable Subject: patch 'net/hns3: fix extra wait for link up' has been queued to stable release 22.11.9 Date: Thu, 12 Jun 2025 22:06:46 +0100 Message-ID: <20250612210733.2506558-29-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250612210733.2506558-1-luca.boccassi@gmail.com> References: <20250612210733.2506558-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/29b4c863067a3708647ed76db684dfa966b60fd3 Thanks. Luca Boccassi --- >From 29b4c863067a3708647ed76db684dfa966b60fd3 Mon Sep 17 00:00:00 2001 From: Dengdui Huang Date: Tue, 8 Apr 2025 16:30:56 +0800 Subject: [PATCH] net/hns3: fix extra wait for link up [ upstream commit 7c8cbd3c8ae0cec66fbd5acb89a62ee9742c70b4 ] If the link auto-negotiation of the NIC is disabled, or the flow control auto-negotiation is not supported, it's unnecessary to wait for link establishment. Fixes: 1f411e31a826 ("net/hns3: support flow control autoneg for copper port") Signed-off-by: Dengdui Huang --- drivers/net/hns3/hns3_ethdev.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index e39d0fdb21..a98056b0c0 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/drivers/net/hns3/hns3_ethdev.c @@ -5342,12 +5342,6 @@ hns3_get_current_fc_mode(struct rte_eth_dev *dev) struct hns3_pf *pf = HNS3_DEV_PRIVATE_TO_PF(dev->data->dev_private); struct hns3_mac *mac = &hw->mac; - /* - * When the flow control mode is obtained, the device may not complete - * auto-negotiation. It is necessary to wait for link establishment. - */ - (void)hns3_dev_link_update(dev, 1); - /* * If the link auto-negotiation of the nic is disabled, or the flow * control auto-negotiation is not supported, the forced flow control @@ -5356,6 +5350,12 @@ hns3_get_current_fc_mode(struct rte_eth_dev *dev) if (mac->link_autoneg == 0 || !pf->support_fc_autoneg) return hw->requested_fc_mode; + /* + * When the flow control mode is obtained, the device may not complete + * auto-negotiation. It is necessary to wait for link establishment. + */ + (void)hns3_dev_link_update(dev, 1); + return hns3_get_autoneg_fc_mode(hw); } -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-12 22:06:24.965746239 +0100 +++ 0029-net-hns3-fix-extra-wait-for-link-up.patch 2025-06-12 22:06:23.846044130 +0100 @@ -1 +1 @@ -From 7c8cbd3c8ae0cec66fbd5acb89a62ee9742c70b4 Mon Sep 17 00:00:00 2001 +From 29b4c863067a3708647ed76db684dfa966b60fd3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7c8cbd3c8ae0cec66fbd5acb89a62ee9742c70b4 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 9f7119b734..20ad249b8b 100644 +index e39d0fdb21..a98056b0c0 100644 @@ -22 +23 @@ -@@ -5308,12 +5308,6 @@ hns3_get_current_fc_mode(struct rte_eth_dev *dev) +@@ -5342,12 +5342,6 @@ hns3_get_current_fc_mode(struct rte_eth_dev *dev) @@ -35 +36 @@ -@@ -5322,6 +5316,12 @@ hns3_get_current_fc_mode(struct rte_eth_dev *dev) +@@ -5356,6 +5350,12 @@ hns3_get_current_fc_mode(struct rte_eth_dev *dev)