From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33AD3468E4 for ; Thu, 12 Jun 2025 23:09:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B64A42E02; Thu, 12 Jun 2025 23:09:27 +0200 (CEST) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id E4A1342DD9 for ; Thu, 12 Jun 2025 23:09:25 +0200 (CEST) Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3a53ee6fcd5so896036f8f.1 for ; Thu, 12 Jun 2025 14:09:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749762565; x=1750367365; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gFlVbUCj75NvEYziJkziBPZJ+vKqVZieyIeSkZ3G5vs=; b=LpXzL4Crb5ID8HQgJ+tTaV+J0SlLgu0X2m3vzVJjxeYAXnhVZtxxgT67WufIwyT/uM RurXPmfMk5PNlEGLCLIZFhe+CfFZ75uLj2Gf3eS/hxTnqe2C9CNnz802sPHVd2h0qMlP 0TcylzghKf9nJCHi0ldQcD24d0sP3RkUimuR0Hn2yds3zSMm0Vv3OsHwXeIEl9fWDXrw 3KKLd2ERFmsI+IJ+SBX/WeDOpn/9aWkxF3FEkp0b0nnS2RUePhqwH1Jew/RE9jH0z2FO tJs5yyws/CCxhhdCspJmFjOnQOmy9p/ouIC+tJmM+Od4CxDLBoXnJ0rJWH3VwAhcagA6 HpFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749762565; x=1750367365; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gFlVbUCj75NvEYziJkziBPZJ+vKqVZieyIeSkZ3G5vs=; b=J/q9L06MoAIOfkMdKsctTl1Vl+MA+ljQRh2IMLcmEmYbDC4PQMmWiZbodYhsi0xHjV whEZBubS4QpX3rgyQW4UTrgOsYOuwl9YZKJ+Y8+IemuI1GgApvcNNaIk/r8gDKN+E9kb MEolkxhNcL4lQIw/9ru7G1oDiEEr7mP/bbn0dyAIsQy1vgClV7k2/sTK94NQUJckfPge 0efI/Jdbhk1EEqteDqDUseTp8oUQg9qJdDn3NObWjiw2KPzENF4TLxXnY7yJA4U+dlj6 1q7Ey2OIHb3UMQoZSfSnAKvW8x3gACPJv6AZ+JGbLd46ilf2bmLhH9Ic1xw2T57+Z8sw yZaw== X-Gm-Message-State: AOJu0YxIwogtQGeKCKNaO2UoqJeNQ65fUkwrGsvOtvkLr3fSs07eaVfj FxwZNJiqQ5HoTff5UVBC6PddoHARwIEbYmf/3vYuCCa25fjRSRj9xAzXXxI4Uh59 X-Gm-Gg: ASbGncu3HTcHTg6Kik/HQvXu6zD2OFofUYg9EasdUPtU/bBPK0RyskUvd9YCvzTZvGE BcXFXqB6PuwYl1QBZC3n6qQGu1BAakQhtt2RcQDgckcgz47wwZJCtToV+lawQOVYXzITM0Jwifo SXmx4Zi7a0FQ+RQsA5Kpd+u0vfxi6/9+rKvHu9QdoMKOPVkqaLBSyYZy9hoWazNihs2BL+bIs5g Eu2alYjTudfHvhQAUCQLQPWodMoYiXwvL+dq+EhXllUH9I1DLDhMTKzxKitqZ6DnW3X8G86RKPH s26Ng6LjUH3teJjG/Ilz0YZZvQD0Q8fSOg/F970Q3lu3TwI4SzztjEo04ZGB48xQtiv+ X-Google-Smtp-Source: AGHT+IGp/4Ah0vJgO6XKwISTip784K1z7NfCxteEncloSk48MF5I8vLZxOhGyQ72uweAc3exGMczLg== X-Received: by 2002:a05:6000:178e:b0:3a5:2cb5:642f with SMTP id ffacd0b85a97d-3a5686f0122mr660852f8f.34.1749762565415; Thu, 12 Jun 2025 14:09:25 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:f2df:571a:ae4c:bef2]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a568b4ba58sm363817f8f.84.2025.06.12.14.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 14:09:25 -0700 (PDT) From: luca.boccassi@gmail.com To: Dengdui Huang Cc: dpdk stable Subject: patch 'net/hns3: fix interrupt rollback' has been queued to stable release 22.11.9 Date: Thu, 12 Jun 2025 22:06:48 +0100 Message-ID: <20250612210733.2506558-31-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250612210733.2506558-1-luca.boccassi@gmail.com> References: <20250612210733.2506558-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/38eb97771c115373ff9aa4a99e53679aad9674bd Thanks. Luca Boccassi --- >From 38eb97771c115373ff9aa4a99e53679aad9674bd Mon Sep 17 00:00:00 2001 From: Dengdui Huang Date: Tue, 8 Apr 2025 16:30:58 +0800 Subject: [PATCH] net/hns3: fix interrupt rollback [ upstream commit 9e911049ac5188be7e080aa8699c0d8e97b32110 ] When the port is started, if the Tx queue fails to be started, the map interrupt should be rolled back. Fixes: fdfde7a4a0f8 ("net/hns3: fix mbuf leakage") Signed-off-by: Dengdui Huang --- drivers/net/hns3/hns3_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index a98056b0c0..91d7dc12d2 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/drivers/net/hns3/hns3_ethdev.c @@ -5134,7 +5134,7 @@ hns3_dev_start(struct rte_eth_dev *dev) */ ret = hns3_start_all_txqs(dev); if (ret) - goto map_rx_inter_err; + goto start_all_txqs_fail; ret = hns3_start_all_rxqs(dev); if (ret) @@ -5167,6 +5167,8 @@ hns3_dev_start(struct rte_eth_dev *dev) start_all_rxqs_fail: hns3_stop_all_txqs(dev); +start_all_txqs_fail: + hns3_unmap_rx_interrupt(dev); map_rx_inter_err: (void)hns3_do_stop(hns); do_start_fail: -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-12 22:06:25.046247567 +0100 +++ 0031-net-hns3-fix-interrupt-rollback.patch 2025-06-12 22:06:23.850044215 +0100 @@ -1 +1 @@ -From 9e911049ac5188be7e080aa8699c0d8e97b32110 Mon Sep 17 00:00:00 2001 +From 38eb97771c115373ff9aa4a99e53679aad9674bd Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9e911049ac5188be7e080aa8699c0d8e97b32110 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index 20ad249b8b..2b56b6e44e 100644 +index a98056b0c0..91d7dc12d2 100644 @@ -21 +22 @@ -@@ -5122,7 +5122,7 @@ hns3_dev_start(struct rte_eth_dev *dev) +@@ -5134,7 +5134,7 @@ hns3_dev_start(struct rte_eth_dev *dev) @@ -30 +31 @@ -@@ -5155,6 +5155,8 @@ hns3_dev_start(struct rte_eth_dev *dev) +@@ -5167,6 +5167,8 @@ hns3_dev_start(struct rte_eth_dev *dev)