From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6ECE6468E4 for ; Thu, 12 Jun 2025 23:10:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A94D42E60; Thu, 12 Jun 2025 23:10:51 +0200 (CEST) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mails.dpdk.org (Postfix) with ESMTP id 24BDC42E56 for ; Thu, 12 Jun 2025 23:10:50 +0200 (CEST) Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-451ebd3d149so9950065e9.2 for ; Thu, 12 Jun 2025 14:10:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749762650; x=1750367450; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FJjOdN4/0kjE+ivUvZPwQAb8yymxeFh/T5JoAaX7yr0=; b=BSFRzLYrrU8ZG6TOh17UfNWAV0wluz3Ff4D1ewHJMOo0WG4QjDCTv6FdhafuyL4fNY YuSvaK96RUf7BAbwi3Pf5K+4AxdZpfRNAFs1U1uCuK1kkbWFt1dGc+twn8FcMwVcZ4Qz l5G3Hnkv7zY1JAZP2HbAiJFOFqRvD/QAgZEe+CFVjfqsSXNC28m5sVS3Kj4NXRpwVR+C g+bTBJFm+X0XV0HqDiOwe3pPVar3Gxg+mydzHoNyjrx96MkjdVlQxmnGf3J6WeALsdG6 cfJC8p3mcvZSBu6TuGdWAZGCYKwOajqz3nhV+RNL/pWYZsY1r6+XBrJoFSiYpI9PKggS XIIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749762650; x=1750367450; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FJjOdN4/0kjE+ivUvZPwQAb8yymxeFh/T5JoAaX7yr0=; b=OVN5OvowQgjHlTHAVk/BXWAxTNrkxViXRiKJ3/rENMYZCLHNFha/0QJbpSMngmwk+p j39HMz7MpPF+tApUescCCY0zEeREdo/UOaPrnZkoKHD7LXT539DV9YqJMx6fptQQfTq3 Y2g7Vt7Lnbk7qfwsg246TAY6lYlQEph5I/Mrs3tGKFhH0OZieT86aNCzwBLqtWHteeMo khX8B4ejOMw1vMwymd/WMDQttJtJfEFY/LpUtOqn6YlfdRsMCqLWaAxmq6dk82tELCSw zLNJJibihEF1tBQ5qdUaJ/Ff7x0uVBhT5kzUOhMr2BEqY4a0+gPXXmiclJ+5Qt43zWHn KCow== X-Forwarded-Encrypted: i=1; AJvYcCWEUuCJCK+QVQLaW+k5E53S22Pi/2n4tIQWYkf91hyYRf4h+aMNqLyqz2SooaMpfeE8XL39DSA=@dpdk.org X-Gm-Message-State: AOJu0YwBxnHm2wuDGvh54phmoKJ4IQyd3WHUaKP0CEuHwGzmlRv+Ja0a rG1kWXHkZHrKL49vThnCeKCNFwyRPQRpsRIREOIKmCqF8WIuCQflY5KS X-Gm-Gg: ASbGnctk51EAfNB9GOJ9r6OhMUmoixWUGx4Kn0oWCc4mxQrGB0UAdvV5IEfxdspZZEh WxuDXp6Fr/hUtsXYVjNIayl0nRkq8Yb6IthIAQapq5838NleSHh6wgpOVWlkq1BBE4pi/6yeIwu w/X0gBY6PrrFKDbfE9PzMx0RFoNUSpggm7mSA3cpU5n+DcHwGhouWmTRSUFiOMysDDQRO5gYs5s RsFrVczjqO8IL6Pq0HFeA2lcKSltbDcpiXC4JzGcc4O26Gra7R7ZJll098sP57YoDx6kkS3jV6M zit70OypMEyFu5PWuTZFi3omo1F8jkfo4+Dq0xjrpXq9eDcjN0ngJhlZNWtm/YAV4l5m X-Google-Smtp-Source: AGHT+IGKHWyYiOSz1LUxGUM/y75+aY9cXkxPxnyWWhK41oJcjv1dm4aFPZBPLZIhONcmrPSZNKv5OQ== X-Received: by 2002:a05:6000:4285:b0:3a4:ddd6:427f with SMTP id ffacd0b85a97d-3a56875d7e3mr601421f8f.35.1749762649648; Thu, 12 Jun 2025 14:10:49 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:f2df:571a:ae4c:bef2]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a568b08c99sm373294f8f.63.2025.06.12.14.10.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 14:10:48 -0700 (PDT) From: luca.boccassi@gmail.com To: Radu Nicolau Cc: Akhil Goyal , dpdk stable Subject: patch 'crypto/virtio: fix driver cleanup' has been queued to stable release 22.11.9 Date: Thu, 12 Jun 2025 22:07:15 +0100 Message-ID: <20250612210733.2506558-58-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250612210733.2506558-1-luca.boccassi@gmail.com> References: <20250612210733.2506558-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/fed8ce8b288a7a124d84a6f245beffc198e4c416 Thanks. Luca Boccassi --- >From fed8ce8b288a7a124d84a6f245beffc198e4c416 Mon Sep 17 00:00:00 2001 From: Radu Nicolau Date: Thu, 29 May 2025 11:45:53 +0000 Subject: [PATCH] crypto/virtio: fix driver cleanup [ upstream commit 6adb7f4ae156341958463db80951d8f528932e9f ] Improper cleanup resulted in a segfault when more than 1 device was used Fixes: 6f0175ff53e0 ("crypto/virtio: support basic PMD ops") Signed-off-by: Radu Nicolau Acked-by: Akhil Goyal --- drivers/crypto/virtio/virtio_cryptodev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/virtio/virtio_cryptodev.c b/drivers/crypto/virtio/virtio_cryptodev.c index 51e560e045..6020e70a5a 100644 --- a/drivers/crypto/virtio/virtio_cryptodev.c +++ b/drivers/crypto/virtio/virtio_cryptodev.c @@ -779,8 +779,7 @@ virtio_crypto_dev_uninit(struct rte_cryptodev *cryptodev) cryptodev->enqueue_burst = NULL; cryptodev->dequeue_burst = NULL; - rte_free(cryptodev->data); - cryptodev->data = NULL; + rte_cryptodev_pmd_release_device(cryptodev); VIRTIO_CRYPTO_DRV_LOG_INFO("dev_uninit completed"); -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-12 22:06:25.986510180 +0100 +++ 0058-crypto-virtio-fix-driver-cleanup.patch 2025-06-12 22:06:23.886044975 +0100 @@ -1 +1 @@ -From 6adb7f4ae156341958463db80951d8f528932e9f Mon Sep 17 00:00:00 2001 +From fed8ce8b288a7a124d84a6f245beffc198e4c416 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6adb7f4ae156341958463db80951d8f528932e9f ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index f591cf0c7a..299898e585 100644 +index 51e560e045..6020e70a5a 100644 @@ -22 +23 @@ -@@ -625,8 +625,7 @@ virtio_crypto_dev_uninit(struct rte_cryptodev *cryptodev) +@@ -779,8 +779,7 @@ virtio_crypto_dev_uninit(struct rte_cryptodev *cryptodev)