From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A51C4468E4 for ; Thu, 12 Jun 2025 23:10:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A0D6B42E4F; Thu, 12 Jun 2025 23:10:53 +0200 (CEST) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mails.dpdk.org (Postfix) with ESMTP id 60AB742E0C for ; Thu, 12 Jun 2025 23:10:52 +0200 (CEST) Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3a54836cb7fso908835f8f.2 for ; Thu, 12 Jun 2025 14:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749762652; x=1750367452; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jxo946yuDF4p1/fA7Xeys2IADAfN6zKpr7MhSATHAUo=; b=W6iQeBIfg8EId78HERQGLifJ4bfCwPLJo5++Fotbc5MO+GZT9n4j+z7BbCwpp3gpea wU3l2aRe02MmTIg3NgMGQPd6JxrNcvJODm8yDu+8VhABY6ltEK9nfbtZwLDo5ZbnDUJC jyVFjhhdUP1F1uERbg//K+VR1x/gyOUk1K1pgwpPEE8seBtf0MGg/S1OezWHbCeXptyy 2IhPXEGxK/CYzSCyfTXE4DQFwRULozPYOljU2VwMjv0NTg98HiXXjstjk18tXdjE6mVj /xuMxsCHfoR6WKPy0BCvw5D//64CBT/Kucvfw/hj6+9UWq5N5XJDwb/63eaw/JDCg3oz Z7mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749762652; x=1750367452; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jxo946yuDF4p1/fA7Xeys2IADAfN6zKpr7MhSATHAUo=; b=GJYU0HOB8fB/rUA8IRF8RHtUUeQZcTuBg1Z+UJpMw6286bdLQcZD9DTfm/NupNbP7X /Qw9JZ4YAfj0wHdoMGPZEz+OK6RmLdiVjVbwhAAmUatI1qTu4PCWLQhYQbtrDe3kvz/c WuyEUVVEPPAs6RjVr24Mh/45nvz19QotlBde+O81AUrkghrOKuiXdwvrPuWWwK3zG0bI jKTogY7l2gpeyYUsbZh2fnpb+laRmnBmDLkFnks+Hu/ONUJwOJPV8QLb4jfVtjBM+0Tv l2KqzfGAZRCJasumraoZZS5XfC3JTJwYjoq1ZnhwDRY9IdIK6HMITrjpgAD8SELdajw6 911Q== X-Forwarded-Encrypted: i=1; AJvYcCXrK07t+58jrE2Zv55iu2puX1WU8vnihBxK0oMg1KaDMgJfPQSuhaHPpkW7azVruwJfED3vbpI=@dpdk.org X-Gm-Message-State: AOJu0Yz5Lxqj7Ud9Z4hjTesc3oLqyqSA2OH5+Y52fzNCjr38kWmuQXG7 qj2bxARqh2T9SImFaL9k1DjUeO+le6NrK3myjdTc+OqhIWR2r3gmny8x5sWW8v6MOnU= X-Gm-Gg: ASbGncum1EPjGSJjGekBijSnFOXJlO6RcVX0pxeJSrwMPz9xZBmzM3ubvAXUMrQtwJm hvjR70yxE43f639GbLPFIKkIXNXniOdE8ocdkSsdL/V0Jozen4Gcgrz0X3/4odAVTHpSZURKII8 QG65MhTOyi+TLe9dKwfENZh8+AyweZjP3li7WDsvbGHo8A+fyDXzBYuVGnWDAoieIV1tyI0lfEu 1n6RCpsiPzpH6T5hY0I/sq10OiRnZW+AbILJtrbcH1tcoGw8lCW+tkl7mtXXpVdLu+k4m/sR/Rf yCAPDZJw9Qu3/d9Dp+Rg3fdspeosr9ifJawgGHKXYEp7qruUivgtFGnF8Det8bN9aVED X-Google-Smtp-Source: AGHT+IGA4OCpXJu1kIsvdUDrPJBTfO5UGjVcMMnkI3QMXqMOAQ0YRf/BxTB7h6AFCU8wY4r1wgXNcQ== X-Received: by 2002:a05:6000:1889:b0:3a4:ea1f:3534 with SMTP id ffacd0b85a97d-3a5686e4504mr593770f8f.5.1749762651846; Thu, 12 Jun 2025 14:10:51 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:f2df:571a:ae4c:bef2]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a568a7ddefsm404186f8f.39.2025.06.12.14.10.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 14:10:51 -0700 (PDT) From: luca.boccassi@gmail.com To: Pavan Nikhilesh Cc: =?UTF-8?q?Morten=20Br=C3=B8rup?= , Konstantin Ananyev , dpdk stable Subject: patch 'eal: fix return value of lcore role' has been queued to stable release 22.11.9 Date: Thu, 12 Jun 2025 22:07:17 +0100 Message-ID: <20250612210733.2506558-60-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250612210733.2506558-1-luca.boccassi@gmail.com> References: <20250612210733.2506558-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/8d1e36fc3b8ccc621ad53aa5208ab0555b970dc8 Thanks. Luca Boccassi --- >From 8d1e36fc3b8ccc621ad53aa5208ab0555b970dc8 Mon Sep 17 00:00:00 2001 From: Pavan Nikhilesh Date: Wed, 21 May 2025 01:47:26 +0530 Subject: [PATCH] eal: fix return value of lcore role MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 65e03bc2f35109cb33ad4a6e244d5ea90e78fcde ] Update rte_lcore_has_role() to return false instead of a negative value for invalid lcore IDs, removing the need for callers to pre-validate the ID. Fixes: b0a1502a277c ("eal: make semantics of lcore role function more intuitive") Suggested-by: Morten Brørup Signed-off-by: Pavan Nikhilesh Reviewed-by: Morten Brørup Acked-by: Konstantin Ananyev --- lib/eal/common/eal_common_lcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c index 787dbaff36..9bcfadcf9e 100644 --- a/lib/eal/common/eal_common_lcore.c +++ b/lib/eal/common/eal_common_lcore.c @@ -75,7 +75,7 @@ rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role) struct rte_config *cfg = rte_eal_get_configuration(); if (lcore_id >= RTE_MAX_LCORE) - return -EINVAL; + return 0; return cfg->lcore_role[lcore_id] == role; } -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-12 22:06:26.054207351 +0100 +++ 0060-eal-fix-return-value-of-lcore-role.patch 2025-06-12 22:06:23.886044975 +0100 @@ -1 +1 @@ -From 65e03bc2f35109cb33ad4a6e244d5ea90e78fcde Mon Sep 17 00:00:00 2001 +From 8d1e36fc3b8ccc621ad53aa5208ab0555b970dc8 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 65e03bc2f35109cb33ad4a6e244d5ea90e78fcde ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 294267177d..9dd6c72055 100644 +index 787dbaff36..9bcfadcf9e 100644 @@ -28 +29 @@ -@@ -87,7 +87,7 @@ rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role) +@@ -75,7 +75,7 @@ rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role)