From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0C18468E4 for ; Thu, 12 Jun 2025 23:11:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC51E42E0C; Thu, 12 Jun 2025 23:11:04 +0200 (CEST) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mails.dpdk.org (Postfix) with ESMTP id 6508742E0C for ; Thu, 12 Jun 2025 23:11:03 +0200 (CEST) Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3a53ee6fcd5so896787f8f.1 for ; Thu, 12 Jun 2025 14:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749762663; x=1750367463; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XvWGI2xfPF0gN+NcF+uxsRTSyf/Z0teJCa00XNQemxg=; b=FA9V6fH8ZVbcHhckW9vkKQ19mTbj+Qj2rB1dqZH4JSx3CgGEJzkBJudInzeQZ2zVLW MJ+TJLuuai7+4y8zku8St6dHEZXeaDmtMpZR0eeYOg9vgbGKn82vcz4suls6O8d5NeNB jF6ht3AVGZao2ZfmGVJb1K7nXowxcdu3ju57ecL7qH6WcjhAD7nzI5srBZwRUfuoP3j9 N5EMlmR7SyJdoF/Ql9EJ+q9c/nHPunCQRlZQtlwLszT6d5VHLs3GCmitWdnQckYxKPAJ YDodUuAGFW7qAAD2AmsAvLTcgKf7VlB3v2TCeTTOgO31486BMTe05GdSu62JvZveVAT3 mlEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749762663; x=1750367463; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XvWGI2xfPF0gN+NcF+uxsRTSyf/Z0teJCa00XNQemxg=; b=lqyq86H+Ek/ww0S2PbnJIuBtGIG5iLaVBQIzbO6zAxyS++lPIOGKdAQAEtD8YCwkKA VT5EcsmafYWDLpmSowf1goKuZwiAY/MszH0mZmj2+EBqMxmNQqeqh04DumouSn6ME5I3 U3wdpx/1RQdq1tNhNsX2TI9nZnUgqzLG/j00hPcxvxg0h7PK70bIRRa3YLYGRxor1Hf8 oOkJ8xt1OhuYMmIzoWLRgY9lffYAOBdfoWm11SKulLBjdCnzpeMb3O7f7w6g4msB9FqO hh+8aLkR/p1+eMsdMIJytFBCvOISWc5WKM1YERB76T3ignJwtDwOFy3BnsLvgiEOHZTN MLtA== X-Forwarded-Encrypted: i=1; AJvYcCVxeDSbH8UUY+LcRM4qhlyoLuQDNSrgcHSEpLT+pkh6yzL1lPdQfLuLLDUuSzNnart5rQN96Tw=@dpdk.org X-Gm-Message-State: AOJu0YyMguavo6etIcMqux6lLCNnCh7VxVqFNnNHFGitRJQYjuHLPVgJ 89VpCXYSdPlFKK1HBGG0Ibm1VJVa833XRv5/gOIR2IHcZxXeLe25RqcJ X-Gm-Gg: ASbGncu1oe58hXRAk+uo7pRSqtS/Ne71yHwiw/aJp9WHigCe/8OszxeoI9ShaIOBQll w8DsXh70qrZ7pKnQdq39AQjkyC/l/cEyIvmu0YY/R2eOe115kGV6Cnq63DgWyrJ/p/E5+6lnJr/ sfkYfRkU4DSsczTa4j7ZgyxS5R2Mwij2/XUKME7jE72xRAzWtX30F3mK28eOHQTaPW/SYrm8xXU IFTHjHdu/X+P50hEanSuYmRbrUApHpBcbU1AYYP1tEyX8/zRFYFu5K9L4LfEmIeHSjpTnTTjP2c 0NyuH/fgW+C23zJdZ+GwBg39lNxXOrYT1pGo1nXvVxePS1n9+yL80oS2e4nfrSiuk5al X-Google-Smtp-Source: AGHT+IH1wUJbOhcA4oK46eORIHnaB9WvSCizDbew4UW2oFNqS5cVSV3NufOFZvj9Yx6fRw+QA7sfLQ== X-Received: by 2002:a05:6000:26d3:b0:3a4:f2aa:2e32 with SMTP id ffacd0b85a97d-3a5687085bdmr630400f8f.44.1749762662902; Thu, 12 Jun 2025 14:11:02 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:f2df:571a:ae4c:bef2]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a568b089c2sm375173f8f.59.2025.06.12.14.11.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 14:11:02 -0700 (PDT) From: luca.boccassi@gmail.com To: David Marchand Cc: Anatoly Burakov , dpdk stable Subject: patch 'eal: warn if no lcore is available' has been queued to stable release 22.11.9 Date: Thu, 12 Jun 2025 22:07:18 +0100 Message-ID: <20250612210733.2506558-61-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250612210733.2506558-1-luca.boccassi@gmail.com> References: <20250612210733.2506558-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/2109b0ee034637cda55febebfdeb5c66ee4f060b Thanks. Luca Boccassi --- >From 2109b0ee034637cda55febebfdeb5c66ee4f060b Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 8 May 2025 07:19:15 +0200 Subject: [PATCH] eal: warn if no lcore is available [ upstream commit 2ea1d30dc938866a983156473579d10bddb4951e ] On systems with more cpu than RTE_MAX_LCORE, starting DPDK with cores >= RTE_MAX_LCORE ends up with an ambiguous error log. Example with RTE_MAX_LCORE=8: $ taskset -c 8 ./build/app/dpdk-testpmd EAL: Detected CPU lcores: 8 EAL: Detected NUMA nodes: 1 EAL: Invalid 'command line' arguments. EAL: Error - exiting with code: 1 Cannot init EAL: Invalid argument Add a better hint to help the user. Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection") Signed-off-by: David Marchand Acked-by: Anatoly Burakov --- lib/eal/common/eal_common_options.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c index 5312d03552..828fa2698b 100644 --- a/lib/eal/common/eal_common_options.c +++ b/lib/eal/common/eal_common_options.c @@ -2026,6 +2026,11 @@ eal_adjust_config(struct internal_config *internal_cfg) if (!core_parsed) eal_auto_detect_cores(cfg); + if (cfg->lcore_count == 0) { + RTE_LOG(ERR, EAL, "No detected lcore is enabled, please check the core list\n"); + return -1; + } + if (internal_conf->process_type == RTE_PROC_AUTO) internal_conf->process_type = eal_proc_type_detect(); -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-12 22:06:26.087751729 +0100 +++ 0061-eal-warn-if-no-lcore-is-available.patch 2025-06-12 22:06:23.890045060 +0100 @@ -1 +1 @@ -From 2ea1d30dc938866a983156473579d10bddb4951e Mon Sep 17 00:00:00 2001 +From 2109b0ee034637cda55febebfdeb5c66ee4f060b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2ea1d30dc938866a983156473579d10bddb4951e ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org @@ -29 +30 @@ -index b6fff7ec05..b194d0ee06 100644 +index 5312d03552..828fa2698b 100644 @@ -32 +33 @@ -@@ -2052,6 +2052,11 @@ eal_adjust_config(struct internal_config *internal_cfg) +@@ -2026,6 +2026,11 @@ eal_adjust_config(struct internal_config *internal_cfg) @@ -37 +38 @@ -+ EAL_LOG(ERR, "No detected lcore is enabled, please check the core list"); ++ RTE_LOG(ERR, EAL, "No detected lcore is enabled, please check the core list\n");