From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9D71468E4 for ; Thu, 12 Jun 2025 23:11:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D53EA42E5E; Thu, 12 Jun 2025 23:11:05 +0200 (CEST) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mails.dpdk.org (Postfix) with ESMTP id 7B2AC42E0C for ; Thu, 12 Jun 2025 23:11:04 +0200 (CEST) Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3a531fcaa05so836535f8f.3 for ; Thu, 12 Jun 2025 14:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749762664; x=1750367464; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zLqTd+j3O+SFNKKkEJwHSrGGE348boyFjH4qcBwV0kY=; b=E/Cw8wBDpAPpwaNk/W1nDXGFu9KXrI1arLi6NrwyeqpzwP7a+K2VfYGjB77j/UMGAn 5xHhV74q7ZSSRfvhqJ4A6LY1K5LJzMBVjsO9t5U3V2WPAi5GS4qRiLBfPS357XZ2Bxqm iVcDYbtRsV4gSzav7eF6eW740Rc6eLeas0tfUYNn/zLS7l+MKloGAk626oZBxZzWWho6 k+IP+7IzzWe7drcmOiMwHe3diHMbP+EsYOxyQkOstkybzsG4w2Utfi+DbC0zhimGnwCg 1puJovi7JdYZi47ZpTSIKwTi5aX5b00BC69HRYi1ZSsPsvJEk5djGgN7A1vBwlw+nv3R og1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749762664; x=1750367464; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zLqTd+j3O+SFNKKkEJwHSrGGE348boyFjH4qcBwV0kY=; b=Hs0Q9zk9ekzy3kFHpoSwlMPZApTP6zzCbFosz5jFhSf0wrmo6dFGtlfNtdSp7SM3ix DphcqEPY0fviZXS/S314ez/zHOJ2EeFeF9OIUwrSanrigNle2i0642uFDiByMNVorqlT VaK8HewH7uhSmiue2uz31XlmCkrbmeVeTa5y+cobwpyhKWg/Vgrnuiwsal9fP6yS7805 8QH2/vIo6KgubWpYfMEx6ToquhMt6Yhry5l/nE5pecsPsBCKnaN6V3iGj0/hYhXwnOgs e/b/g9g2PfDm9QuCq/Pl2WjAxaBwGEHKQojKeqQpg1xHO79jiTml3kEKYTcrukkM/yr7 C6zw== X-Forwarded-Encrypted: i=1; AJvYcCWthzQrbgM5dSqT2Z3yuUPvIhGzdRz1+apE3761Iq6SEL9g7X1HVtuGEix8qvFxj/RleO6ihBw=@dpdk.org X-Gm-Message-State: AOJu0Yz/FDDEtX51zBfBOFDdayjPrajH3Q96ioxCWSsv5TikbSfwvVrK spUDHDYfBNaTKdM/P90HldFpsqVhlz9EBLsAYUM8Z8iIk/BHbwkZbxGc X-Gm-Gg: ASbGncsfk36YywmM/SzaqX+ZMXTmwKIUtBlZz/jlnfdyCHAPSgO7STlgIWyfkM5veA7 /ZHXN7MLXwWAcrvK5o2kHGUa2VV3e+yeWzStZBHvYuneVeVtUbUZwZJYwGly1js1br48V46MEXP nNNTtkXNkkMVWsVk/27Rlp+0q7kOR50hmKwlq9Y0CbTJJQo4JUU47IXoP1wj1mAJqv5gtHnqXZ0 xigdMS1doIR40X8H5vzIgPjvHQtBCeTmyJOyfhHdygtN5tI/FXMVdOVf8rRecTGhYvE4f24+/RI Gb8pemMI4CZTxT/YnrBWjtS5HmsJ+p+N8ECWmvSnb30NxiaoISGn+fJ4OcM+4/quHZNY X-Google-Smtp-Source: AGHT+IG31jBfvfPX4gnsrZVayGt88czgt1MRsEX1FJ/gYNP1nl7M6VUrEsKDrKvQEKmf2v/PmpjTRw== X-Received: by 2002:a05:6000:230e:b0:3a5:276b:1ec0 with SMTP id ffacd0b85a97d-3a56870835emr573647f8f.45.1749762663941; Thu, 12 Jun 2025 14:11:03 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:f2df:571a:ae4c:bef2]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a568b08a2bsm378845f8f.62.2025.06.12.14.11.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 14:11:03 -0700 (PDT) From: luca.boccassi@gmail.com To: Chengwen Feng Cc: =?UTF-8?q?Morten=20Br=C3=B8rup?= , dpdk stable Subject: patch 'bus: cleanup device lists' has been queued to stable release 22.11.9 Date: Thu, 12 Jun 2025 22:07:19 +0100 Message-ID: <20250612210733.2506558-62-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250612210733.2506558-1-luca.boccassi@gmail.com> References: <20250612210733.2506558-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/a025a6346bc564be08c5314cbd63242156af512c Thanks. Luca Boccassi --- >From a025a6346bc564be08c5314cbd63242156af512c Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 20 Feb 2025 16:09:06 +0800 Subject: [PATCH] bus: cleanup device lists MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 398bb775edc5434ad94578a5e6c49fa1328acc0f ] Although eal_bus_cleanup() is not invoked for multiple times, this is a good programming habit to remove the device object from list when cleanup bus. Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") Fixes: 62b906cf06ba ("bus/uacce: introduce UACCE bus") Fixes: 65780eada9d9 ("bus/vmbus: support cleanup") Signed-off-by: Chengwen Feng Acked-by: Morten Brørup --- drivers/bus/pci/pci_common.c | 1 + drivers/bus/vdev/vdev.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 465f9258af..4c1c09843c 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -455,6 +455,7 @@ free: rte_intr_instance_free(dev->vfio_req_intr_handle); dev->vfio_req_intr_handle = NULL; + TAILQ_REMOVE(&rte_pci_bus.device_list, dev, next); pci_free(dev); } diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index ec7abe7cda..ae79cfd049 100644 --- a/drivers/bus/vdev/vdev.c +++ b/drivers/bus/vdev/vdev.c @@ -596,6 +596,7 @@ vdev_cleanup(void) dev->device.driver = NULL; free: + TAILQ_REMOVE(&vdev_device_list, dev, next); free(dev); } -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-12 22:06:26.121495826 +0100 +++ 0062-bus-cleanup-device-lists.patch 2025-06-12 22:06:23.890045060 +0100 @@ -1 +1 @@ -From 398bb775edc5434ad94578a5e6c49fa1328acc0f Mon Sep 17 00:00:00 2001 +From a025a6346bc564be08c5314cbd63242156af512c Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 398bb775edc5434ad94578a5e6c49fa1328acc0f ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -21,5 +22,3 @@ - drivers/bus/pci/pci_common.c | 1 + - drivers/bus/uacce/uacce.c | 1 + - drivers/bus/vdev/vdev.c | 1 + - drivers/bus/vmbus/vmbus_common.c | 1 + - 4 files changed, 4 insertions(+) + drivers/bus/pci/pci_common.c | 1 + + drivers/bus/vdev/vdev.c | 1 + + 2 files changed, 2 insertions(+) @@ -28 +27 @@ -index 5df4086f31..c88634f790 100644 +index 465f9258af..4c1c09843c 100644 @@ -31 +30 @@ -@@ -451,6 +451,7 @@ free: +@@ -455,6 +455,7 @@ free: @@ -36 +35 @@ - pci_free(RTE_PCI_DEVICE_INTERNAL(dev)); + pci_free(dev); @@ -39,12 +37,0 @@ -diff --git a/drivers/bus/uacce/uacce.c b/drivers/bus/uacce/uacce.c -index 9b8ac23952..f5343ed87a 100644 ---- a/drivers/bus/uacce/uacce.c -+++ b/drivers/bus/uacce/uacce.c -@@ -455,6 +455,7 @@ uacce_cleanup(void) - dev->device.driver = NULL; - - free: -+ TAILQ_REMOVE(&uacce_bus.device_list, dev, next); - memset(dev, 0, sizeof(*dev)); - free(dev); - } @@ -52 +39 @@ -index beee8c4033..be375f63dc 100644 +index ec7abe7cda..ae79cfd049 100644 @@ -55 +42 @@ -@@ -603,6 +603,7 @@ vdev_cleanup(void) +@@ -596,6 +596,7 @@ vdev_cleanup(void) @@ -60,12 +46,0 @@ - free(dev); - } - -diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c -index ac04ee11f8..a787d8b18d 100644 ---- a/drivers/bus/vmbus/vmbus_common.c -+++ b/drivers/bus/vmbus/vmbus_common.c -@@ -240,6 +240,7 @@ rte_vmbus_cleanup(void) - - dev->driver = NULL; - dev->device.driver = NULL; -+ TAILQ_REMOVE(&rte_vmbus_bus.device_list, dev, next);