From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C25D468E4 for ; Thu, 12 Jun 2025 23:11:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7786442E0C; Thu, 12 Jun 2025 23:11:25 +0200 (CEST) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mails.dpdk.org (Postfix) with ESMTP id 317A842E5E for ; Thu, 12 Jun 2025 23:11:24 +0200 (CEST) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-45310223677so12398635e9.0 for ; Thu, 12 Jun 2025 14:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749762684; x=1750367484; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TR47kuOOiYPCpWoA1Ea6qkkmjyoyiYOz6OMrRy4bgKY=; b=YXygPg+tQSSAUSFZjqjbK9CkqEApMZub/aDEY81Eptr6r7YzsJXsrYzjyZJojzz97B hfYMvzesZDQmTYTYfkSpiqKIcz+sdVLtc/5Ibl/1EfRljMr9tNQTwLnf3NHM7CTzraDz VT87yEjeQ4cQdCOYZZaU4S6/Sj43WLg4v7EXeD0jp5SiT07mBpigg8lVYMKSMvNqKgae 5qIXDnZkLH9L0iIb0OZKn3qVHZnJm7dgWL7bBEquBAfI0ldiXkx7nLPJWy0sVOdAM9/K sZix4FN2DIYPihjOSkRrSfBJz8/zNGaCmurZLS53f7rkPFbGGV5Qgstq/JZZ6L9bJgS/ WtYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749762684; x=1750367484; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TR47kuOOiYPCpWoA1Ea6qkkmjyoyiYOz6OMrRy4bgKY=; b=W/GUfcGM8ufwug40A55dEdqcaPAcNOS/NTUt8WEhNg3XJxeBocmuqm72gKo8ZQc2V+ yytYR+JrexnB6aiPU1SYCBe5BwOxkTZdzhGtHoyBgw9v+g/RI9SgKdItOavhFga78o04 oWnXx3HFoyk2MM3IyQf5Xgtyu/NtmLodYpg8CUgJj1SUljI8fSZS6GQocS0T+D20vpIN suM5LNWRD9bAC5D0jE8UjKUIdEa9b9+DXh9vbmXnT2ETp1+88YaKOpDyqMMbJ6wzLMQh SUgNnwtBlbvyr2rdHxP4swkFPscSkgFnYCanwSEGOnhMasi2BozRfA5ypVPZVVC3qo+4 k1gg== X-Forwarded-Encrypted: i=1; AJvYcCWZnv6keH/6OLcZlliise/280ZTCOIlXylfKpFLmuKYtttL0O/2NshjXdSaIW5AiVpsD8NALcU=@dpdk.org X-Gm-Message-State: AOJu0Yy442eQlucXSKWvK/RySDyx3sMuNLpr3t76DUhp0+UTpQMmntf7 hP0ozIA01Omm5xiquGJ9P3K663bAbndNK6SNeNatMxJWb7HJD0koHN8p X-Gm-Gg: ASbGncuYwGiQoGi3mdzmSf0e3q2dzGxXq04Z0rW6rZRCj3sLmTqn6HW5AwWjFIxAG9y dDv0WHCAKT9IlqH9qJqC5pXkbilLHbYcXrh2mlRezJTfJG5MczPq0ZJDSFxq49SdgUWTP3bDx6X 8LMzIZU0NxdcFvH8j+1Khx9yWaVNSqZPLN+fUpQvk0e2Io/A/vIWxtTxKO+X6eUjzFTv1CIwSJy LH7S8jTgDeZo/WJkydLziH9tZ9lJVH7nVM31CFLOkeBiDkXaEugLdomeuUTIKa+Bok9Sf6Fr2as diP5IyevUQxzKp1rzXV6SGpsfuJsJnRQNARlXbGlGZFYFiqmIP1QSO56Qtbkx1Hi0pxuohlAa8B 0H/I= X-Google-Smtp-Source: AGHT+IGInB1OCdDtDlQADPCgBSn2v6GdRJ57xxC+4r8K+iaNlwmqtwcMcjHHs2IokAz2sO57szgoPg== X-Received: by 2002:a05:600c:4e86:b0:441:ac58:eb31 with SMTP id 5b1f17b1804b1-45334b1951emr4690305e9.20.1749762683611; Thu, 12 Jun 2025 14:11:23 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:f2df:571a:ae4c:bef2]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4532de8c50esm32020415e9.4.2025.06.12.14.11.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 14:11:22 -0700 (PDT) From: luca.boccassi@gmail.com To: Maxime Coquelin Cc: Dariusz Sosnowski , dpdk stable Subject: patch 'net/mlx5: avoid setting kernel MTU if not needed' has been queued to stable release 22.11.9 Date: Thu, 12 Jun 2025 22:07:25 +0100 Message-ID: <20250612210733.2506558-68-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250612210733.2506558-1-luca.boccassi@gmail.com> References: <20250612210733.2506558-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/0ccb9e319ea392ae075e5ab646264c28eeeed16c Thanks. Luca Boccassi --- >From 0ccb9e319ea392ae075e5ab646264c28eeeed16c Mon Sep 17 00:00:00 2001 From: Maxime Coquelin Date: Wed, 28 May 2025 11:36:44 +0200 Subject: [PATCH] net/mlx5: avoid setting kernel MTU if not needed [ upstream commit f1f9113a08b202d302ba9448d351c04da48ff46d ] This patch checks whether the Kernel MTU has the same value as the requested one at port configuration time, and skip setting it if it is the same. Doing this, we can avoid the application to require NET_ADMIN capability, as in v23.11. Fixes: 10859ecf09c4 ("net/mlx5: fix MTU configuration") Signed-off-by: Maxime Coquelin Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_ethdev.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 169612ca44..f998e2ace9 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -634,6 +634,14 @@ mlx5_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) ret = mlx5_get_mtu(dev, &kern_mtu); if (ret) return ret; + + if (kern_mtu == mtu) { + priv->mtu = mtu; + DRV_LOG(DEBUG, "port %u adapter MTU was already set to %u", + dev->data->port_id, mtu); + return 0; + } + /* Set kernel interface MTU first. */ ret = mlx5_set_mtu(dev, mtu); if (ret) -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-12 22:06:26.319542047 +0100 +++ 0068-net-mlx5-avoid-setting-kernel-MTU-if-not-needed.patch 2025-06-12 22:06:23.894045145 +0100 @@ -1 +1 @@ -From f1f9113a08b202d302ba9448d351c04da48ff46d Mon Sep 17 00:00:00 2001 +From 0ccb9e319ea392ae075e5ab646264c28eeeed16c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f1f9113a08b202d302ba9448d351c04da48ff46d ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index a50320075c..b7df39ace9 100644 +index 169612ca44..f998e2ace9 100644 @@ -26 +27 @@ -@@ -678,6 +678,14 @@ mlx5_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) +@@ -634,6 +634,14 @@ mlx5_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)