From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9E24468E4 for ; Thu, 12 Jun 2025 23:11:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A57C342E5F; Thu, 12 Jun 2025 23:11:28 +0200 (CEST) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mails.dpdk.org (Postfix) with ESMTP id 97CE842E5C for ; Thu, 12 Jun 2025 23:11:26 +0200 (CEST) Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3a507e88b0aso1513199f8f.1 for ; Thu, 12 Jun 2025 14:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749762686; x=1750367486; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Kd4BaYXyRShJAoliZaqQHjksmXZb8KgmLMaYvqv0qIQ=; b=KObZBnh76bOsRVhzOBVAyS+GGBm7KITJ+thspzBuj9xwe+G8afJu8wjAN5hXeNcCQm QaSGbQZBvwFt/RBpBKnXdkWqzxAmF3m4g1N2w/EXzY4wrXG3+Ii0ghfy1Z5l46yCA2WK wDHne5j4zRsZ37/U1Yo71cOqeVvPGpPJDqtId1OpMYgvVdTvluivnYYxTHiAZlQZabYM dt8Xs1o1u8+tNEwzyVCdYXp0MTa3/NM8UIcOau4UmB9LXhHnlQXwcs14dgBTIb8Cndg1 1buyQUvN6WpE03UVHq0I9PEZit0yFeDOFGHcZmer2NPF0Yq1yJjahOgy6CXiq75/ZwBS /Bhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749762686; x=1750367486; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kd4BaYXyRShJAoliZaqQHjksmXZb8KgmLMaYvqv0qIQ=; b=CRTVbchPigahz1jMe5qU90K5SCwkd6C3HFY3eq0m9DzqPGkTuxmDBi3g7+QHTo6e8R Op8OTEo23QfVBxcDQNo+JIomjfHXFZ34aOUE8nFyidabVSct4YkgccPVKUuJka+eCTdn pV8+YhoB77GQsXJKD4xhCI4faXWelNKla2Oroc+04CXhyIDdoUrKnKz6TVzeQHSSVuiX J5e1jU0h73/athwLIYV9Q5NlzynpqYgwOhoaAnvGh48LIwcTJqzvZK/0+NHotuIZvpFK b4YrURo5yWNjRMrlfGbX7Py1Srske4vxWL+VL9Fk2NXUJ7iamhmR0ESOFYr2RBD94Lbu Rw8A== X-Gm-Message-State: AOJu0YxdaSj9aXlSYfLCFcZoBeHcC7P60YcWRiixDM8F6YDZOZfY5Lty LfaGICzOqfJQZyzBppKd7ra1NpY67RZDOClgD+KHsEGBuoAoiSdxsC2/ X-Gm-Gg: ASbGnctG7250pzoF+Vsz/Lf/inpou+/zUgTD3h05En2PyNfGBupWCd4Xmwx67G5PlYM kRtiqmDiVNX/TL8k3tkQNeLTS0I2fz1celaXO7SZTxCpj1nw4vaCGYE+5aDwHmxg6kS7VEWDjPV Rbh9ABYJKkg9C3pyE1b+zQoCMWSJpeqbxQavBXUuC1998TAQZrXWvRmV3FbKLrzzLrm4hpi6umq l+NtMQs59bmBRqrn16+UD+4Gdk2p77DozFaa6FT9BAetDInu4zBXQu4rIKREehVIIz0EpHnFLfS kzj9ENM2sj5UbQoypLTAfKAxCIJoS0lBhNfStqooxiFazPzAvErl4GSVjKnM9hCsDAjQ X-Google-Smtp-Source: AGHT+IGbE7VoMbUCip2dQe4t9Y+gNZJr856qX+beixqLa66rVkruBCdFEf7QCPxKNbMj6R8H1CH1BQ== X-Received: by 2002:a05:6000:2087:b0:3a4:de02:208 with SMTP id ffacd0b85a97d-3a56871724amr595745f8f.25.1749762686111; Thu, 12 Jun 2025 14:11:26 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:f2df:571a:ae4c:bef2]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a568a6389esm398139f8f.27.2025.06.12.14.11.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 14:11:25 -0700 (PDT) From: luca.boccassi@gmail.com To: Dengdui Huang Cc: dpdk stable Subject: patch 'net/hns3: check requirement for hardware GRO' has been queued to stable release 22.11.9 Date: Thu, 12 Jun 2025 22:07:27 +0100 Message-ID: <20250612210733.2506558-70-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250612210733.2506558-1-luca.boccassi@gmail.com> References: <20250612210733.2506558-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/1f2d5af25220d38a45926840e7d8e49dd9f234cc Thanks. Luca Boccassi --- >From 1f2d5af25220d38a45926840e7d8e49dd9f234cc Mon Sep 17 00:00:00 2001 From: Dengdui Huang Date: Mon, 9 Jun 2025 21:06:49 +0800 Subject: [PATCH] net/hns3: check requirement for hardware GRO [ upstream commit ae68b5d91c632a1dde839123f27b0317cf094170 ] The HIP08 platform requires that data address be 64-byte aligned for the GRO feature. Most applications already use 64-byte aligned. So a check is added to avoid using the GRO function when 64-byte aligned is used. Fixes: d14c995b775a ("net/hns3: check Rx DMA address alignmnent") Signed-off-by: Dengdui Huang --- drivers/net/hns3/hns3_rxtx.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index b9ae838642..83837e5c9a 100644 --- a/drivers/net/hns3/hns3_rxtx.c +++ b/drivers/net/hns3/hns3_rxtx.c @@ -276,12 +276,25 @@ hns3_free_all_queues(struct rte_eth_dev *dev) static int hns3_check_rx_dma_addr(struct hns3_hw *hw, uint64_t dma_addr) { + uint64_t rx_offload = hw->data->dev_conf.rxmode.offloads; uint64_t rem; rem = dma_addr & (hw->rx_dma_addr_align - 1); if (rem > 0) { - hns3_err(hw, "The IO address of the beginning of the mbuf data " - "must be %u-byte aligned", hw->rx_dma_addr_align); + hns3_err(hw, + "mbuf DMA address must be %u-byte aligned", + hw->rx_dma_addr_align); + return -EINVAL; + } + + /* + * This check is for HIP08 network engine. The GRO function + * requires that mbuf DMA address is 64-byte aligned. + */ + rem = dma_addr & (HNS3_RX_DMA_ADDR_ALIGN_128 - 1); + if ((rx_offload & RTE_ETH_RX_OFFLOAD_TCP_LRO) && rem > 0) { + hns3_err(hw, + "GRO requires that mbuf DMA address be 64-byte aligned"); return -EINVAL; } return 0; -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-12 22:06:26.385080793 +0100 +++ 0070-net-hns3-check-requirement-for-hardware-GRO.patch 2025-06-12 22:06:23.898045229 +0100 @@ -1 +1 @@ -From ae68b5d91c632a1dde839123f27b0317cf094170 Mon Sep 17 00:00:00 2001 +From 1f2d5af25220d38a45926840e7d8e49dd9f234cc Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ae68b5d91c632a1dde839123f27b0317cf094170 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index bde46733b0..f9fde3948a 100644 +index b9ae838642..83837e5c9a 100644 @@ -24 +25 @@ -@@ -281,12 +281,25 @@ hns3_free_all_queues(struct rte_eth_dev *dev) +@@ -276,12 +276,25 @@ hns3_free_all_queues(struct rte_eth_dev *dev)