Re: [PATCH v2 1/5] net/zxdh: fix meson.build issus in compilation

Re: [PATCH v2 1/5] net/zxdh: fix meson.build issus in compilation

[Stephen Hemminger]

On Tue, 17 Jun 2025 10:04:59 +0800
Junlong Wang <wang.junlong1@zte.com.cn> wrote:

> fix meson.build issus in compilation, which
> caused the inability to compile in the arm64 environment.
> 
> Fixes: 29e89288ff14 ("net/zxdh: add driver skeleton")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Junlong Wang <wang.junlong1@zte.com.cn>

Typo in commit subject. I can fix that during merge.s/issus/issues/

Re: [PATCH v2 1/5] net/zxdh: fix meson.build issus in compilation

[Stephen Hemminger]

On Tue, 17 Jun 2025 10:04:59 +0800
Junlong Wang <wang.junlong1@zte.com.cn> wrote:

> fix meson.build issus in compilation, which
> caused the inability to compile in the arm64 environment.
> 
> Fixes: 29e89288ff14 ("net/zxdh: add driver skeleton")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Junlong Wang <wang.junlong1@zte.com.cn>
> ---

This series looks much better but please revise the commit message (again).
To help with stable (and user reports) it is better to include more
precise wording of what the problem is. It is clearer if you use the
word "fix" instead of "modify". Also, describe what the bug is.
This applies to several of these patches.
If it is a bug fix it could be marked for stable. Although this driver
is new and experimental so won't get backported.

Instead of:

Subject: net/zxdh: modify some MAC config issues

modify some mac config issues,
which were discovered during the testing process.

Fixes: 1c8f68b64cfc ("net/zxdh: optimize MAC operations")

Signed-off-by: Junlong Wang <wang.junlong1@zte.com.cn>


Something like:

Subject: net/zxdh: fix issues related to MAC configuration

Fix error handling when MAC configuration fails.
This is issue was discovered during internal testing.

Fixes: 1c8f68b64cfc ("net/zxdh: optimize MAC operations")
Cc: stable@dpdk.org

Signed-off-by: Junlong Wang <wang.junlong1@zte.com.cn>