From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D212469D9 for ; Tue, 17 Jun 2025 17:20:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6200441144; Tue, 17 Jun 2025 17:20:12 +0200 (CEST) Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by mails.dpdk.org (Postfix) with ESMTP id 4A665402C5 for ; Tue, 17 Jun 2025 17:20:09 +0200 (CEST) Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7d3dd14a7edso225595585a.2 for ; Tue, 17 Jun 2025 08:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1750173608; x=1750778408; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=1zVC3+ndJepJb9H4NjYgzvYv7P6mHlwKV6J4zQZPV6c=; b=bOgvfoKzmuO6DSpN7073hTesza0eHhtGK5oVj+ZSVwc3jeOmxM98Fj62uG8kQblaaj HVfl5k31/AaOY0C+kVELAbxpvK2LkfFTZb5rowPP7ftf31NxzL7ssgM5bgJ5c0fuqlNM vbX44TjYIQd5khd7FOQi/Mk9J2OUIgejfEaBWZoDgV+t0d3Td+1K0ZvfRd2aIXglABo0 Eml0NvUxxYSd/IJgTtTTZO1f830PYv7wIveTO/GxTV4y/v2A7xY5SBtpHMBLetswoniy Jg3rb5MKEHxeOriLaXLFx6JxRwZZ5FNGq/YYZc0rdLbDPKskwRfQM1rx/J3qaUihyFUv H3hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750173608; x=1750778408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1zVC3+ndJepJb9H4NjYgzvYv7P6mHlwKV6J4zQZPV6c=; b=TN3Y6bkboNS0g09sIsctXF2UQ5UdywzYKXpxczXxTp9uxTJxmtvUI1Uf9SOyYTdPJ6 ADPeVjcr9gFEMz5pfIwL3lXZ1DG4TQHSusCMu3UIjrbbpkzi0tqqpUH3uGxfhZo+K5it Q59o2fbJCQk1bcLP63NXZFbklW2aT4vk4OyYGbh8FCZKGXQ2+lgY7G139U6vKB8C85oN v7qPRU7sIAR9yNfDptvtA7zcXaRqNM+zXJ/IiFUCLELBWgxPIN0X6CqLi9O52FaBPIbH RCWO7rylwy4Gyh8b4AE8kBYP34KNYYnMWnavZrPrF3wqwplpi3mAKJFncadTexhaBqcL WHtA== X-Forwarded-Encrypted: i=1; AJvYcCUyx+q9qhgjL9Fa/xkvcBnnuQl7AFH+Tq2yqZD5e0nq53VE6FrUVFdLyV/9GP4EsCCqBZjdMcc=@dpdk.org X-Gm-Message-State: AOJu0Yw67PhhRFkTqDpG6SS9ANbp/nOYrXNFUN6di4sWHYRSrlwlmD8P CItnvyFe3dWLqy0mNuZYXAYpxC8nyJ4MVDwcO0D7TkW2k5I3Kl4ouZhMKRp4zmCiGIk= X-Gm-Gg: ASbGnctZJlJvvhS1w6fV89fOvDfW/Zf3jUuAwzI72lSqd0ggmXzSPwSnBt1qRai/qiy wKBC5jqUOmYfZc6RZR62xLveIZtiMO/v1lqnt5exPr0EVLKQZf6PKL0/8Lk0PZV+B24rnXhPpzA AqkFAb6RZWk3I1UJDKv77xHLTtHvBblYVcZNrLsBnUEdglL+zYLgA7pIqAxAXfL+Wd5Sj3yZSX6 7HwaP0jsJdLNVYVp+EEAHNT29gmVvga8IUry57Pv32LKUYKANhIAHUFSCFGNyvN/X7bRNsAWBG8 4/18qANJASfGzLb/nH6V8ljO/BrLXTKsBLSnkTLPhgxcYO8hrXwmTu32YXC7+z6uJogX2AClgAz 6ka9FCe0g8H8CIAxQDdpKDOYyiiqZE/bBHeVDNGM= X-Google-Smtp-Source: AGHT+IFd3/JrRH8dZY5ZHCiVvFr3t6iwqmbahq8ozBF5CDtgPMBq1I+zuclueM03lV6NJxxSkcPZXw== X-Received: by 2002:a05:620a:44d0:b0:7d3:90ab:804 with SMTP id af79cd13be357-7d3c6d124eemr2212782085a.58.1750173608552; Tue, 17 Jun 2025 08:20:08 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d3b8eacbc7sm658702985a.62.2025.06.17.08.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 08:20:08 -0700 (PDT) Date: Tue, 17 Jun 2025 08:20:05 -0700 From: Stephen Hemminger To: Junlong Wang Cc: dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH v2 1/5] net/zxdh: fix meson.build issus in compilation Message-ID: <20250617082005.2977069a@hermes.local> In-Reply-To: <20250617020503.3554511-1-wang.junlong1@zte.com.cn> References: <20250607023020.3051575-1-wang.junlong1@zte.com.cn> <20250617020503.3554511-1-wang.junlong1@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, 17 Jun 2025 10:04:59 +0800 Junlong Wang wrote: > fix meson.build issus in compilation, which > caused the inability to compile in the arm64 environment. > > Fixes: 29e89288ff14 ("net/zxdh: add driver skeleton") > Cc: stable@dpdk.org > > Signed-off-by: Junlong Wang > --- This series looks much better but please revise the commit message (again). To help with stable (and user reports) it is better to include more precise wording of what the problem is. It is clearer if you use the word "fix" instead of "modify". Also, describe what the bug is. This applies to several of these patches. If it is a bug fix it could be marked for stable. Although this driver is new and experimental so won't get backported. Instead of: Subject: net/zxdh: modify some MAC config issues modify some mac config issues, which were discovered during the testing process. Fixes: 1c8f68b64cfc ("net/zxdh: optimize MAC operations") Signed-off-by: Junlong Wang Something like: Subject: net/zxdh: fix issues related to MAC configuration Fix error handling when MAC configuration fails. This is issue was discovered during internal testing. Fixes: 1c8f68b64cfc ("net/zxdh: optimize MAC operations") Cc: stable@dpdk.org Signed-off-by: Junlong Wang