* Re: [PATCH v2 1/5] net/zxdh: fix meson.build issus in compilation
[not found] ` <20250617020503.3554511-1-wang.junlong1@zte.com.cn>
@ 2025-06-17 14:01 ` Stephen Hemminger
2025-06-17 15:20 ` Stephen Hemminger
1 sibling, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2025-06-17 14:01 UTC (permalink / raw)
To: Junlong Wang; +Cc: dev, stable
On Tue, 17 Jun 2025 10:04:59 +0800
Junlong Wang <wang.junlong1@zte.com.cn> wrote:
> fix meson.build issus in compilation, which
> caused the inability to compile in the arm64 environment.
>
> Fixes: 29e89288ff14 ("net/zxdh: add driver skeleton")
> Cc: stable@dpdk.org
>
> Signed-off-by: Junlong Wang <wang.junlong1@zte.com.cn>
Typo in commit subject. I can fix that during merge.s/issus/issues/
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2 1/5] net/zxdh: fix meson.build issus in compilation
[not found] ` <20250617020503.3554511-1-wang.junlong1@zte.com.cn>
2025-06-17 14:01 ` [PATCH v2 1/5] net/zxdh: fix meson.build issus in compilation Stephen Hemminger
@ 2025-06-17 15:20 ` Stephen Hemminger
1 sibling, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2025-06-17 15:20 UTC (permalink / raw)
To: Junlong Wang; +Cc: dev, stable
On Tue, 17 Jun 2025 10:04:59 +0800
Junlong Wang <wang.junlong1@zte.com.cn> wrote:
> fix meson.build issus in compilation, which
> caused the inability to compile in the arm64 environment.
>
> Fixes: 29e89288ff14 ("net/zxdh: add driver skeleton")
> Cc: stable@dpdk.org
>
> Signed-off-by: Junlong Wang <wang.junlong1@zte.com.cn>
> ---
This series looks much better but please revise the commit message (again).
To help with stable (and user reports) it is better to include more
precise wording of what the problem is. It is clearer if you use the
word "fix" instead of "modify". Also, describe what the bug is.
This applies to several of these patches.
If it is a bug fix it could be marked for stable. Although this driver
is new and experimental so won't get backported.
Instead of:
Subject: net/zxdh: modify some MAC config issues
modify some mac config issues,
which were discovered during the testing process.
Fixes: 1c8f68b64cfc ("net/zxdh: optimize MAC operations")
Signed-off-by: Junlong Wang <wang.junlong1@zte.com.cn>
Something like:
Subject: net/zxdh: fix issues related to MAC configuration
Fix error handling when MAC configuration fails.
This is issue was discovered during internal testing.
Fixes: 1c8f68b64cfc ("net/zxdh: optimize MAC operations")
Cc: stable@dpdk.org
Signed-off-by: Junlong Wang <wang.junlong1@zte.com.cn>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-17 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20250607023020.3051575-1-wang.junlong1@zte.com.cn>
[not found] ` <20250617020503.3554511-1-wang.junlong1@zte.com.cn>
2025-06-17 14:01 ` [PATCH v2 1/5] net/zxdh: fix meson.build issus in compilation Stephen Hemminger
2025-06-17 15:20 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).