From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB85346A63 for ; Thu, 26 Jun 2025 14:03:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6BD9402A8; Thu, 26 Jun 2025 14:03:21 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2054.outbound.protection.outlook.com [40.107.243.54]) by mails.dpdk.org (Postfix) with ESMTP id 7D43A4028D for ; Thu, 26 Jun 2025 14:03:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZdqhkCv/kEaoNSTcrc5qsRPebIAnzQvMHZi1cHQdE/wq09xbKAgFyj2YYXOoZFKwVRBXtcuUUDPjZUNqvsyhiSovjMZspEr0dkazE1B87XY6f7a4YkGPR6rzvuSxeG+OI4pQxyBUXpwp1EfPjxP4wri0RWRP0v7rDy95jFq7hczzv7dyl1xDyulY8/HibFAhJjVLSSqWsARU7GBCT41bcU/d1DLXTqqFQLIszWV/2k0ZISQmB7ziuyti7PELig4i6R+bGrUUsNeHQCaDrTn9xCgky1XnVrGegPDpFurAFs7YBYUVAw0369Zphk9S8BoeoYgurp/rN+0bEYu84jJuSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AL1bGFyyMh9nck2dwnCiZNlzc4wlTtd4lDVUU1yvIZc=; b=CTNy2+b0bmqUqKXKyRRADQCGnocEHfy+cniakidqXX0OhtzHo7ciRoOz5q7GHGFVyjQyyDjHkHgdU/UYd7C5gjDumvzKPTIcdudba5RjrlpLYb9F35ATk01wQvvG4d12+IU4WFnof1Cs96uLD71RwJGSf1Oiju7lJwjPmB13a/E2cpuTuZub36gf3U1IkTZPBakp2HCRTpoTy2BOqhp+aJt3ND9PwNKH9PyYVFOWyWnaamF5hLBSlg7UIW3FXFcRDfvcKFImMl0EFtZ4zWJS06VOYq1ANX6+WCtZaRkFthWJ6pdz1aFZwUTl2PKUBhLeLapKT1HTZ/2IwOB20swxTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AL1bGFyyMh9nck2dwnCiZNlzc4wlTtd4lDVUU1yvIZc=; b=nCAFdMJRMH6615Pu1XVwDoD9+8pGoKotEURirD8vAEUWdZecfqqGeeMrLFbO0+17MucnRjDDtlXKYjftUxug+4eaSNhqFHo1OGj1j65N8BEBn/ClgRXYKSsZj7XUQadg0fNmCMes3+Oa4e+MGkXNcqlR/gWUT/wsrcVXkMrsg6qfTIP8oYxeU39kh7OyKTdOUswNtyetCXjlX6zTnHnIJitKlji5DUD6/QJIaUfBxTjnn01EXwu71fcx165pIhVQoIlt/ASomadIVw+qLoJAYUky23jfST4IHneqlv40MgRgHFe/abxauX3YH4sl0AhrRN5ULMCPqBj2uKFiukpU6A== Received: from PH7PR17CA0058.namprd17.prod.outlook.com (2603:10b6:510:325::7) by MN2PR12MB4344.namprd12.prod.outlook.com (2603:10b6:208:26e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.22; Thu, 26 Jun 2025 12:03:16 +0000 Received: from CY4PEPF0000EE3E.namprd03.prod.outlook.com (2603:10b6:510:325:cafe::57) by PH7PR17CA0058.outlook.office365.com (2603:10b6:510:325::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.20 via Frontend Transport; Thu, 26 Jun 2025 12:03:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000EE3E.mail.protection.outlook.com (10.167.242.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:03:15 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:02:58 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:02:57 -0700 From: Xueming Li To: Dhanya Pillai CC: Xueming Li , Bruce Richardson , dpdk stable Subject: patch 'net/ice: fix flow creation failure' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:00:34 +0800 Message-ID: <20250626120145.27369-15-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE3E:EE_|MN2PR12MB4344:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d5c2c41-6c96-4003-1291-08ddb4a96ee4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|1800799024|36860700013|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?aAv7kn8QW5b+k3X1jwDlbB0I02enKPod6YbYIou8sDEEtKjWfvQj+Oy8pxqK?= =?us-ascii?Q?V4zlqv6kNlXQ1pmgrWTZUkdh8ks90a7Tno0UMyezStyAYgmXF/XU30+rT7vr?= =?us-ascii?Q?r4Kbbx2PhdWURjRp6qmuVJHP6x7USRGQ188YdUNoSw91JpswCnhGxtt+mNtY?= =?us-ascii?Q?PObLfN6VgJJBcmOFq0YYFqgadYDBEIROavGAC/Iqz3nRn1R9ddFSUG2EZEt8?= =?us-ascii?Q?ElZD3kZycXUqojegW7ff8rz2d4kbGoiNhP+yyN5pSzMakMswVr7dpRjBXFwQ?= =?us-ascii?Q?lKssKHkuaRHS1S+mBoVwhN66v3eurPj7le1UU+tNSfbHGHywDyxd02gxXJl8?= =?us-ascii?Q?1BnsLSkWmREt1LcU5YR0c+dLvqsG0PEcJ2PRwX6fWLUswittDDGzOwdLS0Lk?= =?us-ascii?Q?hc0+GE6TwXFMn83fQ6f8vGyrw/Lk1OVibo7Ynr+Y3rt4A/7iZ94QH6yL4n5w?= =?us-ascii?Q?H/poG4bUZaLYu6FFvUgz9oEhq5mgxmQs7Uq13XWpFBYiVfAK1SU5Kov4WTy2?= =?us-ascii?Q?gqgMXjjME8efLEo0uiyBY0CXd7A26WRMLpWbXMGpuC083UeTM/BLNzgIZn1G?= =?us-ascii?Q?UGkrQmOeezKrB9liMWQjz+RwJEsN0DIC4YNIAiBui771J0HtKZpB8Kf+cZLI?= =?us-ascii?Q?eFjbSDzaC2aqnrReP8ybMmNR+BKLAzmHSJKUo48uTF3G0PkLKCSwRv8bB6Qp?= =?us-ascii?Q?tpGhEhS8ObXIBj+ueBsvM5g5ONYQt4EkADPC+nu2d7LuD6FzfzOkGTHjCG5V?= =?us-ascii?Q?BRt+SRxmwZObNv/9vsvbP26ex/oCBzQPmmQu5imGMmthhKPL/D5E/C8pU1vp?= =?us-ascii?Q?xUBOhUDs/fFAUXv6e7m1YpW0epusspFW/FMk3jwLZsGIu+XyDl1VaYpQ4Dhw?= =?us-ascii?Q?SobzUa2L70qMYA5QIiOk+y1Yd8+2jvYADoQzjYhABccEd4I4i6sBPLMcwJqr?= =?us-ascii?Q?h3abPpFHz/FG6L01U7KSwTcZQ3Yl5y02KBcgDtlBImyEvicg/e4yagIWa4BF?= =?us-ascii?Q?m4J8sZqlPFy+UHT7uJJo44q+KXLacVkkGlekdLQHXvuTiofyf2frJhjBVyPS?= =?us-ascii?Q?3dGUMss0X1A+PxQplgBDkecGVKy4GEU+XfDBaXsI/D8Ur26/AcUZ3avvGZTe?= =?us-ascii?Q?BlleZxR9YywQMfwKhdJqvFaWpooOyllWL1hsamtP+Kn4Bfz427BmhRy1r/rK?= =?us-ascii?Q?uzXVi0oiuP82ZvN0GoPY5R9ho71klyOHbPS3i7x2P1/1AR1tKVgsb5oOMydg?= =?us-ascii?Q?yLW5KvK7Er04/ZfuRgLCVuMTEimLG4OH/JUiMZ02RIOu4uyW9W5fNnEgkuNi?= =?us-ascii?Q?XBUXEhn6L7vNFk8Jc82n93aJ8fBcnRbYK6e9pokaNqtVD1A0LjHHGoGQqrBu?= =?us-ascii?Q?/2TJqumoKNcOgGS5HMygI+MLTZWZtsa9QDKLJ1zYvY0qK/zzAJDfFAgW3o+f?= =?us-ascii?Q?cJWXNN6mwEEaXACM0O+H7bbXteMRjGvNCGvi9vTMxUc6jxPDQypOZYChkoW2?= =?us-ascii?Q?2xh+iFKO3d7ev0+2K+wZPOzAJ403o8RHzr4BGvO6Bk7R+9Bo5657an4xFQ?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:03:15.8353 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1d5c2c41-6c96-4003-1291-08ddb4a96ee4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE3E.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4344 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=f04f9ea7db2fb646e6c3e24b0e85a8f3f41be931 Thanks. Xueming Li --- >From f04f9ea7db2fb646e6c3e24b0e85a8f3f41be931 Mon Sep 17 00:00:00 2001 From: Dhanya Pillai Date: Thu, 15 May 2025 11:23:44 +0000 Subject: [PATCH] net/ice: fix flow creation failure Cc: Xueming Li [ upstream commit 1f332499adc57c86c46fdb26c923f8f56d4cb765 ] In non-pipeline mode, priority is ignored, and a flow rule can be created as a flow director rule or a switch rule depending only on its pattern/action. Therefore, remove the priority field check from ice_fdir_parse which is causing valid flow creation to return failure. Fixes: 14b12c939f3a ("net/ice: remove pipeline mode") Signed-off-by: Dhanya Pillai Acked-by: Bruce Richardson --- drivers/net/ice/ice_fdir_filter.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c index dd9130ace3..0d7b3fe164 100644 --- a/drivers/net/ice/ice_fdir_filter.c +++ b/drivers/net/ice/ice_fdir_filter.c @@ -2434,7 +2434,7 @@ ice_fdir_parse(struct ice_adapter *ad, uint32_t array_len, const struct rte_flow_item pattern[], const struct rte_flow_action actions[], - uint32_t priority, + uint32_t priority __rte_unused, void **meta, struct rte_flow_error *error) { @@ -2449,9 +2449,6 @@ ice_fdir_parse(struct ice_adapter *ad, item = ice_search_pattern_match_item(ad, pattern, array, array_len, error); - if (priority >= 1) - return -rte_errno; - if (!item) return -rte_errno; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:18.306466706 +0800 +++ 0014-net-ice-fix-flow-creation-failure.patch 2025-06-26 19:59:17.218418051 +0800 @@ -1 +1 @@ -From 1f332499adc57c86c46fdb26c923f8f56d4cb765 Mon Sep 17 00:00:00 2001 +From f04f9ea7db2fb646e6c3e24b0e85a8f3f41be931 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 1f332499adc57c86c46fdb26c923f8f56d4cb765 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -17 +19 @@ - drivers/net/intel/ice/ice_fdir_filter.c | 5 +---- + drivers/net/ice/ice_fdir_filter.c | 5 +---- @@ -20,5 +22,5 @@ -diff --git a/drivers/net/intel/ice/ice_fdir_filter.c b/drivers/net/intel/ice/ice_fdir_filter.c -index 2ff0090aca..d41d223d52 100644 ---- a/drivers/net/intel/ice/ice_fdir_filter.c -+++ b/drivers/net/intel/ice/ice_fdir_filter.c -@@ -2446,7 +2446,7 @@ ice_fdir_parse(struct ice_adapter *ad, +diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c +index dd9130ace3..0d7b3fe164 100644 +--- a/drivers/net/ice/ice_fdir_filter.c ++++ b/drivers/net/ice/ice_fdir_filter.c +@@ -2434,7 +2434,7 @@ ice_fdir_parse(struct ice_adapter *ad, @@ -33 +35 @@ -@@ -2461,9 +2461,6 @@ ice_fdir_parse(struct ice_adapter *ad, +@@ -2449,9 +2449,6 @@ ice_fdir_parse(struct ice_adapter *ad,