From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0448746A63 for ; Thu, 26 Jun 2025 14:04:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F35E3400D6; Thu, 26 Jun 2025 14:04:11 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2083.outbound.protection.outlook.com [40.107.96.83]) by mails.dpdk.org (Postfix) with ESMTP id A67A9400D6 for ; Thu, 26 Jun 2025 14:04:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lX0kiiyBZxSvXazdgoQX+U3OJ6IUFPI8lQ7bbTHsV5Ys5vy7mp71twZs8WPn56mJ7dKS+CNV4eKynmA214GuwM4jOGwFKeByUMiGQgQnzmDuveNmtTkm03zdugOZ8W0BbX81uXgmSNAObyP9Spa0JlsU9NCtOEZJ6arYBJRyBa5jkU5fHXtwFq4IfvO0rRaFvZCiNAAaDTianP1TMkWl8ww9HIbkhF0PKXp4DOa/c+3hK4P59iNT3RH5+GJLZq6OoRoodMTEJD2DnehMHEcqrAD5FPZHnB5D0GCqRocbCcnqY+c1kiOUpRCfOZfgwxRzg1xCOswv63rlrmxvHeM+GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VoUnqIF2aocUHlNpMi3NkDkRPOLoJ7zAHq7kRNQdaBg=; b=Low+qHEynMRDt/65eB/vIom/IijQdfXeMo/HxqC1ti5EC7hSkDX0W3VeReceq0OvkJyaXnGuSTRx80PmkL1W3wA+GSLZTSm0H4RgBCu7uy65K+PsmZutV2UN8oupPDVMwBfFey9ZyvG9N/VHoC+PXQGFFEA4ux8lilHTilUV+0iTYXrlGwBjFkHU1le39B6223+zg+V/4ayakfEp+Rkoh9PVDNHthsKbLwpSsc2ehv3usssNdlz3YhhqFOXGKVgaPLkEzmulB2TlGKSbMu0Z00/sz9IUqjs4Wm6zm8ITB3GkAjZg9QkeIhMsnv/zNsvqSStx7xAkaq+AEHVfvALJOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VoUnqIF2aocUHlNpMi3NkDkRPOLoJ7zAHq7kRNQdaBg=; b=GVi6/vOfe5GlGMsVcJnfyi3eybEhZHu+nJ8wON3HgQanh9XxRZI8v/dQSp1vReRGnG/yZSreb8UHKBXsvfQKcW0/PUUpr/AMeW6orBeAEmDi+R8tF206WkXW538Dgh8Xdyz8TQrxjq/5cJ7pAB+KDgVOYx0yzKt7Q7h0f34+zjnbljvCe8aWd65aBOXUOByCHpsiRqgzG6lckQemjEwitz3rCNOOwBLsDOcqaERItzimizoPdDw/zPbWGp+d15spmpZdxQEgsFrOxoy3xt9Emle4OX/GcAF6Of8ns5bngdwlm95Pn/Fr5rQ15Y29rv20hoCkn3UvDeHHAAtVfBmMNA== Received: from DM6PR17CA0017.namprd17.prod.outlook.com (2603:10b6:5:1b3::30) by SN7PR12MB6715.namprd12.prod.outlook.com (2603:10b6:806:271::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.32; Thu, 26 Jun 2025 12:04:07 +0000 Received: from CY4PEPF0000EE3C.namprd03.prod.outlook.com (2603:10b6:5:1b3:cafe::25) by DM6PR17CA0017.outlook.office365.com (2603:10b6:5:1b3::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8857.29 via Frontend Transport; Thu, 26 Jun 2025 12:04:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000EE3C.mail.protection.outlook.com (10.167.242.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:04:07 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:03:54 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:03:51 -0700 From: Xueming Li To: Maayan Kashani CC: Xueming Li , Alex Vesker , "Bing Zhao" , dpdk stable Subject: patch 'net/mlx5/hws: fix send queue drain on FW WQE destroy' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:00:44 +0800 Message-ID: <20250626120145.27369-25-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE3C:EE_|SN7PR12MB6715:EE_ X-MS-Office365-Filtering-Correlation-Id: 45356b65-cb27-4f16-c49e-08ddb4a98d84 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?pHfT1nqCFoCukLVsjFCN+yejUNhvH1L7/K4mQrIDgaNpSE0/yrPiZzgaw5Km?= =?us-ascii?Q?oaB+AiYuSbAMbDF5a0D+qhMbkATcq54sB3++rzm7uZ6xzSmREdQ3o5gXtWEn?= =?us-ascii?Q?fgd4luV0S6oa5OzyMfPT4BpyIJspj/NRd8z0Rw1UENkugyeYq4r9Efoh4N8F?= =?us-ascii?Q?ADDDTVq5I7Ebh4D97Kd/7NvzoBzxSw2YVih1R7MX3iEsEghL07JSSgCdmM3T?= =?us-ascii?Q?dgQtk6DdpA4GYcpy4dco+/nIz8CTZjj98884VzxJxmEhohIlJ5bqhQ5Ig468?= =?us-ascii?Q?JMCKCcidmAB7LcQxzqVNHvXT1MG51Kn4TCyPg3/YIEGHuKSFDXTSoBavkbBe?= =?us-ascii?Q?TV4NYnDRUMfxGE5yG4MqY2nC/1zuFly7ISUIaaTqDMg9BZhvWQKMTe4TOnW5?= =?us-ascii?Q?Loyoz6oCv/aK2TXGqttc+E6va+r+7G8i1NlaPOok948pcLgnDabflsexhU5S?= =?us-ascii?Q?etK5POUH3p0tWHXahcfS6S0A675MU1SdnMAgo8CfKtYyE8CS4L3Jc4HpDOm/?= =?us-ascii?Q?3AS6jAtbahsfjSedNJ6/fWgEsIb5qTATkG4zzAGm7F1Nl2ua0rF8ZmFo828A?= =?us-ascii?Q?dxATTiF1pIsfFI43ApOvx4IK8Q2KYz4zn6vM8YDOfBD25h/vqAi05YP4h6Ms?= =?us-ascii?Q?oqffd56QSuWdYDwdJqbAvcwx8+Pd23IgCixJuVr8mqxgyajLGgd2mKEQZ1Lu?= =?us-ascii?Q?Y1EPXimwE/OrUUaRUZGqbXWqZsO1+f6YnOnr2qHrd79KjQpSpZnJJlEZCXSi?= =?us-ascii?Q?MQr9fr0agkB63a1huPA2iw4uYeOmbu/W4gnRLg6KI87AHgMlK04Mg9CCWd0h?= =?us-ascii?Q?WBfMlUoCbW81q9Ni66H7lSj/9NWvMP9KGSf5h3xHnyEZGAjQX+SzF2w87wCI?= =?us-ascii?Q?2U+Vkkvcm3VKFnTZCrLQj6nmNU2Hb01WazMi2Gr1OFfcGiNw4DgXGQu5f/AZ?= =?us-ascii?Q?cPm889McShCWh9yWRD0afHyHn41nZIXMmd2nc7BXifaTXnuJLyD1MSYlh62e?= =?us-ascii?Q?c09i1M5jEJvgz/9LHVrDj8nIkd0NxjfrjvvIQ7YWqQsplNGJ00KVtRTuEViQ?= =?us-ascii?Q?lE9wZWtGA/T9fyDTKGUE5Te/JNZRU/NQcFLYzgTu9XSgr1qj+6g4MvrVJyBn?= =?us-ascii?Q?fPFImIwlF1SYFEBf3bCym3bAwsK+t4DjsQbIlE72Q49yBrFEfLqi5kyByzws?= =?us-ascii?Q?lJbBV4EthIqAHYDRA5YcDbHHABm52rIoFiSYySweSvwhI7y4fAXL4tn2/Ffp?= =?us-ascii?Q?0SFLkAZ1ldQS/Nbmh2Ub79MKa3tnu+1YG9GSn/d6hkjVV7+ZlQHY/v+M3BPX?= =?us-ascii?Q?8waj7XsNZv66yuVbAn+PJB+M34wECPPExdW9WqGemKYoCvmMOvqn30/snBGE?= =?us-ascii?Q?Ce9AVmq+T81jWWjkByrRIPAoU3ZDyFN1zCUWZwylz8Jbwr2YhA6eqpMvbwmB?= =?us-ascii?Q?T6Ychc8sfOwpLg7pz48Qwwe1AxxcYrfmtpt+8Cy3f4Iy3YUNN1GaCctTZwzW?= =?us-ascii?Q?MiI0/YbhOO/11hjUd7IsiJmvVLtRxd2JxqLfcuNC2R2HdoMUScpZ6Z4mig?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:04:07.2139 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 45356b65-cb27-4f16-c49e-08ddb4a98d84 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE3C.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6715 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=b7f8d01c0a435dbd32cd2b711a36eecb9f11f44d Thanks. Xueming Li --- >From b7f8d01c0a435dbd32cd2b711a36eecb9f11f44d Mon Sep 17 00:00:00 2001 From: Maayan Kashani Date: Sun, 27 Apr 2025 14:28:21 +0300 Subject: [PATCH] net/mlx5/hws: fix send queue drain on FW WQE destroy Cc: Xueming Li [ upstream commit 0394577bdc91a25338fd9a61eb2ddfedf09f2800 ] Queue sync operation was skipped on rule destroy. Unlike on fw wqe rule create in which both fence and notify_hw are set to true, on destroy fence was set to false causing previous queue operation to be stuck in the queue forever. Example: rule_a - HW rule, rule_b - FW WQE rule. Sequence: rule_a destroy, burst=1 (HW rule put to queue but no DB) rule_b destroy, burst=0 (FW WQE rule cmd but no queue sync) Outcome: rule_a is stuck forever in the queue - no completion. Fixes: 338aaf911665 ("net/mlx5/hws: add send FW match STE using gen WQE") Signed-off-by: Alex Vesker Signed-off-by: Maayan Kashani Acked-by: Bing Zhao --- drivers/net/mlx5/hws/mlx5dr_send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index 4c279ba42a..021d1375a9 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -339,7 +339,7 @@ void mlx5dr_send_stes_fw(struct mlx5dr_send_engine *queue, pdn = ctx->pd_num; /* Writing through FW can't HW fence, therefore we drain the queue */ - if (send_attr->fence) + if (send_attr->fence || send_attr->notify_hw) mlx5dr_send_queue_action(ctx, queue_id, MLX5DR_SEND_QUEUE_ACTION_DRAIN_SYNC); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:18.886733181 +0800 +++ 0024-net-mlx5-hws-fix-send-queue-drain-on-FW-WQE-destroy.patch 2025-06-26 19:59:17.270418049 +0800 @@ -1 +1 @@ -From 0394577bdc91a25338fd9a61eb2ddfedf09f2800 Mon Sep 17 00:00:00 2001 +From b7f8d01c0a435dbd32cd2b711a36eecb9f11f44d Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 0394577bdc91a25338fd9a61eb2ddfedf09f2800 ] @@ -19 +21,0 @@ -Cc: stable@dpdk.org @@ -29 +31 @@ -index e121c7f7ed..d01fc7ef2c 100644 +index 4c279ba42a..021d1375a9 100644