From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAF2E46A63 for ; Thu, 26 Jun 2025 14:04:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D59E8402E6; Thu, 26 Jun 2025 14:04:47 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2089.outbound.protection.outlook.com [40.107.93.89]) by mails.dpdk.org (Postfix) with ESMTP id 686D94026B for ; Thu, 26 Jun 2025 14:04:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aNVLuzfe6/PjrpAXkLbhIPDy5qBIZ7B/pTNLw2ASWoHC1QbiWrkW7dE7H5jst8udrBDm5xZPlZh2qlij84xCuY7UPai26SI52Rm1fCzq+oPTQPuxlhI/O9uXvP5/Pz+3wDQ3UqltsJx3qjMVr8AgvF+WCGK5erilzcGRcnh6W8+b5MgEuxV1tN9Hk0TG6hyS4wUiTbUYCEz6IkLA5swY3LrhGILq3HARR0ZuvjCUbaOioxxdVXmfioVrvMCfzdKOQ6y1Q/2g15ieOA3NXaGXcUJwhjeZWMelwCcN0ANYeUwDiUclsFPZCrxH8MBt6czJi6EJZJ5fozU8Yu5iox1AfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8nT06hVJzalep9/pFkPUaqkpkxriiMLGhSAMyX6PSgI=; b=SIjYSVRwn+QnA97F0NFUOe3QXbS+io/2GM9BAViZSIMn5yWJLgTc8Qzi6GXkbrmmP0XNgrhw+l40BisTDAaHLkukshr8h+qza4tEEiCNesdfRLNRCQ76EePQFa39tu2/LBzvofcBIHTkLhg/H0m8YFO3vSNYYk3oZIgiJuOOHdKSuVNQ0e4SNzNL42VXRB57enfakMnA1X19JcNHIb7PAXy2LC+O35oZD7aLdLGquK6tb/BdKc7B1p/RX+RB/jpkFSY8WJrXkAhku7V8qDG7PVZjguAZa/QDyie0qpJPG76FWTbJiaMTpkMs4jG8h4VHVmyoEC2Ih91L9diPqNav4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8nT06hVJzalep9/pFkPUaqkpkxriiMLGhSAMyX6PSgI=; b=gO+Ga3DB9f8MhRX6245gEIq8yYfR5BDq0Z3hj8S1nqAnEwrtIu58aWc253zt81Dws9F+2rfo14uPdwyHHXlY5TRp2+31nKy8uckM1tA3JmbpxisRea0gEHT4mpeJgVdO/KAud5nyoBQ+PK8QtkIfcwb8woquSJ5boJvp2LUBlySQki4Shk34uoJWbYe5OK47fcCjXSHHOdh8wIqg9iZSOUTFvCYH51+9zZWbOVc86sd7nYI+HY1ji/sN05DYyX6xcHAaf23/L6BBqFiS/BP4bic1bz9RQjaL6ajHh4N1X64HtW2pPMeXtqRxF4OpW6W3/wqjueRG3gaOgC9qgLkZ5g== Received: from SJ0PR13CA0122.namprd13.prod.outlook.com (2603:10b6:a03:2c6::7) by DS0PR12MB8246.namprd12.prod.outlook.com (2603:10b6:8:de::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.21; Thu, 26 Jun 2025 12:04:33 +0000 Received: from CY4PEPF0000EE3D.namprd03.prod.outlook.com (2603:10b6:a03:2c6:cafe::80) by SJ0PR13CA0122.outlook.office365.com (2603:10b6:a03:2c6::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8901.6 via Frontend Transport; Thu, 26 Jun 2025 12:04:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000EE3D.mail.protection.outlook.com (10.167.242.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:04:33 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:04:20 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:04:18 -0700 From: Xueming Li To: Gavin Li CC: Xueming Li , Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: align PF and VF/SF MAC address handling' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:00:48 +0800 Message-ID: <20250626120145.27369-29-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE3D:EE_|DS0PR12MB8246:EE_ X-MS-Office365-Filtering-Correlation-Id: 384bdb6b-39fa-4a1d-befa-08ddb4a99d0d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DAoAW+5fwdSlKoPfcbmMm6dpLXBmQhp0OqxJaScCRQS/GicPNgtQQTdESAPv?= =?us-ascii?Q?U/uCbIKl60mSiNLniyP4jnQ3rp2kVz2qsiiUeHaShx5GufMEZyuhLm0ZY7fy?= =?us-ascii?Q?J1jj/z6ikyVF4n5KfE6OaCkNHmYjmc/4ndCOezIuTcMAVTYDOyi+m5IAmb6h?= =?us-ascii?Q?oLxi3uks3pw37nfuY5NL70qRGrE3TfGSlyb4YauMAnNhoPLUW8J9A2c2cTRz?= =?us-ascii?Q?fQ98yvO+WALI0aN4VUyjO39k4HvSW+3qnMGeTkudgOr2xF1KJja94RQH9Rxq?= =?us-ascii?Q?pkxTDoP2g/xLUrA3Bv/2fiw2JdlbJL0xYodeLbUD09O7XSnGQOgGFFdkYuaO?= =?us-ascii?Q?H4aeVAr8XUnG03qiIEXMyNEq19uubTajs3EDXiD3NnQm/AU9xAbDKJBnzUqn?= =?us-ascii?Q?qZ7lzkXHTD4LxTopgUBBuOY2xn7KdlE8mkJKVIWthi3ab1bNvDpPejyM0Hqv?= =?us-ascii?Q?cBef3QL4xk/4Oza7zI4NjuSPuMVzeWDKJmMGmlT/AqxgT0HF0teeG0UvX9tE?= =?us-ascii?Q?XofF3TSxDDZdVRKyLafpM0tbQYrriStEsInZ/mDf379kkSNk4WIo8II409II?= =?us-ascii?Q?hu1Ki6b7PnDUAK3/5Ii7wvl4YbMwjt1rLrYubGr995behSqG4O3Bbh6WSjID?= =?us-ascii?Q?Oyfo8S15EhORrQQCLa0XaA1E4iWKCTCAWeOM7+RYWBThNAzRyJtFWhSF7QPT?= =?us-ascii?Q?XJQekXg/DxQ4JO0Q1obdcpiY/C0MCtJnUHKVhbAGCO/AlYexTDYMAg7wW2j0?= =?us-ascii?Q?FnJGJim6nH1syIOurxGuYsWmDRYyqHPmf5898/GttRk/dWkK+VG6rlsa/aic?= =?us-ascii?Q?BygocPqZnKejWlH/lXo6F55Wo1JHxstfXFO7JRU0qLYtp33l/sIiytsQK/FH?= =?us-ascii?Q?qHHZ97Iq9jY5Na1+Ygoq1phdVo2gGR3wtROYgcYNi5M/o/UGVQEnLKQIUz66?= =?us-ascii?Q?Snk2ydYYs3wLFcc10MvAWCig2MBrcbzswr2FqZRbnA+3ioKmFZZnu8LPj9cW?= =?us-ascii?Q?dd6olJ70ecUzPsGSowX33GKcZoiPu2q/IOxabDmBe2T91WhOG2nzlzMRTeC5?= =?us-ascii?Q?NZiBgbwDhMx7rw53Qg4ZDERaARMpPg0bG4oeu95rNgZF/aedWwvRX8vxWEaD?= =?us-ascii?Q?wwI0WyqYMSo/YHSgoDM6T4UFnIznfWou2oE2vI3wHuqDvU6yYHzi2cIGz/gy?= =?us-ascii?Q?JjTIKz9jLriTDKKgKjhO7VuEwk/BAaSp9QTesfsUh97ScxgceM7qmJ8aY0EA?= =?us-ascii?Q?LFuTIz8MX9AH7O6ifVQQXA1rbih7aT1nmxj4mFfzqCkH/sgFsApZW+jxYV6d?= =?us-ascii?Q?g69nNrkv7MLbGgbHi946R/LaQQHcZ3RZye1uxghLmmbVm+m93p7ATUZXWR5A?= =?us-ascii?Q?F3sMEM+m1sn5b1XdoC5RzHtdnQiyBooIdW7xwm9Q6gFhAKwcy8Zf8nXFklBe?= =?us-ascii?Q?m4CMKLzqsYkT9JDjAN1tA4pE71onJIBQ0QYPc7W7o/fpR9VQ4XB++EszwY/T?= =?us-ascii?Q?JX3sKFWolhsdDzXuTiaSj4xIN98CyeUSoBKEiDla0l46rzwAPJ6AZLT7IA?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:04:33.2651 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 384bdb6b-39fa-4a1d-befa-08ddb4a99d0d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE3D.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8246 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=c070455e8bd61847c8ac80f1e46162b36653a4ab Thanks. Xueming Li --- >From c070455e8bd61847c8ac80f1e46162b36653a4ab Mon Sep 17 00:00:00 2001 From: Gavin Li Date: Fri, 16 May 2025 10:10:32 +0300 Subject: [PATCH] net/mlx5: align PF and VF/SF MAC address handling Cc: Xueming Li [ upstream commit 2d0665a7f7719e8cd615b64ac9f2c8c22d47450a ] In the mlx5_dev_spawn function, the Virtual Function (VF) synchronizes MAC addresses from the kernel using netlink. It queries the netdev-configured MACs and populates the list in the PMD device data, including multicast MAC addresses. These addresses are later used for control flow creation, allowing traffic for the listed MACs to be received. However, the Physical Function (PF) does not synchronize with the kernel and thus does not add any multicast MAC address rules when enabling traffic. This discrepancy causes the IFF_ALLMULTI ioctl code to malfunction, as it fails to disable all multicast traffic, leaving the VF still able to see it. To align PF and VF behavior, only unicast MAC address flows should be added. Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") Signed-off-by: Gavin Li Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_os.c | 3 ++- drivers/net/mlx5/mlx5_trigger.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index fdc4dc1cf8..c6e5e7b425 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -1562,7 +1562,8 @@ err_secondary: eth_dev->rx_queue_count = mlx5_rx_queue_count; /* Register MAC address. */ claim_zero(mlx5_mac_addr_add(eth_dev, &mac, 0, 0)); - if (sh->dev_cap.vf && sh->config.vf_nl_en) + /* Sync mac addresses for PF or VF/SF if vf_nl_en is true */ + if ((!sh->dev_cap.vf && !sh->dev_cap.sf) || sh->config.vf_nl_en) mlx5_nl_mac_addr_sync(priv->nl_socket_route, mlx5_ifindex(eth_dev), eth_dev->data->mac_addrs, diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index a61128ec21..6643fe7eea 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -1705,7 +1705,7 @@ mlx5_traffic_enable(struct rte_eth_dev *dev) for (i = 0; i != MLX5_MAX_MAC_ADDRESSES; ++i) { struct rte_ether_addr *mac = &dev->data->mac_addrs[i]; - if (!memcmp(mac, &cmp, sizeof(*mac))) + if (!memcmp(mac, &cmp, sizeof(*mac)) || rte_is_multicast_ether_addr(mac)) continue; memcpy(&unicast.hdr.dst_addr.addr_bytes, mac->addr_bytes, -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:19.058595974 +0800 +++ 0028-net-mlx5-align-PF-and-VF-SF-MAC-address-handling.patch 2025-06-26 19:59:17.318418047 +0800 @@ -1 +1 @@ -From 2d0665a7f7719e8cd615b64ac9f2c8c22d47450a Mon Sep 17 00:00:00 2001 +From c070455e8bd61847c8ac80f1e46162b36653a4ab Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 2d0665a7f7719e8cd615b64ac9f2c8c22d47450a ] @@ -20 +22,0 @@ -Cc: stable@dpdk.org @@ -30 +32 @@ -index 573e846ed2..696a3e12c7 100644 +index fdc4dc1cf8..c6e5e7b425 100644 @@ -33 +35 @@ -@@ -1603,7 +1603,8 @@ err_secondary: +@@ -1562,7 +1562,8 @@ err_secondary: @@ -44 +46 @@ -index 8145ad4233..485984f9b0 100644 +index a61128ec21..6643fe7eea 100644 @@ -47 +49 @@ -@@ -1714,7 +1714,7 @@ mlx5_traffic_enable(struct rte_eth_dev *dev) +@@ -1705,7 +1705,7 @@ mlx5_traffic_enable(struct rte_eth_dev *dev)