From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73A9146A63 for ; Thu, 26 Jun 2025 14:05:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DCF04026B; Thu, 26 Jun 2025 14:05:01 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2070.outbound.protection.outlook.com [40.107.223.70]) by mails.dpdk.org (Postfix) with ESMTP id 763644026F for ; Thu, 26 Jun 2025 14:05:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FNhuGCgc+B1SWtrLFu/VbBHi5q8TeuMlDna/o7CAe9Y1GEby1QSs9ULlWSKorJO3mtjsElUFW9fZU4RU4T4vLwzj8EVSjW3/4brFtOuJRfm4ks+ENlXdV+2kELUb+e0cnJK0I+VgOWFbRZ5V10bJemBe8IxXI+HBL/61iXchsb7I9+EUtXLCoFWGTMTPZ8zEUIYfrF592bjQ/TrIIqZ0I4nyFLKLiSNq557Wciwozm+XPNnj9qBJIobgmyvDdIGXCm6qn8jOy6nprMeL8jtK49EOyiOrpAi454wD3sMysq+GSVWQ38Y1qkjZlRV5x+HE6Qf51CUAqwfJu6a2elZiqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fx78S/bnRlyHVzDCd+eMdrWfbek1fAj8epU6TMAE/RY=; b=veADm1EdnyGrw42EC8hAZekZy8UVmCeBxQyDuy1uWFUHW8rN1fp6BR0IU/UAULF0jzMxsoYbT1ft6m6YOjq5ybezQMdxZGkf0FECaYzBnzMxMLT/vFFAgc4wCPHGnCGAwdzJ+KTiayf/s4ZORq91pW72FHM0RtfxzfbR/DP8i9Kjz0o0n3ECwK0XIAlilg6X/CazR2yi4QTsczEM/PCCgxLHneXeWCYyoJvCcigCGkFXauMneg0Y68pQWOXBjn9GwiqJilgdD76CelqVgNFZixb/HTQr7boBDilMZKr6/7ig4z/E6u/gI7/pDcTu9hx8CbP1uDEi/yz1rsAd12LChA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=corigine.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fx78S/bnRlyHVzDCd+eMdrWfbek1fAj8epU6TMAE/RY=; b=MTEc1xi/8lhLHrHmVKzGD4G6JDHd3zW6p6N6pFvLJ4K6Q4LxMQegqp+8nL+W2mdIXRCH5KIkzzxxWK+Tl39A5niFXXQTUy94WrRfFtSFzx5Jc1F6DUUwXjZQlgp6qxzwKQC64Ygp/uhF0aw077szXdghz5W0TgHLPa8rqMZBfOFkXG9wu/X/64jbHsj/ycofoP/2uOktc3ngQQftYA9Gnk+7xXNhFj++GO7e3DVMGX4lvVF86v3NJ9bDHFGSptAIIR6BrZ2QXd7XMZex8LwdItWTXOk3GZ2WTHSVUYwVt7Ptqcwovw/ceuYcnXyZjVnSFCTv6pBwHl4wB7l5yOmrlg== Received: from DM6PR17CA0007.namprd17.prod.outlook.com (2603:10b6:5:1b3::20) by DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.16; Thu, 26 Jun 2025 12:04:58 +0000 Received: from CY4PEPF0000EE3C.namprd03.prod.outlook.com (2603:10b6:5:1b3:cafe::e) by DM6PR17CA0007.outlook.office365.com (2603:10b6:5:1b3::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.21 via Frontend Transport; Thu, 26 Jun 2025 12:04:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000EE3C.mail.protection.outlook.com (10.167.242.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:04:57 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:04:43 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:04:42 -0700 From: Xueming Li To: Chaoyong He CC: Xueming Li , dpdk stable Subject: patch 'net/nfp: fix hash key length logic' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:00:51 +0800 Message-ID: <20250626120145.27369-32-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE3C:EE_|DS0PR12MB7726:EE_ X-MS-Office365-Filtering-Correlation-Id: df3f8acb-fd53-4705-f2bf-08ddb4a9abbb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|36860700013|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?h1adtx75c3y3o7088BMeuevhoDR0WMQL/7aCzEIPWOxLLMuXlRWFqjbriVT0?= =?us-ascii?Q?FY8xBPN7bZQftzWQVu4kHVfbQFZ3X2PlizRbU8FX1L/Ya12/+NAtAvnM1SCH?= =?us-ascii?Q?KB2lkV6eb4xx+kbsKa4eA5bh84F+T14Iw1KJuGiZ7aAQcBsgnewpiHUAqvdo?= =?us-ascii?Q?7bZqRwYvlrb8XVkzO2w99tHCQXAMEnXl3kBkb0UMZugslEhClIv4gaSArrRF?= =?us-ascii?Q?3prNjzHu7D1X4e1Fnx7y8gtxeHSLwsFjlUWZo3lRUEcr6K4OOGOk1FiN36Ru?= =?us-ascii?Q?6IjbmDKcX3zosj1gMMazxjCGMIRYm94F5er2p4gTkNjLwJ1E587JRk+8GvqY?= =?us-ascii?Q?JlAZQWaq/62/iy51OdCFBqWxZKsYf5GT09Gk1D7JFtMWtQnuCj7xm29zMxLy?= =?us-ascii?Q?Fw4e12dS2Oaug+LsNbE17DGeWFLdbqLqDyhlk5klcMobFisFp/YaynnEPO8j?= =?us-ascii?Q?c6mXi5W8wgAm8W/oDL2vBXhIpRoeqeThMMhvlZPthkUE0WemvRJk3RHzvFGc?= =?us-ascii?Q?oqzIuzn2yuQLpqEex0DDv/klUgqkelo6+LhHgdOR/Bcs0aCmj+JgKYBFABXV?= =?us-ascii?Q?Z7IH8oMHnbj/vCjAymZg3KgrM2Vn4AgJYugbNLeMBJChABbeXLMqxR2+Aiqd?= =?us-ascii?Q?Ulbdknfb7nzb8gdkjib2kZrebKv61nwjaqbPqroXvfDgCTD0zogSd1u2YJ5Q?= =?us-ascii?Q?lkqeLtRsfM7DdjALQXs5E8VfpNzKBoJIUwKYyeRJZGSfa2PkebxQfa2PggHK?= =?us-ascii?Q?qTXGkJfGS9KXIKMxBDL5zxAYGyYkI3uA9G5CaVBbqfsdz8tp37a4o+lkfQ5g?= =?us-ascii?Q?vCIUObwEJrZ4OUUGqHaGD0N7ZaPmLnr/NyyGLzBjcujCtwp1RkF9Syv76bwj?= =?us-ascii?Q?LfWaIwP3j9MCvr9zEl+EjAPSCWtWdYwXA3DBZweofLmeXtI20qpY+G6B6LiY?= =?us-ascii?Q?HBAf2w5FAg7L3Ea7R4BZNAj4dlWm7dzrtucV0s5IX79MtwaK4AM4HkCvvI6n?= =?us-ascii?Q?sTkzMQv2sLIPiZuU83KyAgLi/xH/QbKQ9MfHUk3ZPyGizKG49hE0asIsOpzV?= =?us-ascii?Q?jXCfANPyoEEJ6s9nlK+HZwFHaSMfiUu3MmZMaIG+jwFsUE9hY/qZyZtEEFNK?= =?us-ascii?Q?U0YUbX9XtatmLHKIfhuNAQMS/08mEJjHHM+wZNQJS/PjqSChxaXDdFMt9Qfk?= =?us-ascii?Q?aQficQZ66Xf/Fx8qDrbiXShP8ALVJtlPiv1QNse9KAdpZIkM8qDQ6fp4xk9U?= =?us-ascii?Q?Im6nE8v6BK/8LbUtiQOCnvXYh34Urge+P9IWArMDU1MoljXvP0LTVhJjkplx?= =?us-ascii?Q?a2D8GkotBFrkiMnSpnuZ6GQidRRswrZ0XDVr1+i50vkjb2W+vu3Tvz/+MBcK?= =?us-ascii?Q?/nBkUkmbW4QaQPDIBQBslCkiHiqVp4pKTUYBGbtcSSCH6ZPrZqONnwpfqUSr?= =?us-ascii?Q?wKWBEJP9NLN/GfD4vjjpRrKSFUTJRbVZvkUTDuSA703Z+OFvF+372sKjWbiL?= =?us-ascii?Q?gLrKKmwfYrNqp1LzOGd/CofIiy/0arbYXos0Tml7HnR/AaHutLjWb7+q1Q?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:04:57.9131 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: df3f8acb-fd53-4705-f2bf-08ddb4a9abbb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE3C.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7726 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=26f6134cfee6e64f1da5a446bf7b975f88894983 Thanks. Xueming Li --- >From 26f6134cfee6e64f1da5a446bf7b975f88894983 Mon Sep 17 00:00:00 2001 From: Chaoyong He Date: Tue, 1 Apr 2025 07:09:31 -0700 Subject: [PATCH] net/nfp: fix hash key length logic Cc: Xueming Li [ upstream commit 346a007e161e68950acbf59984fefc2bb6fe3982 ] There does not exist an API for driver to get/set the hash key length from/to the firmware. --- drivers/net/nfp/nfp_net_common.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c index 61a3685e2f..b0ccd2fcab 100644 --- a/drivers/net/nfp/nfp_net_common.c +++ b/drivers/net/nfp/nfp_net_common.c @@ -1724,9 +1724,6 @@ nfp_net_rss_hash_write(struct rte_eth_dev *dev, /* Configuring where to apply the RSS hash */ nn_cfg_writel(hw, NFP_NET_CFG_RSS_CTRL, cfg_rss_ctrl); - /* Writing the key size */ - nn_cfg_writeb(hw, NFP_NET_CFG_RSS_KEY_SZ, rss_conf->rss_key_len); - return 0; } @@ -1817,7 +1814,7 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev, rss_conf->rss_hf = rss_hf; /* Reading the key size */ - rss_conf->rss_key_len = nn_cfg_readl(hw, NFP_NET_CFG_RSS_KEY_SZ); + rss_conf->rss_key_len = NFP_NET_CFG_RSS_KEY_SZ; /* Reading the key byte a byte */ if (rss_conf->rss_key != NULL) { -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:19.154149770 +0800 +++ 0031-net-nfp-fix-hash-key-length-logic.patch 2025-06-26 19:59:17.330418046 +0800 @@ -1 +1 @@ -From 346a007e161e68950acbf59984fefc2bb6fe3982 Mon Sep 17 00:00:00 2001 +From 26f6134cfee6e64f1da5a446bf7b975f88894983 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 346a007e161e68950acbf59984fefc2bb6fe3982 ] @@ -9,15 +11,0 @@ - #define NFP_NET_CFG_RSS_KEY_SZ 0x28 - #define NFP_NET_CFG_MACADDR 0x0024 ---- - -The original logic try to use the 'NFP_NET_CFG_RSS_KEY_SZ' as the -inexistent API, read from this address will get wrong hash key length -and write to this address will overwrite the MAC address unexpected, -which will cause very strange problem. - -Fixes: 934e4c60fbff ("nfp: add RSS") -Cc: stable@dpdk.org - -Signed-off-by: Chaoyong He -Reviewed-by: Peng Zhang ---- @@ -28 +16 @@ -index 600fcd5c0e..df89595773 100644 +index 61a3685e2f..b0ccd2fcab 100644 @@ -31 +19 @@ -@@ -1966,9 +1966,6 @@ nfp_net_rss_hash_write(struct rte_eth_dev *dev, +@@ -1724,9 +1724,6 @@ nfp_net_rss_hash_write(struct rte_eth_dev *dev, @@ -41 +29 @@ -@@ -2059,7 +2056,7 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev, +@@ -1817,7 +1814,7 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev,