From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B859B46A63 for ; Thu, 26 Jun 2025 14:05:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC0494026B; Thu, 26 Jun 2025 14:05:07 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2077.outbound.protection.outlook.com [40.107.237.77]) by mails.dpdk.org (Postfix) with ESMTP id 445FA400D6 for ; Thu, 26 Jun 2025 14:05:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GrLgipZOw2rcXcGF914Rexd7f7GpUhMBNKVGU5lP+NdoNS++LeEOha7Iao1J6EUzWziS3+w50/hQt7cpYjtfd8VAAp9549L8I33+0Bgc73oPc9RpM8VfdZNXkdtXOWkPiBgHt/kyVhDzm+LlC1x3ygT3Xa4dPmRsp2Uw1rkwscz5XU2HI8iTOjM+PIhBEkAljFp4Wg31cXntfB7hqP0Glq99AfbccBMlJ3Xc1W0/dA9O6WxdYHfDID3lrZjrm29dWsgX4HVZbFH+KhfQUjrOR+ppH88Dj6wNkaYeUYF+qKFrGOMoRiUI7U64EC3Dv7ui1ml3ncRMhi2ZV7mdRBa3Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VM9G3XoXI9TMNeSVao0dtFE42XBv2dYqmduBib1az4Q=; b=zVYfRivbzfsreAMZmRZGuNhHnv3hRSumFJ1GfUbR2e+2tqhWGvsvIlYzoeYn7d1RgNL7D+/REq9F+Ubj5F43D8B4MbY61b6bnEL911Qxn/1cNDQzdir45P+Ph9QPREaadAs19e0kVHJhJx+82ENT0AVFboDqL73tPaOa0oVBTnWBx4fMbZKXh1mLdYNRT2G5CcTkc4bI1sCFcAvrwdrfusqmsrRGwoVAlncTiBcyCvcTYgPpxUQHqPaqiUXiJL936+nVsWby+/rQ0/zwx690tcG7yCJI5cjJ/zwDbTYWzIVex3MYZVhEANVIhbrEkqn/Qeevy+zf5VC4HBmUAC/0Sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=corigine.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VM9G3XoXI9TMNeSVao0dtFE42XBv2dYqmduBib1az4Q=; b=EhDB3Z4eI/k7KVDRow3I6dcES9rvFXiDB5th3tJNys90SRNq08YD1tzGoWpax14tYeuFi+SPek1ctZ0hA/v16mI2G5iXXo9p97MSvIoiX0PfvLJlTgu6KPabN79+fPSCC2X8icKCm4aB2LkSJeuzIDRQnw7ZnCeLHNp0KIBzhoUvyG4y3nJwcVtGHtCikquP7ByBZJrNCBRxDqyBhc7jdHqRzoEUrKfD4jZ2oNmFUOlxKzY2TYF567DwzigkdLK6loaNoEfyXIeNTTC2Zp8iqDbNPTZUApdRlRfRT4IlrJW5DUW1JPaQbkTH/0ju4gzYuw4u9kQb7QcF43XmQYEZSg== Received: from BY3PR10CA0028.namprd10.prod.outlook.com (2603:10b6:a03:255::33) by DM4PR12MB6182.namprd12.prod.outlook.com (2603:10b6:8:a8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.21; Thu, 26 Jun 2025 12:05:03 +0000 Received: from CY4PEPF0000EE3F.namprd03.prod.outlook.com (2603:10b6:a03:255:cafe::d7) by BY3PR10CA0028.outlook.office365.com (2603:10b6:a03:255::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.20 via Frontend Transport; Thu, 26 Jun 2025 12:05:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000EE3F.mail.protection.outlook.com (10.167.242.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:05:02 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:04:45 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:04:43 -0700 From: Xueming Li To: Chaoyong He CC: Xueming Li , Long Wu , "Peng Zhang" , dpdk stable Subject: patch 'app/testpmd: fix RSS hash key update' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:00:52 +0800 Message-ID: <20250626120145.27369-33-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE3F:EE_|DM4PR12MB6182:EE_ X-MS-Office365-Filtering-Correlation-Id: 3cab46ea-86af-470a-1b5f-08ddb4a9ae39 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|376014|36860700013|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?zwAkErMvVt/C2WRu0Ju2OTe2pa6l6PJ2GZzGTWdbX8PSKNsMRQaoiWq5g/LO?= =?us-ascii?Q?RBsKhrX5orssDCTc0oW2XroJe5tSvxTeeUAbiUgM1XjA0BrttNT3wEIqIU79?= =?us-ascii?Q?0ckct2UjWkQd+iYzC2I33Jtd0e4Pducdh/xap8yZTEkY27czZnA3/BOaw8Pq?= =?us-ascii?Q?fHtrJedgHN/ggQ0/oY7Cqs87yG/Fj6/fCiqkzLqNMvSx4DTSLfciNjmf2T1B?= =?us-ascii?Q?dsUIv2JYld5fh7s08QQXYFDqlTJ6a21eJCiKJ57v+Dt48h0DLXglhAa8Rtsm?= =?us-ascii?Q?QMP/3N+/1hhNgSok6Xm5+8yLGq86wpOFwF1cDopjkZWTOUDCBoVeccEE/rUf?= =?us-ascii?Q?dZhwvrEcJmlZ8jqJRsxQdshdspWFhHq8yt0+0rEm6AwpCg79nQBD5Za4RTv8?= =?us-ascii?Q?PKDQ68R6NtSI7l0hEnpcES4DE8wMC8+WhYoOkqCae3rit7O2R+MusQF/NXGW?= =?us-ascii?Q?BsL4NbG0HmRwPtFkwMt9ZMSGfNh3u9SdQQKhPRDVNOcDAZpQhAjQUpEd6wrM?= =?us-ascii?Q?dvPl6N8s90RR+JmkL7Twn1lZYKPWUGQ4KzNEzqOLX1GTQgCUlavhJtFNndQW?= =?us-ascii?Q?h3o+qzGrvCd4sx3LFHP3JPPyFLkg9+3h6Zikp5sQfvRM8sD6Ct/xrz5DpoWL?= =?us-ascii?Q?rySJMvrtPH8QSAZ45rn8WCUI1gct2xo89dd8p1gXpRRI3CyU5/6iEmLHGXbj?= =?us-ascii?Q?j29B2/3IhmqAmXbJm7GfMUvAqWj+tO3P0H1EcZ/0f8E9D0kG1tWfRqWqM1zV?= =?us-ascii?Q?RtKs0nvUBz1d3WZuxo8ePXFq6VlHvglZ/wHGEwbPF/HzqHZX+EE8gm3r4zTq?= =?us-ascii?Q?s/dnaM0JftL9o3+G15kdxGXO57X5bjy8k1us1TZIUPppPtwi4YuLyckFXlrU?= =?us-ascii?Q?mVUnONLZoyfDvWQDFx/aXlfwrip5/DSNuUag1f2rvAVeyc+ml23kdA82HeF8?= =?us-ascii?Q?42dVsR8uYTdLPyvtYWkymmDswChawFzYDEi6jeGXZlEQMYUyWwcNUzcgIyMz?= =?us-ascii?Q?bvYEBnmTw5aIaQAnpzeZNcWAwd4AaavPMBxajWU6Cbabkx3LrsxJcz0KE5P3?= =?us-ascii?Q?nxrn3uZRrrBxWGMc+LaRFkybtRsCNoyvSz4Yat5ntaKuCud8/BIyYWIj8LMj?= =?us-ascii?Q?WsQXnS2j9epeuZOtAdi00ZaIVItnl9Pk0e/A1OMTtZvkSt5NKQ5cy2vXN++X?= =?us-ascii?Q?gAHzgodlIav++XojvROr3rPo7yhnTkjejpijgBZmFBal8M/2Xby7eS6IMFB2?= =?us-ascii?Q?CPnLmI+MTMoD+owvx4KzSO5AttErlZgkhntlFTN90ZuK40n/gkyQiiybq0WH?= =?us-ascii?Q?Bb8JF1cXE37O52Xlg54+qjw+uIMMGjTTAoVzmw1my0GIWmHTGgh9BV+8jMqj?= =?us-ascii?Q?IxlMY4+oYWFmLaEkeUSZm9eu4+QKdaDNdetPkXfDgbPOdgNICRjG9UKjL852?= =?us-ascii?Q?9y3ZB0NKS4kgKKtdw7VblnudjA7E3ZRVPy2crS2YkxovRTFwBeG4nOGqfqDM?= =?us-ascii?Q?By0oQpyyP+Bm7bknQnbjqDKtgMW/eRsM7EmpVpgL77KlLpo+uNa95YxhHg?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(376014)(36860700013)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:05:02.0864 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3cab46ea-86af-470a-1b5f-08ddb4a9ae39 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE3F.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6182 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=31817dc08ead234519e36e00a40e968c2669d499 Thanks. Xueming Li --- >From 31817dc08ead234519e36e00a40e968c2669d499 Mon Sep 17 00:00:00 2001 From: Chaoyong He Date: Tue, 1 Apr 2025 15:48:36 +0800 Subject: [PATCH] app/testpmd: fix RSS hash key update Cc: Xueming Li [ upstream commit 24e94a4c86c52f45a7a7c139e4e8484f3afe6d8f ] There has logic problem in 'port_rss_hash_key_update()', the user input will be overwritten by the call to 'rte_eth_dev_rss_hash_conf_get()', so the RSS functions will not get update as expected. ------ testpmd> show port 0 rss-hash key RSS functions: ipv4 ipv6 RSS key: 6D5A56DA255B0EC24167253D43A38FB0D0CA2BCBAE7B30B477CB2DA38030F20C6A42B7 3BBEAC01FA testpmd> port config 0 rss-hash-key ipv6-tcp 6D5A56DA255B0EC24167253D 43A38FB0D0CA2BCBAE7B30B477CB2DA38030F20C6A42B73BBEAC01FA testpmd> show port 0 rss-hash key RSS functions: ipv4 ipv6 RSS key: 6D5A56DA255B0EC24167253D43A38FB0D0CA2BCBAE7B30B477CB2DA38030F20C6A42B7 3BBEAC01FA testpmd> ------ Fixes: 8205e241b2b0 ("app/testpmd: add missing type to RSS hash commands") Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- app/test-pmd/config.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index a70086c85a..25a4ec04a4 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -4546,11 +4546,12 @@ port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *hash_key, rss_conf.rss_key = NULL; rss_conf.rss_key_len = 0; - rss_conf.rss_hf = str_to_rsstypes(rss_type); + rss_conf.rss_hf = 0; diag = rte_eth_dev_rss_hash_conf_get(port_id, &rss_conf); if (diag == 0) { rss_conf.rss_key = hash_key; rss_conf.rss_key_len = hash_key_len; + rss_conf.rss_hf = str_to_rsstypes(rss_type); diag = rte_eth_dev_rss_hash_update(port_id, &rss_conf); } if (diag == 0) -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:19.184479169 +0800 +++ 0032-app-testpmd-fix-RSS-hash-key-update.patch 2025-06-26 19:59:17.338418046 +0800 @@ -1 +1 @@ -From 24e94a4c86c52f45a7a7c139e4e8484f3afe6d8f Mon Sep 17 00:00:00 2001 +From 31817dc08ead234519e36e00a40e968c2669d499 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 24e94a4c86c52f45a7a7c139e4e8484f3afe6d8f ] @@ -29 +31,0 @@ -Cc: stable@dpdk.org @@ -39 +41 @@ -index e89af21cec..c32e011fa6 100644 +index a70086c85a..25a4ec04a4 100644 @@ -42 +44 @@ -@@ -4806,11 +4806,12 @@ port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *hash_key, +@@ -4546,11 +4546,12 @@ port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *hash_key,