From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B9E446A63 for ; Thu, 26 Jun 2025 14:02:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 042964025D; Thu, 26 Jun 2025 14:02:27 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2054.outbound.protection.outlook.com [40.107.236.54]) by mails.dpdk.org (Postfix) with ESMTP id 53695400D6 for ; Thu, 26 Jun 2025 14:02:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fIxBrlIpNCfpDb/0bGlb+H0MBLwgOyudbVcPnPXX58J9EdrxxbunxDuR6bZCPB+LNQSeLQaDwrUQcNnuDRfNDZkaC655zsUdnpfNpv3ewKaDHALnSzxdOFPeUkccLS8+HUy2VUAI2WGKc/WCFD7LZL5NvCJ0qHLDEU8ApS8ythkjTniIml2K+RCs/SeFK8Gq87iUyCp2mawvPhCh/YTGRcXYpYksIPby7cFTCYkY6ytEIL/p3Yj56y03hCsIuHsoB+CDZCbJIYfQVYjMFqEoFr/Ogq2Puj757w4OyNqyP2qe6UuqX1zIlZZ8i554wy6H5zXNlRENi1iFPJ//VMLZDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HzQFf2FAYBRJ5DYkfnabMF780Vqte3XyeSTdBIBiS9c=; b=CUiAO71khZEztoFJgaofsZhhM4NGZhPsxHF73l0/yc/4sgbHiSR4KrZ118nZfhdcGiywISfB97XfzuRk3f3mbF4ZfIXhmt+5x48YoTFmLKqW9NRHrsryh1ExlgKUsJ+G7AXtF5R5G64lX2xM4jcc4L6WAYiwtTtVn8PHiyRYhc95efaswJcyQC7wxoC1PfLfOwi7FOIFbDXb8YVRQ8v5pt/1y1oPFG+qJhic69eqMlnB8mnosZ4iQCUXF9TDLbW795WlZ7el7CQCwpH6fC9P/KM0ZseZgEER7MKDRlwSf0rQN6gBXYKBivmKjnm10kpDnTYB6t5m4lkFgpt1pgEoQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HzQFf2FAYBRJ5DYkfnabMF780Vqte3XyeSTdBIBiS9c=; b=Rje1tKY+Xlb3Ag47DdSk7v4Uh+tSp8eUHIVGgXIUNeZPb5zNUKziTYmjDUVCX8dxUgVYR2blXzlHfLkpN81ga86rNWkVAig5ZdXU9RUM9fT7KUOY4vPpUjQ4gyCVRIjhFrVxGcOd0xzrIg1FaTtgVHtVzgLSLeftdvw9jGyN/2RkKcOxpmYgQQMOON/cMGJKQGDD8jRmF09HRfTS+ZA2tGMJRayzEPDRP8Ctb0A5kJERRf1kYNaAigDwgaGk+VhSe9sTAy3iwVWvsLEsBQODvK6RcOfKy80gnoxM2MMAyi9CeBuwM4JRVI4Ov6R0ScCBm7yikAii6uQHUz+UT/XPgg== Received: from DS7P220CA0025.NAMP220.PROD.OUTLOOK.COM (2603:10b6:8:223::22) by PH7PR12MB9128.namprd12.prod.outlook.com (2603:10b6:510:2f7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.29; Thu, 26 Jun 2025 12:02:23 +0000 Received: from CY4PEPF0000EE38.namprd03.prod.outlook.com (2603:10b6:8:223:cafe::84) by DS7P220CA0025.outlook.office365.com (2603:10b6:8:223::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.17 via Frontend Transport; Thu, 26 Jun 2025 12:02:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000EE38.mail.protection.outlook.com (10.167.242.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:02:22 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:02:02 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:02:01 -0700 From: Xueming Li To: Bruce Richardson CC: Xueming Li , Anatoly Burakov , dpdk stable Subject: patch 'net/ixgbe/base: correct definition of endianness macro' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:00:23 +0800 Message-ID: <20250626120145.27369-4-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE38:EE_|PH7PR12MB9128:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f905849-6996-410b-a60e-08ddb4a94f22 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700013|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YHrQgpj2Vjryn3ardXgWEv//8d9vegHiUg1QWPHj49ieG2qxwcWwu59kTIYL?= =?us-ascii?Q?ySqT4Lf/MqsVR+GlzH6rgQtY0n8x+bkgYQ4imDh5HdS4TeVdb0/q7oJwBUNl?= =?us-ascii?Q?qmMoahqf95X6khfAZF461aKsht0q4SJ8nMBRy8LCb5qAG02ZHYAhQ5JraZLS?= =?us-ascii?Q?yof/jYJp78MHqfw/nBb+tR0ORNGyJ63t7iEozH2j47notlYDaQHPWor5qIGY?= =?us-ascii?Q?+c8WbHGjn8thkz0X89IlgPihWz9QQATvd4GSbdYRRrWZbGIkldFKbHcMmDMY?= =?us-ascii?Q?Wdl+Rc6qzmQo9HBxR5FgpIvwNYrhnQrkawe62kj+2s5wkqrg6qyWfwU0MwcK?= =?us-ascii?Q?ioozJK+3owBynsUZewFjX412sJ1I6wOXkqnltluFoS9to8HhP32fcS1T0mcz?= =?us-ascii?Q?FtoxRLePWuU1UpBaQaOyqHgBRezxIrh7i4tCaljYpbowlF/8JibUII8xhI0R?= =?us-ascii?Q?5bSlZyWytzfzibhJ5Oqju6PhD9wTTncr0bndUuBX3PzDGfVFccp2Z4PKLupf?= =?us-ascii?Q?L2IytDi5mjv7cROzRk2kH4bg4dz9DX889POa091Xll8dYR+ElYGm4dUr1AYt?= =?us-ascii?Q?et+GoTaJTUiucjkQLyWz9TjZjXGhyXxEBLBLDURCF0QBgsQoCx+uCN9z1ubA?= =?us-ascii?Q?hf2caFVKGTvMEbSckmIi0x+Zpltjq5/mXY5JojTJbCJXA4dSzzfD82G8rI/w?= =?us-ascii?Q?TLX2ICg7FHv3/410YUaLStqlp0RDgsV0QwGNqJOt29NTD/IMPQpqFbRZvfFi?= =?us-ascii?Q?WzpYetHW2cfHSdy9Qn347fbKU1E/iRKzQnWVKAdHPwovW/XKoblGICsrvKit?= =?us-ascii?Q?H1RtviK3ADO6gjeyjrVlL0WKZF78IYMKWscv22ycvZWd+g7kTn1JHN2CUSST?= =?us-ascii?Q?mVCNLin2SfP73Ccw1f+nvxRBkypHYjmuv5yDSqMaWN5Aw+2CNvnaY42XCKTm?= =?us-ascii?Q?spj9ZuMbvRVwPF8XrdCPSUzUjFBOXDvoFvyhhP9JuXbXyI9pFCg2IZmzYUNo?= =?us-ascii?Q?tDjpVgXioW4G+U1cr+YCkjp7F/8Kx1ZJO0DoDegv+1P5eEUSXmoWCpGV7wgy?= =?us-ascii?Q?ZoMfGFKPpxKMbv545QsBz1Z2kI6orQj6Q+MAGvH5idE/LBvZTWtY4FPpaEc9?= =?us-ascii?Q?QKGsmSLT3hSQ+uNA5kaWyJUShiIT6OcXu6mGdOfaZgY2S+ttOv4lmXVqHMSu?= =?us-ascii?Q?7ZTy1OrdK7jsBqjkofZumewlMb7E4xm298Xisx4SgzwbmzFnh9ih6274Yms/?= =?us-ascii?Q?2qfXj1G+ykWBPIhqkaUOSrCGpeHYmb9qtsgrOmvab349zWvWIBfipthbSN6K?= =?us-ascii?Q?puvpgrBlOMczUU7deMdA+7c0oFbickiFGGog4J0QYIHStTyX6FYFDVXbWoqE?= =?us-ascii?Q?UIbJXEjza3Y3YRcXD2wAo1StL4aewI6xKlnEGWUgnkU3aI789GHxMsmeu1B1?= =?us-ascii?Q?qh5LV9zA7i1bGz0k7JfCpTUG48K11gn5KEWKc9SXO7KyicV5j9V3WcGPQ3Ny?= =?us-ascii?Q?FPSDVlYlQMtBl8EOZgidNaV2vqKtDFap3kfs+ttKUXnF7ZVToW563TF5iw?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:02:22.5491 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f905849-6996-410b-a60e-08ddb4a94f22 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE38.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9128 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=4179a77be427b0ac17ce3485d2c59d49f7b93862 Thanks. Xueming Li --- >From 4179a77be427b0ac17ce3485d2c59d49f7b93862 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 28 Mar 2025 11:16:15 +0000 Subject: [PATCH] net/ixgbe/base: correct definition of endianness macro Cc: Xueming Li [ upstream commit 3e7ea9ad5162876583e72de6061752810bdde0fe ] The definition of IXGBE_LE32_TO_CPUS macro is meant to modify the value in place - similar to the le32_to_cpus() macro in kernel. Fixing the definition allows us to remove some warning flags, and removes the need for the uintptr_t typecasts. Fixes: aa4fc14d2cee ("ixgbe: update base driver") Signed-off-by: Bruce Richardson Reviewed-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_common.c | 4 ++-- drivers/net/ixgbe/base/ixgbe_osdep.h | 2 +- drivers/net/ixgbe/base/meson.build | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c index aa843bd5c4..8c2c69e58f 100644 --- a/drivers/net/ixgbe/base/ixgbe_common.c +++ b/drivers/net/ixgbe/base/ixgbe_common.c @@ -4586,7 +4586,7 @@ s32 ixgbe_host_interface_command(struct ixgbe_hw *hw, u32 *buffer, /* first pull in the header so we know the buffer length */ for (bi = 0; bi < dword_len; bi++) { buffer[bi] = IXGBE_READ_REG_ARRAY(hw, IXGBE_FLEX_MNG, bi); - IXGBE_LE32_TO_CPUS((uintptr_t)&buffer[bi]); + IXGBE_LE32_TO_CPUS(&buffer[bi]); } /* @@ -4622,7 +4622,7 @@ s32 ixgbe_host_interface_command(struct ixgbe_hw *hw, u32 *buffer, /* Pull in the rest of the buffer (bi is where we left off) */ for (; bi <= dword_len; bi++) { buffer[bi] = IXGBE_READ_REG_ARRAY(hw, IXGBE_FLEX_MNG, bi); - IXGBE_LE32_TO_CPUS((uintptr_t)&buffer[bi]); + IXGBE_LE32_TO_CPUS(&buffer[bi]); } rel_out: diff --git a/drivers/net/ixgbe/base/ixgbe_osdep.h b/drivers/net/ixgbe/base/ixgbe_osdep.h index 6c25f608b1..72d45e2792 100644 --- a/drivers/net/ixgbe/base/ixgbe_osdep.h +++ b/drivers/net/ixgbe/base/ixgbe_osdep.h @@ -80,7 +80,7 @@ enum { #define IXGBE_CPU_TO_LE16(_i) rte_cpu_to_le_16(_i) #define IXGBE_CPU_TO_LE32(_i) rte_cpu_to_le_32(_i) #define IXGBE_LE32_TO_CPU(_i) rte_le_to_cpu_32(_i) -#define IXGBE_LE32_TO_CPUS(_i) rte_le_to_cpu_32(_i) +#define IXGBE_LE32_TO_CPUS(_i) do { *_i = rte_le_to_cpu_32(*_i); } while(0) #define IXGBE_CPU_TO_BE16(_i) rte_cpu_to_be_16(_i) #define IXGBE_CPU_TO_BE32(_i) rte_cpu_to_be_32(_i) #define IXGBE_BE32_TO_CPU(_i) rte_be_to_cpu_32(_i) diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/meson.build index f6497014da..ab775d8c66 100644 --- a/drivers/net/ixgbe/base/meson.build +++ b/drivers/net/ixgbe/base/meson.build @@ -17,7 +17,7 @@ sources = [ 'ixgbe_x550.c', ] -error_cflags = ['-Wno-unused-value', +error_cflags = [ '-Wno-unused-but-set-variable', '-Wno-unused-parameter', ] -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:17.875306624 +0800 +++ 0003-net-ixgbe-base-correct-definition-of-endianness-macr.patch 2025-06-26 19:59:17.158418053 +0800 @@ -1 +1 @@ -From 3e7ea9ad5162876583e72de6061752810bdde0fe Mon Sep 17 00:00:00 2001 +From 4179a77be427b0ac17ce3485d2c59d49f7b93862 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 3e7ea9ad5162876583e72de6061752810bdde0fe ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -17,3 +19,3 @@ - drivers/net/intel/ixgbe/base/ixgbe_common.c | 4 ++-- - drivers/net/intel/ixgbe/base/ixgbe_osdep.h | 2 +- - drivers/net/intel/ixgbe/base/meson.build | 2 +- + drivers/net/ixgbe/base/ixgbe_common.c | 4 ++-- + drivers/net/ixgbe/base/ixgbe_osdep.h | 2 +- + drivers/net/ixgbe/base/meson.build | 2 +- @@ -22,5 +24,5 @@ -diff --git a/drivers/net/intel/ixgbe/base/ixgbe_common.c b/drivers/net/intel/ixgbe/base/ixgbe_common.c -index d6425c5b78..fbc9605e4d 100644 ---- a/drivers/net/intel/ixgbe/base/ixgbe_common.c -+++ b/drivers/net/intel/ixgbe/base/ixgbe_common.c -@@ -4610,7 +4610,7 @@ s32 ixgbe_host_interface_command(struct ixgbe_hw *hw, u32 *buffer, +diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c +index aa843bd5c4..8c2c69e58f 100644 +--- a/drivers/net/ixgbe/base/ixgbe_common.c ++++ b/drivers/net/ixgbe/base/ixgbe_common.c +@@ -4586,7 +4586,7 @@ s32 ixgbe_host_interface_command(struct ixgbe_hw *hw, u32 *buffer, @@ -35 +37 @@ -@@ -4646,7 +4646,7 @@ s32 ixgbe_host_interface_command(struct ixgbe_hw *hw, u32 *buffer, +@@ -4622,7 +4622,7 @@ s32 ixgbe_host_interface_command(struct ixgbe_hw *hw, u32 *buffer, @@ -44,6 +46,7 @@ -diff --git a/drivers/net/intel/ixgbe/base/ixgbe_osdep.h b/drivers/net/intel/ixgbe/base/ixgbe_osdep.h -index cffc6a4ce8..6e5f7b4ae8 100644 ---- a/drivers/net/intel/ixgbe/base/ixgbe_osdep.h -+++ b/drivers/net/intel/ixgbe/base/ixgbe_osdep.h -@@ -83,7 +83,7 @@ enum { - #define IXGBE_LE16_TO_CPU(_i) rte_le_to_cpu_16(_i) +diff --git a/drivers/net/ixgbe/base/ixgbe_osdep.h b/drivers/net/ixgbe/base/ixgbe_osdep.h +index 6c25f608b1..72d45e2792 100644 +--- a/drivers/net/ixgbe/base/ixgbe_osdep.h ++++ b/drivers/net/ixgbe/base/ixgbe_osdep.h +@@ -80,7 +80,7 @@ enum { + #define IXGBE_CPU_TO_LE16(_i) rte_cpu_to_le_16(_i) + #define IXGBE_CPU_TO_LE32(_i) rte_cpu_to_le_32(_i) @@ -51 +53,0 @@ - #define IXGBE_LE64_TO_CPU(_i) rte_le_to_cpu_64(_i) @@ -57,5 +59,5 @@ -diff --git a/drivers/net/intel/ixgbe/base/meson.build b/drivers/net/intel/ixgbe/base/meson.build -index 7e4fbdfa0f..f8b2ee6341 100644 ---- a/drivers/net/intel/ixgbe/base/meson.build -+++ b/drivers/net/intel/ixgbe/base/meson.build -@@ -19,7 +19,7 @@ sources = [ +diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/meson.build +index f6497014da..ab775d8c66 100644 +--- a/drivers/net/ixgbe/base/meson.build ++++ b/drivers/net/ixgbe/base/meson.build +@@ -17,7 +17,7 @@ sources = [