From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B512046A63 for ; Thu, 26 Jun 2025 14:05:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B0351402D3; Thu, 26 Jun 2025 14:05:36 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2085.outbound.protection.outlook.com [40.107.236.85]) by mails.dpdk.org (Postfix) with ESMTP id D48B4402A8 for ; Thu, 26 Jun 2025 14:05:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O2iY6XnJzDbe3Myg2gGEzWqnfpLwxrSka3RUiCsdteBbPK+WgN++ApjDFiAhO0fxe0ZlIThugQKhAAhN1JK+OAstW5T5VvSpCuDijhFQ77YZaGFw/F9YzMzAxXkZ5MVHvEJVNiWHzW96iHWcxbqjM3ReQT6P+N4HJHZAQIH1MRsFLu68kTwkjRctJAKjpG2VwzAXqeq9s9FhBgnkoz/1qnfm53CpTIm61/z/w4zlCkzB1+WHWHjBj2+2XyjOHB6lSQE7Isxj/aVqvDngPXTaMtCxXoPXuDF3C5NiwsBqAsVhVMuQr3hEaKRHaEKhKorcKyy1vACkIQuewlXyx8/GfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1lKlphx+uAtlusooqy8VDuSvlt0RtYL/gzBfGTBPvU8=; b=NyJDJhktaVY+L5UADLttxOwKquNiVZ0Z6cyVqWbBFD8B/op8gZtlPIsv4ChlypvhWCmw+nVEujV+NUxuOKfcxkWk/ZWX3/ECwAkmfatDahHOWnvcE1hkNxR9tHJE24Gt6lQLf4hC/8ZyZiMJNDrqviL81EVGdM74b/Nz4svZ2NUi4Mxckp/Qge1b1G3Dbm7LkUFfZdZsMcjxwpetoU4c6aFtEuHzHbFB7fk3JHOVjNePP5aazlhGqC95pzr2TgIkbe/szO7RJjSNjIXTlvFzQAdnpOBiDfMQotxhZSPHqQd/iy1M0EWLjaCR5GKFkjbF6SGSsoS1s5qG65/Jbzugyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1lKlphx+uAtlusooqy8VDuSvlt0RtYL/gzBfGTBPvU8=; b=ItkCTvZ49nPBJh5M0XqpADdiwBVNmIc11sgrlPVHdDfBDTvPMRtcYvxh3ApsBItJIdu4Y20PN4tbeR3NNyWl1pz6f7izTjVG3WvXKNLgeXl9azZeyEqGts8xakQK33W+OKC6pXtwUI513s1BbCzcT77gYjYe6CehVscWAqForuYqr2cdVf9o4dtTcNwoKjd+fYKnfvHMDjl+0Z3tpVXte3yYsqIh6XXMX6Hqbna7gpoXIVP9JR1iTBz/GZyemILrhUwFRw6s4XfHYadIVlkwI7fZVZnp/IyDqHwomoIZ4mIdvDFo6G3FlHkf8l+MDHUpvTX9gePN4DDHfQeSitCEjA== Received: from BLAPR05CA0008.namprd05.prod.outlook.com (2603:10b6:208:36e::11) by MN0PR12MB5953.namprd12.prod.outlook.com (2603:10b6:208:37c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.23; Thu, 26 Jun 2025 12:05:33 +0000 Received: from MN1PEPF0000F0E0.namprd04.prod.outlook.com (2603:10b6:208:36e:cafe::41) by BLAPR05CA0008.outlook.office365.com (2603:10b6:208:36e::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8901.10 via Frontend Transport; Thu, 26 Jun 2025 12:05:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by MN1PEPF0000F0E0.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:05:32 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:05:15 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:05:13 -0700 From: Xueming Li To: Dengdui Huang CC: Xueming Li , dpdk stable Subject: patch 'net/hns3: fix divide by zero' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:00:59 +0800 Message-ID: <20250626120145.27369-40-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000F0E0:EE_|MN0PR12MB5953:EE_ X-MS-Office365-Filtering-Correlation-Id: 102d978b-ffef-40fa-0e23-08ddb4a9c07f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|36860700013|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?g520a7h+Px/dG/1QGGVYJWM8I2PoAu3zZFkamUGicrbSf5H+FlEJ+0vZspu6?= =?us-ascii?Q?LMOItHgj7aXnu6r/jaWb/N/3hmd4XNOzGXF3LtmVWLu5zM3BqYcsngm7NeDD?= =?us-ascii?Q?SKJ/5LCPjRtdCddCZ07X6K8wk7oZOKu1HPrqpwY0ZM3cWRTnDDXHssMD6QGS?= =?us-ascii?Q?hzHxz5q4RcvSQna2ZpBLADBvDIyGgWu0rp6xpTcbyStrKYUEJPBLcXsGQHvO?= =?us-ascii?Q?cauDFIeCMFHU5fuC/uu1IJEiG+NEZ8ALWfwxwOqhMZHVjwCCgvJO7yewBlZv?= =?us-ascii?Q?AuWRNksUIv/9IaBx4D71eteEdFoCRvfB+yKpj5plPjBc57888GWnAJPyHY67?= =?us-ascii?Q?yvWH0vEgslH/q3irTsfMN6YYjlaWa4n0Pzn9Dl/IslQoH1klH5AoKl/gynEQ?= =?us-ascii?Q?Bqaf6omgYzrihIubSuikXNBP9QebZB8aBy8FbtSDbuLKh33/WnbR7GfDCVCw?= =?us-ascii?Q?q5xaeOaN2Kje41mjfTwEe/IQVn7vP8TbuNV/sOElvUdQ2UnxIfVkn1t4xLLv?= =?us-ascii?Q?y+SiO+cT0/KjCz1rl8LieNKT9ZXLD4gKgaS6UYwJ8bL9sn0cH9pXrCZXNWEo?= =?us-ascii?Q?qlGQmPVKfkVYhjyj3txKUyBI9Q36Pq5uxkUnknve5n2UqrRgATUtiExEZqVc?= =?us-ascii?Q?W2vqMsbqAxsN2uwDukxHEnJ9ZKKOfungJ89Z/WL5KGLQB3O6DC1E0rM7Spp2?= =?us-ascii?Q?6P1g9RUBen5s92T5Ffj0m2VVxFMA+dCbIFFKeKwamsY42XsFQ2nIAiHgotsS?= =?us-ascii?Q?29rCoTkm0pyhGpmZ3K7hemsGF/Tk+pTr5FsxcYnDO9GM7USoNi4PPPgPljpm?= =?us-ascii?Q?yHgwqGBEqK6qEHyFpssZCZSOWSb/UHBr6zaCtx1CDJ8YqgxxPJb+PgO2fKiA?= =?us-ascii?Q?1O+Mfh1ynAy2h4nthy9o8VQa6dGs0v6elrmTkeSuDfdZoC1A0Ofwe+5GHavT?= =?us-ascii?Q?wvn+7cFbkyoRtvp+80LZlvCMNChZkBWHZy9fg3aO0IGClHf1dRMxDQ3/5zv5?= =?us-ascii?Q?5+TgSaWLzMaL6V23hbui6BI1NikCQnG/tuKHMH0FZwvsBY5mNFenaMCFMHVj?= =?us-ascii?Q?MAgrC1boePck+C2KLK72vKl1LqdMG1doBeQLKFqQZlmX4M7Xeodujatel3WX?= =?us-ascii?Q?PyyR2Aw6NcGyHVXY8VD8LUM7iw9OurwYZrvkAnT/BQM4TAPieKXeRVbbcdeT?= =?us-ascii?Q?QwdsnP39rUEoBGJuVtPSyWMhbjXAA6nB5Fjap31h6kDSC781u+Q/OeTDq48H?= =?us-ascii?Q?4h9yEH58qyhA4CWpfZhFphqvCwtL3mkmeg6FxXro2Ysc2+eb8QrvGT/ToCA8?= =?us-ascii?Q?IyicPzzoKOeQR21XlrmyxHtf9B/Guiili4Kkt9UO4X33Q2SWCmd2pi3E7jvI?= =?us-ascii?Q?9z2Rpt9/xdmqDcIlX2ztrveWRy0GvDWnzTRFxJUOxVSkSeSjvukSm3IhktaX?= =?us-ascii?Q?7uxEe5whfEgQ9k87r5RyRMqiPURjA6StiH1nFaRp/7NyR83mp2VgJQKLdw6i?= =?us-ascii?Q?FNtpNDQHZpJH6Yhm5ePyAJIHyIIqPpTUfybhvbglxcQY58UUR9NCgKyjnA?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:05:32.6595 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 102d978b-ffef-40fa-0e23-08ddb4a9c07f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000F0E0.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5953 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=307bf0ec7685be9f7007450a427472f000848261 Thanks. Xueming Li --- >From 307bf0ec7685be9f7007450a427472f000848261 Mon Sep 17 00:00:00 2001 From: Dengdui Huang Date: Tue, 8 Apr 2025 16:30:59 +0800 Subject: [PATCH] net/hns3: fix divide by zero Cc: Xueming Li [ upstream commit a88f60f32de6f94a5acbf2101cb5e527fac0b2d2 ] Driver may encounter divide-by-zero if the total_tqps_num and rss_size_max in hw structure from firmware are zero. So add some verification to them. Fixes: d51867db65c1 ("net/hns3: add initialization") Signed-off-by: Dengdui Huang --- drivers/net/hns3/hns3_ethdev.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index 5fa288bf2f..541f086443 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/drivers/net/hns3/hns3_ethdev.c @@ -2544,6 +2544,10 @@ hns3_query_pf_resource(struct hns3_hw *hw) req = (struct hns3_pf_res_cmd *)desc.data; hw->total_tqps_num = rte_le_to_cpu_16(req->tqp_num) + rte_le_to_cpu_16(req->ext_tqp_num); + if (hw->total_tqps_num == 0) { + PMD_INIT_LOG(ERR, "the total tqp number of the port is 0."); + return -EINVAL; + } ret = hns3_get_pf_max_tqp_num(hw); if (ret) return ret; @@ -2795,6 +2799,7 @@ hns3_check_media_type(struct hns3_hw *hw, uint8_t media_type) static int hns3_get_board_configuration(struct hns3_hw *hw) { +#define HNS3_RSS_SIZE_MAX_DEFAULT 64 struct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw); struct hns3_pf *pf = &hns->pf; struct hns3_cfg cfg; @@ -2813,6 +2818,11 @@ hns3_get_board_configuration(struct hns3_hw *hw) hw->mac.media_type = cfg.media_type; hw->rss_size_max = cfg.rss_size_max; + if (hw->rss_size_max == 0) { + PMD_INIT_LOG(WARNING, "rss_size_max is 0, already adjust to %u.", + HNS3_RSS_SIZE_MAX_DEFAULT); + hw->rss_size_max = HNS3_RSS_SIZE_MAX_DEFAULT; + } memcpy(hw->mac.mac_addr, cfg.mac_addr, RTE_ETHER_ADDR_LEN); hw->mac.phy_addr = cfg.phy_addr; hw->dcb_info.num_pg = 1; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:19.409427860 +0800 +++ 0039-net-hns3-fix-divide-by-zero.patch 2025-06-26 19:59:17.366418045 +0800 @@ -1 +1 @@ -From a88f60f32de6f94a5acbf2101cb5e527fac0b2d2 Mon Sep 17 00:00:00 2001 +From 307bf0ec7685be9f7007450a427472f000848261 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit a88f60f32de6f94a5acbf2101cb5e527fac0b2d2 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ -index 2b56b6e44e..2d4e348442 100644 +index 5fa288bf2f..541f086443 100644