From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76FBA46A63 for ; Thu, 26 Jun 2025 14:05:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FCF9400D6; Thu, 26 Jun 2025 14:05:59 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2076.outbound.protection.outlook.com [40.107.236.76]) by mails.dpdk.org (Postfix) with ESMTP id 98BCD402DB for ; Thu, 26 Jun 2025 14:05:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MnfYXVgtEKQg48jyI2Phjn0Bydh6Owi3FFhsedbZWsPAOXSUa6CETOgbaCZIcbkr3/Az7LqBQj9fnr0KE0lZnNQ8qMx2ILJme5O529ejMRiAyXRYHb3nWCxSte8GzAv/xVfe+On9ctQIZQm8L0rgpb2nZUb0wYJiHX+ditSDK8rh5M5V6A9hFbKuCCWZq2kWCvn7ajTJITwHdnmyNov8KrPbY4Vpe01qEf1encR4aKykLxku6j0B9PyEErDIahtTR87ZObf2a32mDsOkVPqRIdvzkeGDJC+0+UFbCQSriLGMXLMuhVxMISV5RWbiB9EZ5u3xKH7fTRWOgVce2UK5xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D0zWzgIgYjxiIptYTf9JY6yG6NQYcBi1QngyJaG50Kk=; b=Bl9oQuoaZrxrH/HaJBYiVWGSzmVBq0I7k2HnotYKfPB7veONCv+i2A3xnNB+qGtZP6SowPcLgSdQAC1QY78JvtyxllGbAl1WeAoaHwO5N+TQMKEc8mv5u23XEGT/rQM1A123PMPE+f4x2ZUd0TjzT1hDehrGQt5U6AsYIzTLycu/VAIG58E6IHAOosD6fTBewrh9NB77auoFoi68YU19yOpcGC22urPsqiDzSBbnHDhtZw5/wDuc1ntIUmYSnDtjmg9hfpZBSjPqOobjlBAP9JTBVQyjYbPZO3I2b6cYZ3Gp19PYOqPSoN9wJZwoz5sTpTXkfnR3aHdxk3gB63sPBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D0zWzgIgYjxiIptYTf9JY6yG6NQYcBi1QngyJaG50Kk=; b=Luj9Y3G4QzJJQIfisvfk2PFZGt5tPU3/dtf57Ep0H5Q08MmQo2abIAHHSlutaNV1UL+N3+UXy3OjQMJ7CVG0+uJ9UJbs5fRFw8d6xPiXh5BlNNribyxHTd5hr4bYq/7AjnOcHuDlwLT9Wafu2oc8/cmwp7VfeCYUr0D1F6mJelPgM9QVSmcdpJ5qUiUKcgztKXJM9qb9aF2m2+EkUP0CzZ4H39ViFw8njcXD4PJo7d28RIsD65L4W2obl0yGMW408kKsP8+5U3lEeMZt4Ks9hP1X3jmwaRNVyuX9h9V6zdWUuZYZNQ+ZBC3arb6cN6cDFyxwSN4ksIRyYcpEuiSCdw== Received: from SJ0PR03CA0162.namprd03.prod.outlook.com (2603:10b6:a03:338::17) by DS7PR12MB8231.namprd12.prod.outlook.com (2603:10b6:8:db::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.23; Thu, 26 Jun 2025 12:05:55 +0000 Received: from SJ5PEPF000001D0.namprd05.prod.outlook.com (2603:10b6:a03:338:cafe::43) by SJ0PR03CA0162.outlook.office365.com (2603:10b6:a03:338::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.20 via Frontend Transport; Thu, 26 Jun 2025 12:05:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001D0.mail.protection.outlook.com (10.167.242.52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:05:55 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:05:41 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:05:39 -0700 From: Xueming Li To: Stephen Hemminger CC: Xueming Li , dpdk stable Subject: patch 'net/qede: fix use after free' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:01:03 +0800 Message-ID: <20250626120145.27369-44-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D0:EE_|DS7PR12MB8231:EE_ X-MS-Office365-Filtering-Correlation-Id: ba104396-7025-42c0-5ff2-08ddb4a9cdb7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|376014|82310400026|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?x6Mk4ue2zs0k1QMePcYiy9MAMfylVdZqPGeLlPXSVU4fDDoJ4d0D70sMiILx?= =?us-ascii?Q?fK3FaCwNzyYLuhHCMnoFwn2CPVXXowaq+ZSV9aIK9I06j5ByMvM3BSCztQ8D?= =?us-ascii?Q?ToqmaQuCQCebKl9AvDRyZAr6+m3N+JDpBSd2Qrnxt2iO56/uh90zWo1AjFVo?= =?us-ascii?Q?rQe0vke1D80E0aucYLdRGAyk6v4H991HIBdeINFSFfzAYA8PNJZl/JlN+SZV?= =?us-ascii?Q?JfOo1WyGbCicNftMdA5BPEI6xNvfEDvxK1X3z9arcrrk83PV95H27WBB9xK2?= =?us-ascii?Q?eCkJDs153WS3xDEYV5KlJ0Og+Va5M8aac39h/pPejpF9pOYNDFUuXUaATFnR?= =?us-ascii?Q?JJ6+rJKbZGueJ+ZCUqoWFcLgYQ2UNPvI0DBO+sCgInY5hvCH2rdJrQfvk2k7?= =?us-ascii?Q?EO36+DITfvql+4JjwN1Q9KJGjGXQUBZ0ACgm3VzgkO5rOvFQEHO0rpGSE1tq?= =?us-ascii?Q?rWMxKtn9DziddSpC9JucRRCnY2rjpibv6pIQvxp/BdGiTNRrstEPaTjMOdQU?= =?us-ascii?Q?cV9T/hkHqyHBkX/mmPiOh+1uG6MeNRnKai/bHWWpJnFrJaLwjmvn/OKPIfFq?= =?us-ascii?Q?za9hmnbboHbR1DaXaXTSzQIz1YMHwrmBcs7QquP9RVeWD6yvlzCxJ+7EdDnU?= =?us-ascii?Q?WryGyNuBpxS8L9HKMGb5ldwWX4YSCGqEqjvYWdN/oI6qWUAho/nv4t9253U9?= =?us-ascii?Q?G7O8CY/qm//mJah06X307qFpKQmNnKOSrg1HixCR3s4IIImpxMmynA8hetzU?= =?us-ascii?Q?MXggTi4VZuzwJIoNrfdAw24bX3oIFV+b57r/Zz5rxwzRdWfkg9RdidfnpIGV?= =?us-ascii?Q?k+DgBl6NfujLyijAtsKNfKVFIClm/dxiWGY86Tnay+EnF04zuoBQqLfoVf2L?= =?us-ascii?Q?2Q2O3ZZqgn4OsV13D+zTmsMt5yqQRKEPhFjaTK4H8CV69u/9vKrnL3Uq6Rpp?= =?us-ascii?Q?t89cXFX6YAbJNLPYimR8IzH5arB/uwRD1VGrXZb1VE6EJrlPINSPvgANaiJw?= =?us-ascii?Q?jy9fmGamDKMKyB19zEzJTUMT1oJA+VFYbAVZtaXlG2BsVE1MSQ0gPoMgvIU5?= =?us-ascii?Q?bNe1Nxj2q+xdOkh1QIXxB1hdhqANLsByZmuvGeagYrOndhGeRaHluxvImg5t?= =?us-ascii?Q?KHCweK6mBIHIYGqPNwqJN2eCgKVNP1yjrJll43Gf1rF2gKiHS7OylX3lFrlq?= =?us-ascii?Q?rSQnB9yyTj6bWZmLWC70J4Al6AmUVqKFLNKmxx3z1iNZWcNqMgK49zvqOXeD?= =?us-ascii?Q?JknTC9+/KQYY0xsBBfyYv5PMYekpkicaykv1kYQosdHvbcJQPPBCS/d9+jX7?= =?us-ascii?Q?av/AglDz0I+Y+/IMFmIccfR1bJ9jVMDlWb1CSZJmQZbAj346doGbgU4E/ZOC?= =?us-ascii?Q?9Y9oQYolBtKUCTGj76rgz7JtEWD6g17S/v5GeIyJ3yeHWU3TqZtIkGa5asRl?= =?us-ascii?Q?5SSdp6xsYKl+Evru7hU3DIPlwphbDv65b2AqT9gNbtoFhRC4EF5xhXSuwZby?= =?us-ascii?Q?VBNaBz4lmJajtFfP6Ki++/tEwG4RYJB+uyIBwwksAZQuZeKzVL416SV/NQ?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:05:55.0025 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ba104396-7025-42c0-5ff2-08ddb4a9cdb7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D0.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8231 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=f7c324657056f1fad001c3fd1f153a02b2c2ec81 Thanks. Xueming Li --- >From f7c324657056f1fad001c3fd1f153a02b2c2ec81 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 13 Mar 2025 10:22:03 -0700 Subject: [PATCH] net/qede: fix use after free Cc: Xueming Li [ upstream commit ab8caba639ee6378055b2d8518e2a97b2212c737 ] The loop cleaning up flowdir resources was using SLIST_FOREACH but the inner loop would call rte_free. Found by building with address sanitizer undefined check. Also remove needless initialization, and null check. Fixes: f5765f66f9bb ("net/qede: refactor flow director into generic aRFS") Signed-off-by: Stephen Hemminger --- drivers/net/qede/qede_filter.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c index e547b24a73..90f8b89681 100644 --- a/drivers/net/qede/qede_filter.c +++ b/drivers/net/qede/qede_filter.c @@ -12,6 +12,13 @@ #include "qede_ethdev.h" +#ifndef SLIST_FOREACH_SAFE +#define SLIST_FOREACH_SAFE(var, head, field, tvar) \ + for ((var) = SLIST_FIRST((head)); \ + (var) && ((tvar) = SLIST_NEXT((var), field), 1); \ + (var) = (tvar)) +#endif + /* VXLAN tunnel classification mapping */ const struct _qede_udp_tunn_types { uint16_t rte_filter_type; @@ -154,16 +161,13 @@ int qede_check_fdir_support(struct rte_eth_dev *eth_dev) void qede_fdir_dealloc_resc(struct rte_eth_dev *eth_dev) { struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev); - struct qede_arfs_entry *tmp = NULL; + struct qede_arfs_entry *tmp, *tmp2; - SLIST_FOREACH(tmp, &qdev->arfs_info.arfs_list_head, list) { - if (tmp) { - if (tmp->mz) - rte_memzone_free(tmp->mz); - SLIST_REMOVE(&qdev->arfs_info.arfs_list_head, tmp, - qede_arfs_entry, list); - rte_free(tmp); - } + SLIST_FOREACH_SAFE(tmp, &qdev->arfs_info.arfs_list_head, list, tmp2) { + if (tmp->mz) + rte_memzone_free(tmp->mz); + SLIST_REMOVE(&qdev->arfs_info.arfs_list_head, tmp, qede_arfs_entry, list); + rte_free(tmp); } } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:19.538770654 +0800 +++ 0043-net-qede-fix-use-after-free.patch 2025-06-26 19:59:17.382418044 +0800 @@ -1 +1 @@ -From ab8caba639ee6378055b2d8518e2a97b2212c737 Mon Sep 17 00:00:00 2001 +From f7c324657056f1fad001c3fd1f153a02b2c2ec81 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit ab8caba639ee6378055b2d8518e2a97b2212c737 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -17,2 +19,2 @@ - drivers/net/qede/qede_filter.c | 20 ++++++++++++-------- - 1 file changed, 12 insertions(+), 8 deletions(-) + drivers/net/qede/qede_filter.c | 22 +++++++++++++--------- + 1 file changed, 13 insertions(+), 9 deletions(-) @@ -21 +23 @@ -index 14fb4338e9..cecb58c997 100644 +index e547b24a73..90f8b89681 100644 @@ -38 +40 @@ -@@ -154,15 +161,12 @@ int qede_check_fdir_support(struct rte_eth_dev *eth_dev) +@@ -154,16 +161,13 @@ int qede_check_fdir_support(struct rte_eth_dev *eth_dev) @@ -47 +49,2 @@ -- rte_memzone_free(tmp->mz); +- if (tmp->mz) +- rte_memzone_free(tmp->mz); @@ -53 +56,2 @@ -+ rte_memzone_free(tmp->mz); ++ if (tmp->mz) ++ rte_memzone_free(tmp->mz);