From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 508C646A63 for ; Thu, 26 Jun 2025 14:02:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A8F74026F; Thu, 26 Jun 2025 14:02:34 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2044.outbound.protection.outlook.com [40.107.237.44]) by mails.dpdk.org (Postfix) with ESMTP id 4A1E5400D6 for ; Thu, 26 Jun 2025 14:02:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D4xOQ2vFE5HbQcnK+m67UwjlcCG9nrp+LbdMOaE0xKhwy7c7rhpUOD8wfIGKPebshSCrzgC//1QIOqsIONqKTMZNqNnkVfPTh5v8Sxv0RZvjKSB65h2CBjml3jl/74m/Z3mIYtmiJIrQ5fr0Fp1BhgWV9kfctyHipuKU1L2LrSii+9MI3TelEcrLVFjV5wSQMCs+3aaDIQWctQ4b53nlAV4XMjp7mx5wg6yS1MYWCYNoiLbwyOzhYK0LgRBCGVg9HkBiQgg+wKNOJhrrsl/Ln86y16dQZQ3D9QylU0Xe4EqEe846lYOUDiQKAahlJ+IVYlX9P4KxjWkLgzMEDSN7LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ACPSnDsmnGikPAHcbEeAzwd0kVBTMp0wbHl4gHISB3E=; b=oqTnli7hwhaFx7zodK22cddWlEPNIHo/qOLROfH9CiEsWbtddQ1d3w3ACRYucUKmyMCsiolnVTYcFrcVw84MzoD5QRiwO6rfokv9FsCzi2/PqW4hL8Ci8DUgI6J6AGsNq9zhVP9xRZre2DO/f3O1eeHIW4J1HIxQ+5PoGBC4JNe2fKIWuRPznyh2bULZoQBiCH0VKOxCRqSzFLFfevE2cWIYF6FydD0rgw5H1HIilS0MFCvbBeGiRTRjwaf6UZxMPbYL7lKWDX/BQdSgXnyvLvzJkQ+bIsPpjzbr02pENrbPgowAgDEpJVjGzD2U5XBGl8fnzEwkHpuVi5Kjlt0bqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ACPSnDsmnGikPAHcbEeAzwd0kVBTMp0wbHl4gHISB3E=; b=RpRjvH5VpRDtQgdBVEAnWfId08yT1OYrpj85iNbxpDwsoRDEnf+Z3X4zG8mcGFGP3YED9yPqZFfMU3EWZP9+ziTOxZ8nVUHhpU+3HhdC17/gPqZ7gdgBtZv86zlEkzXoZRIZdnPrTfrXrWnTsa7nlvnLY7wtqQ58hx25AHW4OptT1cHsfDkBdt6PXsQMmHnSsqt5932vCxqOi9LibuPzvrKiVfSdpiWaQKLn4xaHuqbYe64ae4Sv+jF7rlfxSY3pB6yY+5qkHqcHr/BYXmeToHIg4zZ/x34Mrh4C7CtXMxF6+4+GOyQn4kM74H5VtZGVAJXILdlns2wAMgZfgzXGFQ== Received: from CYZPR05CA0029.namprd05.prod.outlook.com (2603:10b6:930:a3::28) by SA5PPF0EB7D076B.namprd12.prod.outlook.com (2603:10b6:80f:fc04::8c5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.19; Thu, 26 Jun 2025 12:02:29 +0000 Received: from CY4PEPF0000FCC5.namprd03.prod.outlook.com (2603:10b6:930:a3:cafe::c) by CYZPR05CA0029.outlook.office365.com (2603:10b6:930:a3::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8901.9 via Frontend Transport; Thu, 26 Jun 2025 12:02:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000FCC5.mail.protection.outlook.com (10.167.242.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:02:29 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:02:04 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:02:02 -0700 From: Xueming Li To: Bruce Richardson CC: Xueming Li , Anatoly Burakov , dpdk stable Subject: patch 'net/ixgbe/base: fix compilation warnings' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:00:24 +0800 Message-ID: <20250626120145.27369-5-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCC5:EE_|SA5PPF0EB7D076B:EE_ X-MS-Office365-Filtering-Correlation-Id: d6c4eaa9-dfc2-4483-b481-08ddb4a95336 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|82310400026|36860700013|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5xnCYdmHXmyK33S29kJw0ZUN9CUJ/6uPJsV70WTyWYOxhE8PGM/FFF5CHQ2q?= =?us-ascii?Q?ds4kpwfMyLeC+ogEfRYpGalmdG06Gqbx1Vj01OYeHs5oL7MLHC6Mi1Tpbuk2?= =?us-ascii?Q?E7ix8t1BNHCegwCrm8eCGBfl/dXQaQEOAQuZGCzrr7/wqr3okoK3v10MqAI2?= =?us-ascii?Q?xNk3KQOFajjry+hbqe5t9pWsBzH2eivwdajC77TPxb52FtXi61Hfjq3NjbvK?= =?us-ascii?Q?dGbkcSTs3mEB9SmH9+zqUbPSWjkM+6zzTXes28UUWQNwCSXUCL0YBBKtvuxa?= =?us-ascii?Q?VLPk6ZO4+gaARnNIlfsNAiW5MjrhS0/Yv5fnxLJcGj/BrmYMzMzn2H4K0PoP?= =?us-ascii?Q?wJ0QDpOJvBwZLOJnXGns8Y70oFaQa/yLMUSS78I60QU/YSAjvt4WQClX1Y91?= =?us-ascii?Q?UxU8ySnqlyCNcJIoclu7O4IVOE2r7aFoOy1RPBvf+AIqNanddWKWa85ZPrEY?= =?us-ascii?Q?5BAPlkrJEVl38Jb6+I7fc9pNIEJYxF6zNPf49H0oUMec4Mt7JjMKmZ4GDcBz?= =?us-ascii?Q?oLITRoxO3zr/m2JhLhbK351nFgjpOsKkSq64ZQ+6hGCiblqR48BT3VTgKRZY?= =?us-ascii?Q?zUw0Uwg1AVU6aNEEZJmS17JmCrc2rchRcMV8RA2TejdeuBlBcna3xRhveWqe?= =?us-ascii?Q?SvTbxSIL3NUhyQc6F+FV8N5FeJiRDQBXgDfTR5uqmsjz8Os6arY2fA33R6eK?= =?us-ascii?Q?c9cMS4Cz27L1hXQ7OSlj9EBNJJeBIDemE+ofZtKMNts6PVVKZFmogDq8r5eF?= =?us-ascii?Q?89okOCW3xKePUrtUaqAAEG4sBI87I9Rk0qCDv5Ol5alGUty6scbRVEwmqA2h?= =?us-ascii?Q?Sn06AqzpsCGQ7e7uCxIA3JpMJJCnh5NcdRlTSbvKbnuQbEEKYT8sMfpSyx9y?= =?us-ascii?Q?a7n43qeFgssWmtZVkOsT/PsFEWAu52NJP9AgUw+ZiPzEPotdMhA44X/Ih7UJ?= =?us-ascii?Q?qH3i6ImWBxYFnRBHd06JphTGDXsnue+ROpmSny4SpylFljufNYHNpMfoHIiw?= =?us-ascii?Q?uAK4ikLxJba8wfebsbbNq1ZgMHM9iZN1oVHK6SPp4SIOye6/fOBrkXal/b8D?= =?us-ascii?Q?tSHYgg1u/KnIIw5JGi20/+F0Og+FSsArarxL2Q9C0Lxn4466J9Q90tCFGRVK?= =?us-ascii?Q?URdfmZwD3cOfzp5gVU4mJq76Q3/BdC1RHB6DIXot0tynr0Fbyojq1G6X5yG2?= =?us-ascii?Q?Tr/AVSAq2TBnjuC9XBawz/HNtOIBPel+3qXw5f67rsh8X/wVPYofy7iNAY5E?= =?us-ascii?Q?rFBd19SRvJWVxK7XuvZLFVITw4OASA3mrge3P0eDUOk2DNL6XOg9VDLy587g?= =?us-ascii?Q?kHVgigYGkAKCUgrc/xRy2tJSBvOFJ23VR4dSmxOVZb8bFGLHwkMePTTrGmKg?= =?us-ascii?Q?8Lwuayu/7tZJ3gzFyc9Uw7urqkjTNP1jSq01S5n8eUdfyIiCWW9zfnopRXMw?= =?us-ascii?Q?+OhmvkfyMSGr3sLGoqGIVwWcVobdZunuVabWkK8zlHFcASzEvQJB2g4hVYUt?= =?us-ascii?Q?nIbJ69i1UJb6HI25glHs62Z25als5JVyMyt0TiTkbQixjwLUCiVdImtM6Q?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(376014)(82310400026)(36860700013)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:02:29.3473 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d6c4eaa9-dfc2-4483-b481-08ddb4a95336 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCC5.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA5PPF0EB7D076B X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=81f196974f65a4f4ed67c362c8aee19bf8342dd3 Thanks. Xueming Li --- >From 81f196974f65a4f4ed67c362c8aee19bf8342dd3 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 28 Mar 2025 11:16:16 +0000 Subject: [PATCH] net/ixgbe/base: fix compilation warnings Cc: Xueming Li [ upstream commit ca361b5ab1ba8ec9191b8376a8be0e3935823596 ] We can remove almost all of the "unused parameter" and "unused variable" warnings by just improving the macro definitions in the osdep.h header. Remaining two instances can be fixed by just one-line additions to the code, so add those to give us a clean build with the warnings enabled. Fixes: af75078fece3 ("first public release") Fixes: c6cb313da739 ("net/ixgbe/base: add link management for E610") Signed-off-by: Bruce Richardson Acked-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_osdep.h | 19 +++++++++++-------- drivers/net/ixgbe/base/meson.build | 11 ----------- 2 files changed, 11 insertions(+), 19 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_osdep.h b/drivers/net/ixgbe/base/ixgbe_osdep.h index 72d45e2792..d8640dc7e6 100644 --- a/drivers/net/ixgbe/base/ixgbe_osdep.h +++ b/drivers/net/ixgbe/base/ixgbe_osdep.h @@ -56,13 +56,16 @@ /* Bunch of defines for shared code bogosity */ #ifndef UNREFERENCED_PARAMETER -#define UNREFERENCED_PARAMETER(_p) +#define UNREFERENCED_PARAMETER(_p) (void)(_p) #endif -#define UNREFERENCED_1PARAMETER(_p) -#define UNREFERENCED_2PARAMETER(_p, _q) -#define UNREFERENCED_3PARAMETER(_p, _q, _r) -#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) -#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) +#define UNREFERENCED_1PARAMETER(_p) (void)(_p) +#define UNREFERENCED_2PARAMETER(_p, _q) do { (void)(_p); (void)(_q); } while(0) +#define UNREFERENCED_3PARAMETER(_p, _q, _r) \ + do { (void)(_p); (void)(_q); (void)(_r); } while(0) +#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) \ + do { (void)(_p); (void)(_q); (void)(_r); (void)(_s); } while(0) +#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) \ + do { (void)(_p); (void)(_q); (void)(_r); (void)(_s); (void)(_t); } while(0) /* Shared code error reporting */ enum { @@ -127,8 +130,8 @@ static inline uint32_t ixgbe_read_addr(volatile void* addr) IXGBE_PCI_REG_ADDR((hw), (reg) + ((index) << 2)) /* Not implemented !! */ -#define IXGBE_READ_PCIE_WORD(hw, reg) 0 -#define IXGBE_WRITE_PCIE_WORD(hw, reg, value) do { } while(0) +#define IXGBE_READ_PCIE_WORD(hw, reg) ((void)hw, (void)(reg), 0) +#define IXGBE_WRITE_PCIE_WORD(hw, reg, value) do { (void)hw; (void)reg; (void)value; } while(0) #define IXGBE_WRITE_FLUSH(a) IXGBE_READ_REG(a, IXGBE_STATUS) diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/meson.build index ab775d8c66..b3cd74e805 100644 --- a/drivers/net/ixgbe/base/meson.build +++ b/drivers/net/ixgbe/base/meson.build @@ -17,17 +17,6 @@ sources = [ 'ixgbe_x550.c', ] -error_cflags = [ - '-Wno-unused-but-set-variable', - '-Wno-unused-parameter', - ] -c_args = cflags -foreach flag: error_cflags - if cc.has_argument(flag) - c_args += flag - endif -endforeach - base_lib = static_library('ixgbe_base', sources, dependencies: [static_rte_eal, static_rte_net], c_args: c_args) -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:17.916502122 +0800 +++ 0004-net-ixgbe-base-fix-compilation-warnings.patch 2025-06-26 19:59:17.162418053 +0800 @@ -1 +1 @@ -From ca361b5ab1ba8ec9191b8376a8be0e3935823596 Mon Sep 17 00:00:00 2001 +From 81f196974f65a4f4ed67c362c8aee19bf8342dd3 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit ca361b5ab1ba8ec9191b8376a8be0e3935823596 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -18,4 +20,3 @@ - drivers/net/intel/ixgbe/base/ixgbe_e610.c | 2 ++ - drivers/net/intel/ixgbe/base/ixgbe_osdep.h | 19 +++++++++++-------- - drivers/net/intel/ixgbe/base/meson.build | 11 ----------- - 3 files changed, 13 insertions(+), 19 deletions(-) + drivers/net/ixgbe/base/ixgbe_osdep.h | 19 +++++++++++-------- + drivers/net/ixgbe/base/meson.build | 11 ----------- + 2 files changed, 11 insertions(+), 19 deletions(-) @@ -23,25 +24,5 @@ -diff --git a/drivers/net/intel/ixgbe/base/ixgbe_e610.c b/drivers/net/intel/ixgbe/base/ixgbe_e610.c -index 5474c3012a..7420c78d07 100644 ---- a/drivers/net/intel/ixgbe/base/ixgbe_e610.c -+++ b/drivers/net/intel/ixgbe/base/ixgbe_e610.c -@@ -1054,6 +1054,7 @@ static void ixgbe_parse_vsi_func_caps(struct ixgbe_hw *hw, - struct ixgbe_hw_func_caps *func_p, - struct ixgbe_aci_cmd_list_caps_elem *cap) - { -+ UNREFERENCED_PARAMETER(cap); - func_p->guar_num_vsi = ixgbe_get_num_per_func(hw, IXGBE_MAX_VSI); - } - -@@ -1770,6 +1771,7 @@ s32 ixgbe_aci_set_event_mask(struct ixgbe_hw *hw, u8 port_num, u16 mask) - struct ixgbe_aci_cmd_set_event_mask *cmd; - struct ixgbe_aci_desc desc; - -+ UNREFERENCED_PARAMETER(port_num); - cmd = &desc.params.set_event_mask; - - ixgbe_fill_dflt_direct_cmd_desc(&desc, ixgbe_aci_opc_set_event_mask); -diff --git a/drivers/net/intel/ixgbe/base/ixgbe_osdep.h b/drivers/net/intel/ixgbe/base/ixgbe_osdep.h -index 6e5f7b4ae8..398c38bffd 100644 ---- a/drivers/net/intel/ixgbe/base/ixgbe_osdep.h -+++ b/drivers/net/intel/ixgbe/base/ixgbe_osdep.h -@@ -57,13 +57,16 @@ +diff --git a/drivers/net/ixgbe/base/ixgbe_osdep.h b/drivers/net/ixgbe/base/ixgbe_osdep.h +index 72d45e2792..d8640dc7e6 100644 +--- a/drivers/net/ixgbe/base/ixgbe_osdep.h ++++ b/drivers/net/ixgbe/base/ixgbe_osdep.h +@@ -56,13 +56,16 @@ @@ -70 +51 @@ -@@ -130,8 +133,8 @@ static inline uint32_t ixgbe_read_addr(volatile void* addr) +@@ -127,8 +130,8 @@ static inline uint32_t ixgbe_read_addr(volatile void* addr) @@ -81,5 +62,5 @@ -diff --git a/drivers/net/intel/ixgbe/base/meson.build b/drivers/net/intel/ixgbe/base/meson.build -index f8b2ee6341..64e0bfd7be 100644 ---- a/drivers/net/intel/ixgbe/base/meson.build -+++ b/drivers/net/intel/ixgbe/base/meson.build -@@ -19,17 +19,6 @@ sources = [ +diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/meson.build +index ab775d8c66..b3cd74e805 100644 +--- a/drivers/net/ixgbe/base/meson.build ++++ b/drivers/net/ixgbe/base/meson.build +@@ -17,17 +17,6 @@ sources = [