From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF20346A63 for ; Thu, 26 Jun 2025 14:07:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D7AE7400D6; Thu, 26 Jun 2025 14:07:42 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2050.outbound.protection.outlook.com [40.107.100.50]) by mails.dpdk.org (Postfix) with ESMTP id 64990400D6 for ; Thu, 26 Jun 2025 14:07:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nHjwvHIZU/y5SwaLz83ick73AWbZq0NDsuhygLFO++CXCwAcAbss2EXnvEYEDdDIK/pFQn4bezc/j3xum9EPiaZ0IX9hRNolac/OhpQmX0PjBwPcgkFphEuaHQ4WGuys2snhbAhOQQ14BHNtJ/AIGxA67lt9yTxNF+gTOaaadaLXShN6ROlSaTPOTuENfgP17t+eU3Rn4ENqERSx1pnTiWIwlnQW4L665IE8TzXVx0TqjoL1pkk7iJeiuJLVvNwRgb2BMJJ8i/NpJJb8uIQgnRDIvmjRdfNPfbjodddqlYzralAZ/kdzPy4uVx9wWgv7ROlDq6wdPT2aMRsy9DtZvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oLuOPSG7LwfYRik6li6ZVY4KrnN33raI+4+4GawGw6w=; b=vvqWvw+by8m1/7JTke5lc0PItFf/I5nmn2ciPRfsG1HBOKtRksxel4s+S3/F0gOUDv8fUMAuef1FwYVBy3DFg++Qlup1K5023UhvheguOKmtSq22E57UIX2WsYsB0UKeEOM3x1FQNectbr9+kYm7hEhHiUKjw1+p7oc4t9Yq96AncZ/vwVSPJc6lkwKbcZk0uwb9P3tM1SyoxTYLdDVULHEdc1yDksmd+PzMh4u2qFTaU13qWBJCMuN10NDsFsq8oM6xEKQd0Oem45b61lSVJW61O+tugHrXG5LTcRlvMLJviNfBL2hgg9oz/9rRKadWaBa5yF4fm1EbSRTUFrNJEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oLuOPSG7LwfYRik6li6ZVY4KrnN33raI+4+4GawGw6w=; b=mLq6ZBFpJfmymroM1fRdVLRzVN/VVy6VzsrYlBD7Q6aMLeOZMwa+mpmwECrZ4ZqNrgOiIlwp54uLMilXIO1gThDASAPDymvhX8YyWo4wz9q8CDWR3yFuL3Ph1aguaewSSfczuIwb72W/MxEqEpkuZwxPzc03mty1r9yLft+qvA4ZRcb1nB8/cmYc3fUkXNSU31/akF2gMQc0d7qpggQIc3nRtaaWWU+JlFJy4jtekB/YAZNCYKsnmlbebO59CZO6eyZ9o/cXS6MWE9pBSqxrggTiVUAtuch8FK88QEtaS4wvy0F9p6sCokvZv3vCiOPCX6Qh9dqULDcDMUKA7XABqQ== Received: from MW4PR03CA0146.namprd03.prod.outlook.com (2603:10b6:303:8c::31) by DS0PR12MB7631.namprd12.prod.outlook.com (2603:10b6:8:11e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.25; Thu, 26 Jun 2025 12:07:39 +0000 Received: from SJ5PEPF000001D6.namprd05.prod.outlook.com (2603:10b6:303:8c:cafe::ca) by MW4PR03CA0146.outlook.office365.com (2603:10b6:303:8c::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.20 via Frontend Transport; Thu, 26 Jun 2025 12:07:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001D6.mail.protection.outlook.com (10.167.242.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:07:38 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:07:25 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:07:23 -0700 From: Xueming Li To: Maayan Kashani CC: Xueming Li , dpdk stable Subject: patch 'ethdev: fix error struct in flow configure' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:01:21 +0800 Message-ID: <20250626120145.27369-62-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D6:EE_|DS0PR12MB7631:EE_ X-MS-Office365-Filtering-Correlation-Id: 471c4e3e-c39a-48a4-0db1-08ddb4aa0ba6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?gEJCt7Ibc7r/BnWnEcbvwGHlDzNPpagzS2KdnzelAHQPeGhV7GKaUyVDVCxQ?= =?us-ascii?Q?KhbTsrDX3S+3tQvI+a+F0Wf4ndQ4YSumSs5frSyRKenzA2/6UnK6MH3zZ8+i?= =?us-ascii?Q?qPzgTgmnkZCpXLbS+2Vp9Wi3JLa7jlcRYpGCWWB+RzZkdC50nnjxG633gDId?= =?us-ascii?Q?cp1gr4meISqMOCiwoXQp/TqTFH01PJp6n2Bc3BWH70hmYz997WzU1BLQCJwe?= =?us-ascii?Q?b7m+oyHKpTkHpXSnVl4EEwZGj8qIqDl0H8WjOx/7479+HvhHg2OdEErgR3rq?= =?us-ascii?Q?m9dSfHZslmoDZ+UTmHi6uDScnAvXtzTiQMRxnGdQqf2i6EymMqJ+vbIfwPh8?= =?us-ascii?Q?JmmIgGbcUXgfCPy9z4SB2iMQe7cYwdTtsEUWVVkeKz5WAq8VM/6BAe2FXVT5?= =?us-ascii?Q?T7YfFyTFRjLiwOL1VRTO8mt2gsNbfCOibXqifihWFUaFRZk6olpoU1m0X2mP?= =?us-ascii?Q?ly6nja7LQv+jGNHesjEJXFMkXIBgE5j/4+KntIF+vEWRlqN1VKQynjB27vDJ?= =?us-ascii?Q?ca+bB08lRM7o0AqDBdTsaQRCyHAm0xDdpBeNPSWZfpKImU9s+7Bi9+66qL4W?= =?us-ascii?Q?Ocd+SFiFAfn6zT7UtFVh6waWUIj5I4IzNVzsaYYjy/aJ+VM7W/fNj18jkYJ5?= =?us-ascii?Q?x9cMcqM7o0z6BWEAcz0UvxVNNA4vaJhtuYRxey3TZIpVRrhEA+ub5RcX1SCG?= =?us-ascii?Q?SBxOiUzhJoiUNpemhiHGdF/isr0I4fHmiXIkcrqMfRawAuNhnC/2QuqBfBHo?= =?us-ascii?Q?z0i8xg+pZEGsVJHocxGYsW6QhZ7Hr3r9Gn1pYNRU/vZbrQvX0zULuPvsrR0l?= =?us-ascii?Q?qPXRjLCBVtlTPy4PIQ6vLW6RvutVMyTVcQXDWgoEk6wkFQKXM+uIM8AtrQzP?= =?us-ascii?Q?3ZjgnWHGCb0dpfBHD5OGuW+PJb374eUe6EvhKdyx28GxG9ppECtmpELwKZm3?= =?us-ascii?Q?zlGx90znfCfqIUzKK1cECJOddfWY1Hu/LKgk3WB6f2zPQBpwHeeXjbmM4a8A?= =?us-ascii?Q?hEZ1Q5X1SXjrrU9iAolmcRhwMv/3CVKPWTVnQzZIL3V1E9XixDj0OQ9ipkTQ?= =?us-ascii?Q?kHbb+XIqC2P7t5tYzhwThGtBk1sdTWfndaI94BuMT2D7foSrDbmmokaStvKf?= =?us-ascii?Q?N3Rkrmlxzkt60y8bO244L4Kd0Au1Q28QKTuci8vDJ3RUTpKDTcGNT0Uv8ce2?= =?us-ascii?Q?fUNhIwhiMlgXF233LNb87aox1nrBUH8WJsnAt5c0FcOcBNnly1V2Pyhh4ogM?= =?us-ascii?Q?VyPndV5c3s0zowRWLmFrQdtzo15U1yP6aqqAlk3Pqqq+BL1qZ//LBR6K/OMP?= =?us-ascii?Q?FmgPxegg70uRw9ICR9CmmoJKRUnQPqZ7Va20y1CpNz8CzN/hX6cWGMiQ+NdU?= =?us-ascii?Q?a5VGRKPCJlGQ/StiTXej6Hf7f7nUQR5SR1KWgH79wNLhL9198pXTDewACXc5?= =?us-ascii?Q?TG6qQAGDfC+FztC8F8EVYF85PNBLyAKez9DSkXMKUOKaMbBUtlqvSQAIkLM7?= =?us-ascii?Q?WkmYZTpsMe+X5tH99+u5Trj1wZ3RdJhE5hgxbAXX2c9cY2viizJ/tJ2Tmw?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:07:38.9034 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 471c4e3e-c39a-48a4-0db1-08ddb4aa0ba6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D6.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7631 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=87abb5b57dcf720c4ec72799664d16fcae1736b8 Thanks. Xueming Li --- >From 87abb5b57dcf720c4ec72799664d16fcae1736b8 Mon Sep 17 00:00:00 2001 From: Maayan Kashani Date: Thu, 29 May 2025 08:56:10 +0300 Subject: [PATCH] ethdev: fix error struct in flow configure Cc: Xueming Li [ upstream commit af7ac22d8da82398065d5f3c799c17a7cec3a6af ] rte_flow_configure() returned error value w/o filling the error struct which caused a crash on complain function. Filling the error struct fixed the issue. Fixes: 4ff58b734bc9 ("ethdev: introduce flow engine configuration") Signed-off-by: Maayan Kashani --- lib/ethdev/rte_flow.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index fa2a8fedce..cce9e08168 100644 --- a/lib/ethdev/rte_flow.c +++ b/lib/ethdev/rte_flow.c @@ -1675,21 +1675,21 @@ rte_flow_configure(uint16_t port_id, RTE_FLOW_LOG(INFO, "Device with port_id=%"PRIu16" is not configured.\n", port_id); - return -EINVAL; + goto error; } if (dev->data->dev_started != 0) { RTE_FLOW_LOG(INFO, "Device with port_id=%"PRIu16" already started.\n", port_id); - return -EINVAL; + goto error; } if (port_attr == NULL) { RTE_FLOW_LOG(ERR, "Port %"PRIu16" info is NULL.\n", port_id); - return -EINVAL; + goto error; } if (queue_attr == NULL) { RTE_FLOW_LOG(ERR, "Port %"PRIu16" queue info is NULL.\n", port_id); - return -EINVAL; + goto error; } if ((port_attr->flags & RTE_FLOW_PORT_FLAG_SHARE_INDIRECT) && !rte_eth_dev_is_valid_port(port_attr->host_port_id)) { @@ -1710,6 +1710,10 @@ rte_flow_configure(uint16_t port_id, return rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, rte_strerror(ENOTSUP)); +error: + return rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, + NULL, rte_strerror(EINVAL)); } struct rte_flow_pattern_template * -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:20.115243030 +0800 +++ 0061-ethdev-fix-error-struct-in-flow-configure.patch 2025-06-26 19:59:17.446418041 +0800 @@ -1 +1 @@ -From af7ac22d8da82398065d5f3c799c17a7cec3a6af Mon Sep 17 00:00:00 2001 +From 87abb5b57dcf720c4ec72799664d16fcae1736b8 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit af7ac22d8da82398065d5f3c799c17a7cec3a6af ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 9f8d8f3dc2..fe8f43caff 100644 +index fa2a8fedce..cce9e08168 100644 @@ -23,3 +25,3 @@ -@@ -1725,21 +1725,21 @@ rte_flow_configure(uint16_t port_id, - FLOW_LOG(INFO, - "Device with port_id=%"PRIu16" is not configured.", +@@ -1675,21 +1675,21 @@ rte_flow_configure(uint16_t port_id, + RTE_FLOW_LOG(INFO, + "Device with port_id=%"PRIu16" is not configured.\n", @@ -31,2 +33,2 @@ - FLOW_LOG(INFO, - "Device with port_id=%"PRIu16" already started.", + RTE_FLOW_LOG(INFO, + "Device with port_id=%"PRIu16" already started.\n", @@ -38 +40 @@ - FLOW_LOG(ERR, "Port %"PRIu16" info is NULL.", port_id); + RTE_FLOW_LOG(ERR, "Port %"PRIu16" info is NULL.\n", port_id); @@ -43 +45 @@ - FLOW_LOG(ERR, "Port %"PRIu16" queue info is NULL.", port_id); + RTE_FLOW_LOG(ERR, "Port %"PRIu16" queue info is NULL.\n", port_id); @@ -49 +51 @@ -@@ -1760,6 +1760,10 @@ rte_flow_configure(uint16_t port_id, +@@ -1710,6 +1710,10 @@ rte_flow_configure(uint16_t port_id, @@ -59 +61 @@ - RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_flow_pattern_template_create, 22.03) + struct rte_flow_pattern_template *